[RUM/PROF] Tag profiles with operation's start vital's id#4617
Open
MandragoreVR wants to merge 1 commit into
Open
[RUM/PROF] Tag profiles with operation's start vital's id#4617MandragoreVR wants to merge 1 commit into
MandragoreVR wants to merge 1 commit into
Conversation
4b4c2e9 to
c0b41ae
Compare
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: c0b41ae | Docs | Datadog PR Page | Give us feedback! |
Contributor
|
@codex review? |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
BeltranBulbarellaDD
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
As part of the Custom profiling initiative, custom profiles will be linked to Operation events. Since on the SDK side, Operation events are represented by a start vital and a stop vital, we decided (and this is already implemented as such in the iOS SDK) to tag the profiles overlapping with an operation with the start vital's id of that operation.
This PR implements this change.
Changes
vitalHistorytypeandoperationKeyto the data stored in the historyundefinedduration to represent that it's still activefindAllEntriestovalueHistory, that is the same asfindAllbut returns the entries instead of the values.Test instructions - Tested locally
When the operation is not over, here's what it looks like in the profile:
And when it's over, same but with a duration:
Checklist