Skip to content

Commit 71c03a1

Browse files
authored
Bump rules_python from 1.6.3 to 1.8.3 (#46017)
### What does this PR do? Update `rules_python` from version 1.6.3 to 1.8.3 with the aim at reducing the number of warnings seen in CI, which tend to indicate an underlying combinatorial explosion when looking for Python wheels. ### Motivation Some CI runs generate thousands of warnings like: ``` DEBUG: rules_python:pypi:create_whl_repos WARNING: Could not find a whl or an sdist with sha256=... ``` ([example](https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/1406186495)). While switching to version 1.8.x alone is unlikely to eliminate all warnings, it brings changes that should help reduce their frequency: - bazel-contrib/rules_python#3225 - bazel-contrib/rules_python#3385 - bazel-contrib/rules_python#3441 - bazel-contrib/rules_python#3432 - bazel-contrib/rules_python#3447 ### Describe how you validated your changes For that, I'll be monitoring logs once the change is merged to the mainline, see why below. ### Additional Notes Coming next: - this is a mitigation/preparation step: if warning counts don't decrease significantly, the next step would be to add `target_platforms` to the `pip.parse()` configuration to explicitly limit platform checks, which is worth a dedicated PR, - even if it's tiny, the patch on `rules_python` must be removed once bazel-contrib/rules_python#3579 is addressed. Without it, we used to face `ValueError`s which were preventing the version bump. Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
1 parent 76c4667 commit 71c03a1

3 files changed

Lines changed: 253 additions & 6 deletions

File tree

MODULE.bazel

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ bazel_dep(name = "bazel_skylib", version = "1.9.0")
4444
bazel_dep(name = "bazel_lib", version = "3.1.1")
4545
bazel_dep(name = "rules_go", version = "0.59.0") # for https://github.com/bazel-contrib/rules_go/pull/4493
4646
bazel_dep(name = "rules_pkg", version = "1.2.0")
47+
bazel_dep(name = "rules_python", version = "1.8.3")
4748
bazel_dep(name = "rules_shell", version = "0.6.1")
4849
bazel_dep(name = "libarchive", version = "3.8.1")
4950

@@ -56,6 +57,12 @@ git_override(
5657
remote = "https://github.com/bazelbuild/rules_pkg.git",
5758
)
5859

60+
# Temporary until rules_python > 1.8.3
61+
single_version_override(
62+
module_name = "rules_python",
63+
patches = ["//bazel/patches:rules_python-issue-3579.patch"],
64+
)
65+
5966
#########################
6067
## Prebuilt binaries ##
6168
#########################
@@ -161,8 +168,6 @@ visual_studio(
161168
# Keep in sync with .python-version
162169
PYTHON_VERSION = "3.12"
163170

164-
bazel_dep(name = "rules_python", version = "1.6.3")
165-
166171
python = use_extension("@rules_python//python/extensions:python.bzl", "python")
167172
python.defaults(python_version = PYTHON_VERSION)
168173
python.toolchain(

0 commit comments

Comments
 (0)