[ABLD-8] Split the pkgconfig files from "all_files" but leave in pkg_install. (#46044)

Split the pkgconfig files out from "all_files" and leave only in the pkg_install rule, through the deps tree.

In #46025, we will start to include "all_files" directly.

- That is more managable than having to know all the component parts of each dependency.
- This limits installing .pc files to the omnibus scripts.
- Since they do not go into the package image, we don't have to delete them later.
- Eventually we'll just delete the pc targets since they won't be needed any more.

This probably has missed some packages. That is fine. We can discover and fix them later, after #46025 is landed and they merge into that scheme.

## Testing
Compared the .deb files for  a recent PR #45988 to this. They are identical except for the expected diff of the link opt/datadog-packages/datadog-agent/stable

Co-authored-by: tony.aiuto <tony.aiuto@datadoghq.com>

Author: aiuto

deps/acl/overlay/overlay.BUILD.bazel

@@ -217,13 +217,14 @@ pkg_filegroup(
     srcs = [
         ":hdr_files",
         ":lib_files",
-        ":pc_file",
     ],
+    visibility = ["@@//deps/openscap:__pkg__", "@@//packages:__subpackages__"],
 )
 
 pkg_install(
     name = "install",
     srcs = [
         ":all_files",
+        ":pc_file",
     ],
 )

deps/attr/attr.BUILD.bazel

@@ -7,7 +7,7 @@ load("@package_metadata//rules:package_metadata.bzl", "package_metadata")
 load("@rules_cc//cc:defs.bzl", "cc_library", "cc_shared_library")
 load("@rules_license//rules:license.bzl", "license")
 load("@rules_pkg//pkg:install.bzl", "pkg_install")
-load("@rules_pkg//pkg:mappings.bzl", "pkg_files")
+load("@rules_pkg//pkg:mappings.bzl", "pkg_filegroup", "pkg_files")
 
 package(default_package_metadata = [":package_metadata", ":ship_source_offer"])
 
@@ -135,11 +135,19 @@ pkg_files(
     prefix = "embedded/lib/pkgconfig",
 )
 
-pkg_install(
-    name = "install",
+pkg_filegroup(
+    name = "all_files",
     srcs = [
         ":hdr_files",
         ":lib_files",
+    ],
+    visibility = ["@@//deps/openscap:__pkg__", "@@//packages:__subpackages__"],
+)
+
+pkg_install(
+    name = "install",
+    srcs = [
+        ":all_files",
         ":pc_file",
     ],
 )

deps/bzip2/overlay.BUILD.bazel

@@ -172,11 +172,14 @@ pkg_filegroup(
     srcs = [
         ":hdr_files",
         ":lib_files",
-        ":pkg_pc_file",
     ],
+    visibility = ["@@//deps/openscap:__pkg__", "@@//packages:__subpackages__"],
 )
 
 pkg_install(
     name = "install",
-    srcs = [":all_files"],
+    srcs = [
+        ":all_files",
+        ":pkg_pc_file",
+    ],
 )

deps/dbus/dbus.BUILD.bazel

@@ -1,9 +1,9 @@
+load("@bazel_skylib//rules:copy_file.bzl", "copy_file")
 load("@bazel_skylib//rules:expand_template.bzl", "expand_template")
 load("@rules_cc//cc:cc_library.bzl", "cc_library")
 load("@rules_license//rules:license.bzl", "license")
 load("@rules_pkg//pkg:install.bzl", "pkg_install")
-load("@rules_pkg//pkg:mappings.bzl", "pkg_files")
-load("@bazel_skylib//rules:copy_file.bzl", "copy_file")
+load("@rules_pkg//pkg:mappings.bzl", "pkg_filegroup", "pkg_files")
 
 package(default_package_metadata = [":license"])
 
@@ -26,7 +26,7 @@ copy_file(
 cc_library(
     name = "config_h",
     hdrs = [
-        ":copy_config_h"
+        ":copy_config_h",
     ],
 )
 
@@ -64,7 +64,7 @@ expand_template(
         "@DBUS_MAJOR_VERSION@": "1",
         "@DBUS_MINOR_VERSION@": "16",
         "@DBUS_MICRO_VERSION@": "2",
-    }
+    },
 )
 
 cc_library(
@@ -118,12 +118,12 @@ cc_library(
         "dbus/dbus-transport-unix.c",
         "dbus/dbus-userdb.c",
         ":dbus_arch_deps_h",
-    ] + glob(["dbus/*.h"], exclude=PUBLIC_HEADERS),
+    ] + glob(["dbus/*.h"], exclude = PUBLIC_HEADERS),
     hdrs = PUBLIC_HEADERS,
     local_defines = [
         "_GNU_SOURCE",
         "__USE_MINGW_ANSI_STDIO=0",
-        "dbus_1_EXPORTS"
+        "dbus_1_EXPORTS",
     ],
     copts = [
         "-O2",
@@ -155,7 +155,7 @@ expand_template(
         "@VERSION@": "1.16.2",
         "@LIBDBUS_LIBS@": "-pthread",
         "@DBUS_STATIC_BUILD_CPPFLAGS@": "",
-    }
+    },
 )
 
 pkg_files(
@@ -183,12 +183,20 @@ pkg_files(
     prefix = "lib/dbus-1.0/include/dbus",
 )
 
+pkg_filegroup(
+    name = "all_files",
+    srcs = [
+        ":headers",
+        ":lib_files",
+        ":dbus_arch_deps_install",
+    ],
+    visibility = ["@@//deps/openscap:__pkg__", "@@//packages:__subpackages__"],
+)
+
 pkg_install(
     name = "install",
     srcs = [
-        ":headers",
+        ":all_files",
         ":pkgconfig",
-        ":lib_files",
-        ":dbus_arch_deps_install"
     ],
 )

deps/gcrypt/gcrypt.BUILD.bazel

@@ -6,7 +6,7 @@ load("@bazel_skylib//rules:expand_template.bzl", "expand_template")
 load("@package_metadata//rules:package_metadata.bzl", "package_metadata")
 load("@rules_license//rules:license.bzl", "license")
 load("@rules_pkg//pkg:install.bzl", "pkg_install")
-load("@rules_pkg//pkg:mappings.bzl", "pkg_files")
+load("@rules_pkg//pkg:mappings.bzl", "pkg_filegroup", "pkg_files")
 
 package(
     default_package_metadata = [":license"],
@@ -779,11 +779,19 @@ pkg_files(
     prefix = "include",
 )
 
-pkg_install(
-    name = "install",
+pkg_filegroup(
+    name = "all_files",
     srcs = [
         ":hdr_files",
         ":lib_files",
+    ],
+    visibility = ["@@//deps/openscap:__pkg__", "@@//packages:__subpackages__"],
+)
+
+pkg_install(
+    name = "install",
+    srcs = [
+        ":all_files",
         ":pc_file",
     ],
 )

deps/krb5/krb5.BUILD.bazel

@@ -161,12 +161,20 @@ pkg_filegroup(
     prefix = "embedded/",
 )
 
-pkg_install(
-    name = "install",
+pkg_filegroup(
+    name = "all_files",
     srcs = [
         ":hdr_files",
-        ":pc_files",
         ":bin_files",
         ":all_libs",
     ],
+    visibility = ["@@//packages:__subpackages__"],
+)
+
+pkg_install(
+    name = "install",
+    srcs = [
+        ":all_files",
+        ":pc_files",
+    ],
 )

deps/libselinux.BUILD.bazel

@@ -4,7 +4,7 @@ load("@package_metadata//rules:package_metadata.bzl", "package_metadata")
 load("@rules_cc//cc:defs.bzl", "cc_library")
 load("@rules_license//rules:license.bzl", "license")
 load("@rules_pkg//pkg:install.bzl", "pkg_install")
-load("@rules_pkg//pkg:mappings.bzl", "pkg_files")
+load("@rules_pkg//pkg:mappings.bzl", "pkg_filegroup", "pkg_files")
 
 package(
     default_package_metadata = [":package_metadata"],
@@ -112,11 +112,19 @@ pkg_files(
     prefix = "lib/pkgconfig",
 )
 
-pkg_install(
-    name = "install",
+pkg_filegroup(
+    name = "all_files",
     srcs = [
         ":hdr_files",
         ":lib_files",
+    ],
+    visibility = ["@@//deps/openscap:__pkg__", "@@//packages:__subpackages__"],
+)
+
+pkg_install(
+    name = "install",
+    srcs = [
+        ":all_files",
         ":pc_file",
     ],
 )

deps/libsepol.BUILD.bazel

@@ -5,7 +5,7 @@ load("@package_metadata//rules:package_metadata.bzl", "package_metadata")
 load("@rules_cc//cc:defs.bzl", "cc_library")
 load("@rules_license//rules:license.bzl", "license")
 load("@rules_pkg//pkg:install.bzl", "pkg_install")
-load("@rules_pkg//pkg:mappings.bzl", "pkg_files")
+load("@rules_pkg//pkg:mappings.bzl", "pkg_filegroup", "pkg_files")
 
 package(default_package_metadata = [":package_metadata", ":ship_source_offer"])
 
@@ -120,12 +120,20 @@ pkg_files(
     prefix = "lib/pkgconfig",
 )
 
-pkg_install(
-    name = "install",
+pkg_filegroup(
+    name = "all_files",
     srcs = [
         ":hdr_files",
         ":policy_hdr_files",
         ":lib_files",
+    ],
+    visibility = ["@@//deps/openscap:__pkg__", "@@//packages:__subpackages__"],
+)
+
+pkg_install(
+    name = "install",
+    srcs = [
+        ":all_files",
         ":pc_file",
     ],
 )

deps/libxslt/overlay.BUILD.bazel

@@ -4,7 +4,7 @@ load("@bazel_skylib//rules:expand_template.bzl", "expand_template")
 load("@rules_cc//cc:defs.bzl", "cc_library", "cc_shared_library")
 load("@rules_license//rules:license.bzl", "license")
 load("@rules_pkg//pkg:install.bzl", "pkg_install")
-load("@rules_pkg//pkg:mappings.bzl", "pkg_files")
+load("@rules_pkg//pkg:mappings.bzl", "pkg_filegroup", "pkg_files")
 
 XSLT_VERSION = "1.1.43"
 EXSLT_VERSION = "0.8.25"
@@ -245,13 +245,21 @@ pkg_files(
     prefix = "lib/pkgconfig",
 )
 
-pkg_install(
-    name = "install",
+pkg_filegroup(
+    name = "all_files",
     srcs = [
         ":xslt_headers",
         ":exslt_headers",
-        ":pkgconfig",
         ":xslt_lib_files",
         ":exslt_lib_files",
     ],
+    visibility = ["@@//deps/openscap:__pkg__", "@@//packages:__subpackages__"],
+)
+
+pkg_install(
+    name = "install",
+    srcs = [
+        ":all_files",
+        ":pkgconfig",
+    ],
 )

deps/libyaml.BUILD.bazel

@@ -4,7 +4,7 @@ load("@@//bazel/rules:so_symlink.bzl", "so_symlink")
 load("@bazel_skylib//rules:expand_template.bzl", "expand_template")
 load("@rules_license//rules:license.bzl", "license")
 load("@rules_pkg//pkg:install.bzl", "pkg_install")
-load("@rules_pkg//pkg:mappings.bzl", "pkg_files")
+load("@rules_pkg//pkg:mappings.bzl", "pkg_filegroup", "pkg_files")
 
 VERSION = "0.2.5"
 
@@ -82,11 +82,19 @@ pkg_files(
     prefix = "lib/pkgconfig",
 )
 
+pkg_filegroup(
+    name = "all_files",
+    srcs = [
+        ":headers",
+        ":lib_files",
+    ],
+    visibility = ["@@//deps/openscap:__pkg__", "@@//packages:__subpackages__"],
+)
+
 pkg_install(
     name = "install",
     srcs = [
-        ":lib_files",
-        ":headers",
+        ":all_files",
         ":pkgconfig",
     ],
 )