Skip to content

Commit f7bbaf9

Browse files
authored
ci(jobowners): refine @DataDog/multiple ownership for tests_* and new-e2e* (#49826)
### What does this PR do? Refines the two `@DataDog/multiple` catch-alls in `.gitlab/JOBOWNERS` (`tests_*`, `new-e2e*`) into per-team patterns, and drops `@DataDog/multiple` entirely in favor of `@DataDog/agent-devx` as the fallback for uncategorized jobs. ### Motivation Done to better involve owning teams in CI incident resolution. Today, `@DataDog/multiple` routes hundreds of `tests_*` / `new-e2e-*` failures to no specific owner even though ownership is already knowable from the job's `TEAM:` variable — this sends incidents directly to the team that owns the code being tested. Any uncategorized job falls back to `agent-devx` (owner of the test framework, runners, and this file) rather than the nobody-owns-it `multiple` alias. ### Judgment calls (please sanity-check for your team's jobs) - **`tests_*` fallback** → `@DataDog/agent-devx`: generic Linux/macOS unit tests exercise the whole repo; no single product team owns them. - **`new-e2e*` fallback** → `@DataDog/agent-devx`: same rationale; agent-devx owns the e2e framework and runners. - **`protobuf_test`** → `@DataDog/agent-runtimes`: owners of `/pkg/proto/` and the `dda inv protobuf.generate` task. - **`tests_flavor_iot*` / `tests_flavor_heroku*`** → `@DataDog/agent-runtimes`: no dedicated CODEOWNERS entry; best guess. - **`new-e2e-windows-systemprobe*`** → shared with `ebpf-platform` even though the job's `TEAM:` var is only `windows-products`, because the test exercises system-probe. - **`new-e2e-windows-fips-compliance-test*`** → shared with `agent-runtimes` to mirror the non-Windows `new-e2e-fips-compliance-test*` owner. - **`new-e2e-sbom`** (agent-security + container-integrations) and **`new-e2e-cspm`** (agent-cspm + agent-security): shared ownership mirrors CODEOWNERS. - **`new-e2e-installer-windows*`** → shared fleet + windows-products (installer logic is fleet-owned, Windows specifics are windows-products). ### Describe how you validated your changes `dda inv -- -e linter.full-gitlab-ci` passes (incl. `jobowners-exist`). ### Additional Notes _None._ Co-authored-by: nicolas.schweitzer <nicolas.schweitzer@datadoghq.com>
1 parent c02df1a commit f7bbaf9

1 file changed

Lines changed: 67 additions & 3 deletions

File tree

.gitlab/JOBOWNERS

Lines changed: 67 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,23 @@ fetch_openjdk @DataDog/agent-metric-pipelines
1919

2020
# Source test
2121
# Notifications are handled separately for more fine-grained control on go tests
22-
tests_* @DataDog/multiple
22+
# tests_* defaults to agent-devx, with overrides below
23+
tests_* @DataDog/agent-devx
2324
tests_ebpf* @DataDog/ebpf-platform
25+
tests_gpu @DataDog/ebpf-platform
26+
tests_windows-x64 @DataDog/windows-products
2427
tests_windows_sysprobe* @DataDog/windows-products
28+
tests_windows_secagent* @DataDog/windows-products @DataDog/agent-security
29+
tests_flavor_* @DataDog/agent-runtimes
30+
tests_flavor_dogstatsd* @DataDog/agent-metric-pipelines
31+
tests_nodetreemodel @DataDog/agent-configuration
32+
tests_rtloader* @DataDog/agent-runtimes
33+
tests_serverless-init* @DataDog/serverless-azure-gcp
2534
security_go_generate_check @DataDog/agent-security
2635
prepare_sysprobe_ebpf_functional_tests* @DataDog/ebpf-platform
2736
prepare_secagent_ebpf_functional_tests* @DataDog/agent-security
2837
procmgr_rust_tests @DataDog/agent-runtimes
29-
protobuf_test @DataDog/multiple
38+
protobuf_test @DataDog/agent-runtimes
3039
test_kmt_local_setup* @DataDog/ebpf-platform
3140

3241
# Send count metrics about Golang dependencies
@@ -182,7 +191,62 @@ k8s-e2e-cspm-* @DataDog/agent-security
182191

183192
# New E2E
184193
e2e_pre_test* @DataDog/agent-devx
185-
new-e2e* @DataDog/multiple
194+
# new-e2e* defaults to @DataDog/agent-devx
195+
# More detailed rules are following for precise team match
196+
# latest match wins
197+
new-e2e* @DataDog/agent-devx
198+
# --- E2E framework / infra ---
199+
new-e2e-base* @DataDog/agent-devx
200+
new-e2e-unit-tests @DataDog/agent-devx
201+
new-e2e-cleanup-on-failure @DataDog/agent-devx
202+
# --- Agent core ---
203+
new-e2e-agent-configuration* @DataDog/agent-configuration
204+
new-e2e-agent-subcommands* @DataDog/agent-configuration
205+
new-e2e-agent-runtimes* @DataDog/agent-runtimes
206+
new-e2e-agent-health @DataDog/agent-health
207+
new-e2e-fips-compliance-test* @DataDog/agent-runtimes
208+
new-e2e-remote-config @DataDog/remote-config
209+
# --- Containers / orchestration / SSI ---
210+
new-e2e-containers* @DataDog/container-integrations @DataDog/container-platform
211+
new-e2e-orchestrator* @DataDog/kubernetes-experiences
212+
new-e2e-language-detection @DataDog/container-experiences
213+
new-e2e-process* @DataDog/container-experiences
214+
new-e2e-ssi* @DataDog/injection-platform
215+
# --- Networking ---
216+
new-e2e-npm* @DataDog/cloud-network-monitoring
217+
new-e2e-netpath* @DataDog/network-path
218+
new-e2e-ndm-netflow* @DataDog/ndm-integrations
219+
new-e2e-ndm-snmp* @DataDog/network-device-monitoring-core
220+
new-e2e-ha-agent* @DataDog/network-device-monitoring-core
221+
# --- Pipelines (metrics / logs / traces) ---
222+
new-e2e-amp @DataDog/agent-metric-pipelines
223+
new-e2e-alp* @DataDog/agent-log-pipelines
224+
new-e2e-apm* @DataDog/agent-apm
225+
# --- Security ---
226+
new-e2e-cws* @DataDog/agent-security
227+
new-e2e-sbom* @DataDog/agent-security
228+
new-e2e-cspm @DataDog/agent-cspm @DataDog/agent-security
229+
# --- OpenTelemetry ---
230+
new-e2e-otel* @DataDog/opentelemetry-agent
231+
# --- Fleet / installer (non-Windows) ---
232+
new-e2e-fleet* @DataDog/fleet
233+
new-e2e-installer* @DataDog/fleet
234+
# --- Agent packaging (install scripts, step-by-step, package signing) ---
235+
new-e2e-agent-platform-* @DataDog/fleet
236+
new-e2e-platform-integrations-* @DataDog/agent-runtimes
237+
new-e2e-package-signing-* @DataDog/agent-delivery
238+
# --- GPU ---
239+
new-e2e-gpu* @DataDog/ebpf-platform
240+
# --- Action platform / discovery ---
241+
new-e2e-privateactionrunner @DataDog/action-platform
242+
new-e2e-discovery @DataDog/agent-discovery
243+
# --- Windows-only jobs (single owner: windows-products) ---
244+
new-e2e-windows-* @DataDog/windows-products
245+
# --- Shared-ownership overrides (must come after the per-category rules above) ---
246+
new-e2e-installer-windows* @DataDog/fleet @DataDog/windows-products
247+
new-e2e-windows-security-agent @DataDog/windows-products @DataDog/agent-security
248+
new-e2e-windows-fips-compliance-test* @DataDog/windows-products @DataDog/agent-runtimes
249+
new-e2e-windows-systemprobe* @DataDog/windows-products @DataDog/ebpf-platform
186250
go_e2e_test_binaries @DataDog/agent-devx
187251
all-artifacts @DataDog/agent-devx
188252

0 commit comments

Comments
 (0)