[procmgr] Cross-platform E2E tests and Windows install-test expectations#49871
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomainfrom Apr 28, 2026
Merged
Conversation
jose-manuel-almaza
added
changelog/no-changelog
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ffd8f316f7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
|
🎯 Code Coverage (details) 🔗 Commit SHA: f6fa0ec | Docs | Datadog PR Page | Give us feedback! |
Contributor
Files inventory check summaryFile checks results against ancestor 59d95519: Results for datadog-agent_7.80.0~devel.git.270.f6fa0ec.pipeline.110082500-1_amd64.deb:No change detected |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: c50d9ea Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | -0.71 | [-3.64, +2.21] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +1.26 | [+1.09, +1.44] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | +0.62 | [+0.47, +0.78] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | +0.48 | [+0.38, +0.57] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | +0.47 | [+0.38, +0.57] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.24 | [+0.20, +0.28] | 1 | Logs bounds checks dashboard |
| ➖ | otlp_ingest_metrics | memory utilization | +0.18 | [+0.02, +0.34] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.18 | [+0.13, +0.23] | 1 | Logs bounds checks dashboard |
| ➖ | file_tree | memory utilization | +0.12 | [+0.07, +0.17] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | +0.08 | [+0.03, +0.14] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | +0.07 | [-0.91, +1.05] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.06 | [-0.05, +0.16] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.03 | [-0.40, +0.45] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.01 | [-0.03, +0.06] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.20, +0.21] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.11, +0.10] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | -0.00 | [-0.21, +0.20] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.02 | [-0.41, +0.37] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.03 | [-0.57, +0.51] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | -0.10 | [-0.29, +0.10] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | -0.42 | [-0.66, -0.17] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | -0.52 | [-0.71, -0.32] | 1 | Logs |
| ➖ | docker_containers_cpu | % cpu utilization | -0.71 | [-3.64, +2.21] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | -1.08 | [-1.33, -0.83] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | 703 ≥ 26 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | 241.69MiB ≤ 370MiB | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | 526 ≥ 26 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | 0.16GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_0ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | 0.20GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_1000ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | 0.17GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_100ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | 0.18GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_500ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | 3 ≤ 4 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | 140.91MiB ≤ 147MiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | 3 ≤ 4 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | 471.59MiB ≤ 495MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 3 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | 174.30MiB ≤ 195MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 349.82 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 376.25MiB ≤ 430MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
Contributor
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 485e4f200a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jose-manuel-almaza
force-pushed
the
jose/procmgr-windows-s24-e2e-tests
branch
from
485e4f2 to
6e4bd8f
Compare
jose-manuel-almaza
force-pushed
the
jose/procmgr-windows-s23-installer-integration
branch
from
8957b5c to
7ca08b3
Compare
jose-manuel-almaza
force-pushed
the
jose/procmgr-windows-s24-e2e-tests
branch
from
225370f to
e8b40fe
Compare
jose-manuel-almaza
force-pushed
the
jose/procmgr-windows-s23-installer-integration
branch
from
7ca08b3 to
7fe7b7c
Compare
Contributor
Static quality checks❌ Please find below the results from static quality gates Error
Gate failure full details
Static quality gates prevent the PR to merge! Successful checksInfo
22 successful checks with minimal change (< 2 KiB)
On-wire sizes (compressed)
|
jose-manuel-almaza
force-pushed
the
jose/procmgr-windows-s23-installer-integration
branch
from
1f815eb to
1b0df6b
Compare
jose-manuel-almaza
force-pushed
the
jose/procmgr-windows-s24-e2e-tests
branch
2 times, most recently
from
eb453a6 to
8a9042e
Compare
fabbing
approved these changes
Apr 27, 2026
clarkb7
approved these changes
Apr 27, 2026
clarkb7
reviewed
Apr 27, 2026
github-actions
Bot
added
long review
Base automatically changed from
jose/procmgr-windows-s23-installer-integration
to
main
April 27, 2026 20:01
gh-worker-dd-mergequeue-cf854d
Bot
requested review from
a team,
cmourot and
dd-ddamien
as code owners
Introduce shared E2E test logic for dd-procmgr on both Linux and Windows using the new-e2e framework: - baseProcmgrSuite with platformConfig to abstract OS differences - Linux suite (procmgrLinuxSuite) using /bin/sleep - Windows suite (procmgrWindowsSuite) using PowerShell Start-Sleep with explicit env vars for the env-cleared child process - Tests: service status, CLI describe, CLI list, missing binary skip - Windows SetupSuite explicitly starts the DEMAND_START service
jose-manuel-almaza
force-pushed
the
jose/procmgr-windows-s24-e2e-tests
branch
from
38ac304 to
b9ba1a1
Compare
The agent-runtimes E2E tests include Windows test suites but the path was not listed in windows_path_3, so changes there never triggered the Windows pipeline (MSI build + E2E jobs).
Contributor
Gitlab CI Configuration ChangesModified Jobsworkflow (configuration) workflow:
rules:
- if: $CI_PIPELINE_SOURCE == "trigger" || $CI_PIPELINE_SOURCE == "pipeline"
- if: $CI_COMMIT_BRANCH == "main"
variables:
BAZEL_CACHE_POLICY_SUFFIX: -push
GO_TEST_SKIP_FLAKE: 'false'
- if: $CI_COMMIT_BRANCH =~ /^[0-9]+\.[0-9]+\.x$/
- if: $DEPLOY_AGENT == "true" || $DDR_WORKFLOW_ID != null
- if: $RUN_E2E_TESTS == "on"
- if: $DEPLOY_INSTALLER == "true" || $DDR_WORKFLOW_ID != null
- if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
- changes:
compare_to: main
paths:
- '**/*_windows.go'
- pkg/util/winutil/**/*
- pkg/windowsdriver/**/*
- pkg/util/pdhutil/**/*
- pkg/util/crashreport/**/*
- pkg/collector/corechecks/system/wincrashdetect/**/*
- pkg/collector/corechecks/system/windowscertificate/**/*
- pkg/collector/corechecks/system/winkmem/**/*
- pkg/collector/corechecks/system/winproc/**/*
- pkg/collector/corechecks/net/wlan/**/*
- pkg/logs/launchers/windowsevent/**/*
- pkg/logs/tailers/windowsevent/**/*
- pkg/logs/util/windowsevent/**/*
- pkg/network/driver/**/*
- pkg/config/**/*
- cmd/agent/**/*
- cmd/process-agent/**/*
- cmd/security-agent/**/*
- cmd/otel-agent/**/*
- cmd/privateactionrunner/**/*
- cmd/system-probe/**/*
- cmd/trace-agent/**/*
- cmd/installer/**/*
- cmd/systray/**/*
- cmd/otel-agent/**/*
variables:
SKIP_WINDOWS: 'false'
- changes:
compare_to: main
paths:
- comp/systray/**/*
- comp/updater/**/*
- comp/checks/agentcrashdetect/**/*
- comp/checks/windowseventlog/**/*
- comp/checks/winregistry/**/*
- comp/metadata/hostsysteminfo/**/*
- comp/trace/etwtracer/**/*
- comp/etw/**/*
- comp/notableevents/**/*
- comp/publishermetadatacache/**/*
- comp/softwareinventory/**/*
- tools/windows/**/*
- omnibus/**/*
- packages/**/*
- rtloader/**/*
- Dockerfiles/agent/windows/**/*
- Dockerfiles/agent/entrypoint.ps1
- Dockerfiles/agent/entrypoint.d.windows/**/*
- chocolatey/**/*
- tasks/msi.py
- tasks/winbuild.py
- tasks/winbuildscripts/**/*
- tasks/windows_resources.py
- tasks/systray.py
- release.json
- .gitlab-ci.yml
- .gitlab/**/*
variables:
SKIP_WINDOWS: 'false'
- changes:
compare_to: main
paths:
- test/new-e2e/tests/fleet/**/*
- test/new-e2e/tests/installer/windows/**/*
- test/new-e2e/tests/windows/**/*
- test/new-e2e/tests/sysprobe-functional/**/*
- test/new-e2e/tests/process/**/*
+ - test/new-e2e/tests/agent-runtimes/**/*
variables:
SKIP_WINDOWS: 'false'
- changes:
compare_to: main
paths:
- '*.bazel*'
- deps/**/*
- bazel/**/*
variables:
SKIP_WINDOWS: 'false'
- if: $CI_COMMIT_TAG == null
variables:
SKIP_WINDOWS: 'true'.windows_path_3 .windows_path_3:
- test/new-e2e/tests/fleet/**/*
- test/new-e2e/tests/installer/windows/**/*
- test/new-e2e/tests/windows/**/*
- test/new-e2e/tests/sysprobe-functional/**/*
- test/new-e2e/tests/process/**/*
+ - test/new-e2e/tests/agent-runtimes/**/*Changes Summary
ℹ️ Diff available in the job log. |
chouetz
approved these changes
Apr 28, 2026
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
jose/procmgr-windows-s24-e2e-tests
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Extracts shared procmgr E2E test logic into a
baseProcmgrSuitewith aplatformConfigabstraction, so the same 6 smoke tests (TestBinariesExist,TestServiceRunning,TestCLIStatus,TestCLIListShowsConfiguredProcess,TestCLIDescribe,TestConditionPathExistsSkipsMissingBinary) run on both Linux and Windows without code duplication.Adds
procmgr_win_test.gowith a Windows-specific provisioner (WindowsServerDefaultEC2) and PowerShell-based service/binary checks.Adds
test/new-e2e/tests/agent-runtimes/**/*to thewindows_path_3change-detection list in.gitlab-ci.ymlso that changes to agent-runtimes E2E tests trigger the Windows CI pipeline (MSI build + Windows E2E jobs).Motivation
dd-procmgrdwas integrated into the Windows MSI installer (S23) but had no E2E test coverage for the Windows platform. The existing Linux procmgr E2E tests validated the CLI and service behavior but were not reusable across platforms. This PR closes that gap by making the tests cross-platform and ensuring the Windows E2E pipeline is triggered when agent-runtimes tests change.Describe how you validated your changes
go vet ./test/new-e2e/tests/agent-runtimes/procmgr/...passesdd-procmgrdinstalls, starts via SCM, responds to CLI commands, and logs toC:\ProgramData\Datadog\logs\dd-procmgr.logAdditional Notes