Configure renovate to automatically update workspace devcontainer#49873
Configure renovate to automatically update workspace devcontainer#49873gh-worker-dd-mergequeue-cf854d[bot] merged 50 commits intomainfrom
Conversation
Prebuilt devcontainer image reference updated to reflect latest config. This automation in driven by the [workspaces-image-builder service](https://sdp.ddbuild.io/#/services/details?name=workspaces-imagebuilder) and the [github-devcontainer-prebuild service](https://sdp.ddbuild.io/#/services/details?name=github-devcontainer-prebuild). For workspaces on-call: If there are any unexpected behaviors with this automation, see the [troubleshooting runbook](https://datadoghq.atlassian.net/wiki/spaces/DEVX/pages/4880237711/Troubleshooting+Devcontainer+Pre-Builds). Co-authored-by: gh-worker-campaigns-3e9aa4[bot] <244854796+gh-worker-campaigns-3e9aa4[bot]@users.noreply.github.com>
Prebuilt devcontainer image reference updated to reflect latest config. This automation in driven by the [workspaces-image-builder service](https://sdp.ddbuild.io/#/services/details?name=workspaces-imagebuilder) and the [github-devcontainer-prebuild service](https://sdp.ddbuild.io/#/services/details?name=github-devcontainer-prebuild). For workspaces on-call: If there are any unexpected behaviors with this automation, see the [troubleshooting runbook](https://datadoghq.atlassian.net/wiki/spaces/DEVX/pages/4880237711/Troubleshooting+Devcontainer+Pre-Builds). Co-authored-by: gh-worker-campaigns-3e9aa4[bot] <244854796+gh-worker-campaigns-3e9aa4[bot]@users.noreply.github.com>
Prebuilt devcontainer image reference updated to reflect latest config. This automation in driven by the [workspaces-image-builder service](https://sdp.ddbuild.io/#/services/details?name=workspaces-imagebuilder) and the [github-devcontainer-prebuild service](https://sdp.ddbuild.io/#/services/details?name=github-devcontainer-prebuild). For workspaces on-call: If there are any unexpected behaviors with this automation, see the [troubleshooting runbook](https://datadoghq.atlassian.net/wiki/spaces/DEVX/pages/4880237711/Troubleshooting+Devcontainer+Pre-Builds). Co-authored-by: gh-worker-campaigns-3e9aa4[bot] <244854796+gh-worker-campaigns-3e9aa4[bot]@users.noreply.github.com>
Prebuilt devcontainer image reference updated to reflect latest config. This automation in driven by the [workspaces-image-builder service](https://sdp.ddbuild.io/#/services/details?name=workspaces-imagebuilder) and the [github-devcontainer-prebuild service](https://sdp.ddbuild.io/#/services/details?name=github-devcontainer-prebuild). For workspaces on-call: If there are any unexpected behaviors with this automation, see the [troubleshooting runbook](https://datadoghq.atlassian.net/wiki/spaces/DEVX/pages/4880237711/Troubleshooting+Devcontainer+Pre-Builds). Co-authored-by: gh-worker-campaigns-3e9aa4[bot] <244854796+gh-worker-campaigns-3e9aa4[bot]@users.noreply.github.com>
…g-agent into kfairise/devcontainer-git
Prebuilt devcontainer image reference updated to reflect latest config. This automation in driven by the [workspaces-image-builder service](https://sdp.ddbuild.io/#/services/details?name=workspaces-imagebuilder) and the [github-devcontainer-prebuild service](https://sdp.ddbuild.io/#/services/details?name=github-devcontainer-prebuild). For workspaces on-call: If there are any unexpected behaviors with this automation, see the [troubleshooting runbook](https://datadoghq.atlassian.net/wiki/spaces/DEVX/pages/4880237711/Troubleshooting+Devcontainer+Pre-Builds). Co-authored-by: gh-worker-campaigns-3e9aa4[bot] <244854796+gh-worker-campaigns-3e9aa4[bot]@users.noreply.github.com>
Prebuilt devcontainer image reference updated to reflect latest config. This automation in driven by the [workspaces-image-builder service](https://sdp.ddbuild.io/#/services/details?name=workspaces-imagebuilder) and the [github-devcontainer-prebuild service](https://sdp.ddbuild.io/#/services/details?name=github-devcontainer-prebuild). For workspaces on-call: If there are any unexpected behaviors with this automation, see the [troubleshooting runbook](https://datadoghq.atlassian.net/wiki/spaces/DEVX/pages/4880237711/Troubleshooting+Devcontainer+Pre-Builds). Co-authored-by: gh-worker-campaigns-3e9aa4[bot] <244854796+gh-worker-campaigns-3e9aa4[bot]@users.noreply.github.com>
Prebuilt devcontainer image reference updated to reflect latest config. This automation in driven by the [workspaces-image-builder service](https://sdp.ddbuild.io/#/services/details?name=workspaces-imagebuilder) and the [github-devcontainer-prebuild service](https://sdp.ddbuild.io/#/services/details?name=github-devcontainer-prebuild). For workspaces on-call: If there are any unexpected behaviors with this automation, see the [troubleshooting runbook](https://datadoghq.atlassian.net/wiki/spaces/DEVX/pages/4880237711/Troubleshooting+Devcontainer+Pre-Builds). Co-authored-by: gh-worker-campaigns-3e9aa4[bot] <244854796+gh-worker-campaigns-3e9aa4[bot]@users.noreply.github.com>
Gitlab CI Configuration ChangesAdded Jobsprebuild-workspace-image-checkprebuild-workspace-image-check:
image: registry.ddbuild.io/ci/datadog-agent-buildimages/linux$CI_IMAGE_LINUX_SUFFIX:$CI_IMAGE_LINUX
needs: []
rules:
- if: $CI_COMMIT_BRANCH == "main"
when: never
- if: $CI_COMMIT_BRANCH =~ /^[0-9]+\.[0-9]+\.x$/
when: never
- if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
when: never
- changes:
compare_to: $COMPARE_TO_BRANCH
paths:
- .devcontainer/datadog/default/**/*
script:
- bash tools/prebuild-devcontainer-check.sh
stage: setup
tags:
- arch:amd64
- specific:trueChanges Summary
ℹ️ Diff available in the job log. |
Files inventory check summaryFile checks results against ancestor eed01b7e: Results for datadog-agent_7.80.0~devel.git.323.2944356.pipeline.110199192-1_amd64.deb:No change detected |
…/auto-workspace-update
175fde7 to
2944356
Compare
ee14839 to
2944356
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 29443568ce
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # variables available. They have opposite meanings (see https://github.com/DataDog/dd-source/pull/194529#issuecomment-2775985239). | ||
| source_ref="${DDCI_PULL_REQUEST_TARGET_SHA:-${SOURCE_REF:-}}" | ||
| if [[ -z "$source_ref" ]]; then | ||
| source_ref="$(git symbolic-ref -q refs/remotes/origin/HEAD)" |
There was a problem hiding this comment.
Handle missing origin/HEAD before diffing devcontainer changes
When this script runs from the new GitLab job, none of DDCI_PULL_REQUEST_* or SOURCE_REF/TARGET_REF are set by the workflow, so it falls back to git symbolic-ref -q refs/remotes/origin/HEAD. In GitLab-style checkouts created by git init/fetch (and in this workspace), that symbolic ref can be absent; with set -e the assignment exits immediately with status 1 before either diff runs, causing prebuild-workspace-image-check to fail for any matching .devcontainer/datadog/default change without the intended error message. Fall back to the configured compare branch (for example origin/$COMPARE_TO_BRANCH) or tolerate the missing symbolic ref before proceeding.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
That script is copy pasted from Workspaces doc
614a918
into
main
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 329389b Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | -1.37 | [-4.29, +1.56] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_metrics_logs | memory utilization | +0.67 | [+0.42, +0.92] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_idle | memory utilization | +0.15 | [+0.10, +0.20] | 1 | Logs bounds checks dashboard |
| ➖ | otlp_ingest_logs | memory utilization | +0.06 | [-0.04, +0.16] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | +0.06 | [+0.00, +0.12] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | +0.05 | [-0.11, +0.22] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | +0.03 | [-0.13, +0.18] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.02 | [-0.40, +0.45] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.19, +0.21] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.01 | [-0.38, +0.40] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | +0.00 | [-0.20, +0.20] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.09, +0.09] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | -0.01 | [-0.19, +0.17] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.03 | [-0.13, +0.08] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.03 | [-0.20, +0.13] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.04 | [-0.57, +0.49] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | -0.09 | [-0.33, +0.15] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | -0.19 | [-0.38, +0.00] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.20 | [-0.25, -0.15] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | -0.21 | [-0.34, -0.08] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | -0.29 | [-0.34, -0.25] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.42 | [-0.45, -0.38] | 1 | Logs bounds checks dashboard |
| ➖ | docker_containers_cpu | % cpu utilization | -1.37 | [-4.29, +1.56] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -2.76 | [-3.73, -1.79] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | 501 ≥ 26 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | 241.68MiB ≤ 370MiB | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | 722 ≥ 26 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | 0.16GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_0ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | 0.20GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_1000ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | 0.17GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_100ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | 0.18GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_500ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | 3 ≤ 4 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | 141.28MiB ≤ 147MiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | 3 ≤ 4 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | 470.27MiB ≤ 495MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | 176.90MiB ≤ 195MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 344.95 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 370.81MiB ≤ 430MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
What does this PR do?
Configure renovate + script to make sure the image for devcontainer is auto-updated
Motivation
Describe how you validated your changes
Additional Notes