Skip to content

Have one and only one \n character at the end of the system-probe.yaml #49885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 2 commits into from
Apr 28, 2026
Merged

Have one and only one \n character at the end of the system-probe.yaml #49885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2dcce31
Have one and only one newline character at the end of the system-prob…
Stanislas167 Apr 24, 2026
90a4688
correct test
Stanislas167 Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions pkg/config/render_config/render_config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,20 +113,17 @@ func mkContext(buildType string, osName string) context {
}

func render(destFile string, tplFile string, component string, osName string) {
f, err := os.Create(destFile)
if err != nil {
panic(err)
}

tplFilename := filepath.Base(tplFile)

t := template.Must(template.New(tplFilename).ParseFiles(tplFile))
err = t.Execute(f, mkContext(component, osName))
if err != nil {
var buf bytes.Buffer
if err := t.Execute(&buf, mkContext(component, osName)); err != nil {
panic(err)
}

if err := f.Close(); err != nil {
rendered := append(bytes.TrimRight(buf.Bytes(), "\n\r \t"), '\n')

if err := os.WriteFile(destFile, rendered, 0644); err != nil {
panic(err)
}
}
Expand Down
2 changes: 1 addition & 1 deletion tasks/schema/template.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ def generate_template(schema_file, dest, build_type, os_target):

final_render = [line.strip() for line in config_template.strip().split("\n")]
with open(dest, "w") as f:
f.write("\n".join(final_render))
f.write("\n".join(final_render) + "\n")


@task(
Expand Down
Loading