Skip to content

feat: [SVLS-8975] restore deprecated config for serverless-init#49887

Closed
apiarian-datadog wants to merge 1 commit intomainfrom
aleksandr.pasechnik/svls-8975-restore-serverless-init-stats-primary-tag-config
Closed

feat: [SVLS-8975] restore deprecated config for serverless-init#49887
apiarian-datadog wants to merge 1 commit intomainfrom
aleksandr.pasechnik/svls-8975-restore-serverless-init-stats-primary-tag-config

Conversation

@apiarian-datadog
Copy link
Copy Markdown
Contributor

What does this PR do?

Restore the deprecated config for span derived primary tags on agent computed stats. This config is deprecated in the main agent in favor of CSS (Client Side Stats, tracer-computed stats). But those don't currently support span derived primary tagging, so we enable this in the serverless-init code for now. This functionality should not be used in any other context.

Describe how you validated your changes

Unit tests and e2e tests.

@apiarian-datadog apiarian-datadog requested review from a team as code owners April 24, 2026 16:44
@dd-octo-sts dd-octo-sts Bot added internal Identify a non-fork PR team/agent-apm trace-agent labels Apr 24, 2026
@github-actions github-actions Bot added the medium review PR review might take time label Apr 24, 2026
@datadog-official
Copy link
Copy Markdown
Contributor

datadog-official Bot commented Apr 24, 2026

🎯 Code Coverage (details)
Patch Coverage: 77.78%
Overall Coverage: 50.40% (+0.21%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ad86736 | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented Apr 24, 2026

Files inventory check summary

File checks results against ancestor 98f495be:

Results for datadog-agent_7.80.0~devel.git.186.ad86736.pipeline.109607880-1_amd64.deb:

No change detected

@cit-pr-commenter-54b7da
Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 2155f04b-d86c-449d-9900-3398675ca8a4

Baseline: 98f495b
Comparison: ad86736
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +2.92 [-0.13, +5.97] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +2.92 [-0.13, +5.97] 1 Logs
quality_gate_logs % cpu utilization +2.69 [+0.99, +4.38] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization +0.82 [+0.56, +1.09] 1 Logs bounds checks dashboard
ddot_logs memory utilization +0.45 [+0.39, +0.51] 1 Logs
otlp_ingest_logs memory utilization +0.23 [+0.12, +0.34] 1 Logs
ddot_metrics memory utilization +0.22 [+0.02, +0.42] 1 Logs
file_tree memory utilization +0.18 [+0.14, +0.23] 1 Logs
quality_gate_idle memory utilization +0.12 [+0.07, +0.18] 1 Logs bounds checks dashboard
file_to_blackhole_100ms_latency egress throughput +0.02 [-0.11, +0.15] 1 Logs
ddot_metrics_sum_delta memory utilization +0.01 [-0.17, +0.19] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.20, +0.20] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.11, +0.12] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.01 [-0.24, +0.23] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.02 [-0.22, +0.19] 1 Logs
quality_gate_idle_all_features memory utilization -0.04 [-0.08, -0.01] 1 Logs bounds checks dashboard
file_to_blackhole_500ms_latency egress throughput -0.05 [-0.44, +0.34] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.06 [-0.59, +0.47] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.08 [-0.52, +0.36] 1 Logs
otlp_ingest_metrics memory utilization -0.13 [-0.28, +0.03] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.26 [-0.31, -0.21] 1 Logs
docker_containers_memory memory utilization -0.39 [-0.49, -0.29] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.51 [-0.69, -0.32] 1 Logs
ddot_metrics_sum_cumulative memory utilization -1.06 [-1.22, -0.90] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
docker_containers_cpu simple_check_run 10/10 706 ≥ 26
docker_containers_memory memory_usage 10/10 241.32MiB ≤ 370MiB
docker_containers_memory simple_check_run 10/10 689 ≥ 26
file_to_blackhole_0ms_latency memory_usage 10/10 0.16GiB ≤ 1.20GiB
file_to_blackhole_0ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_1000ms_latency memory_usage 10/10 0.20GiB ≤ 1.20GiB
file_to_blackhole_1000ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_100ms_latency memory_usage 10/10 0.17GiB ≤ 1.20GiB
file_to_blackhole_100ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_500ms_latency memory_usage 10/10 0.18GiB ≤ 1.20GiB
file_to_blackhole_500ms_latency missed_bytes 10/10 0B = 0B
quality_gate_idle intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 138.32MiB ≤ 143MiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 462.00MiB ≤ 495MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 174.84MiB ≤ 195MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 346.01 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 389.22MiB ≤ 430MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

Copy link
Copy Markdown
Contributor

@anais-raison anais-raison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@apiarian-datadog
Copy link
Copy Markdown
Contributor Author

not going to do this. we'll be waiting for the client side stats project to roll out with span-derived stats tagging in the tracers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Identify a non-fork PR medium review PR review might take time team/agent-apm trace-agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants