Skip to content

Prefer DNS endpoint in CI for mirrored Go packages#52499

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
mainfrom
ofek/reduce-go-adms-flakiness
Jun 23, 2026
Merged

Prefer DNS endpoint in CI for mirrored Go packages#52499
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
mainfrom
ofek/reduce-go-adms-flakiness

Conversation

@ofek

@ofek ofek commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Motivation

Service-to-service traffic is supposed to use internal DNS instead of the currently-prioritized gateway proxy, which intermittently throws 503s even though the underlying service is healthy.

Additional Notes

CI will pass when the build images have been updated, as seen here #52547

@ofek ofek added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Jun 19, 2026
@dd-octo-sts dd-octo-sts Bot added internal Identify a non-fork PR team/agent-build labels Jun 19, 2026
@github-actions github-actions Bot added the short review PR is simple enough to be reviewed quickly label Jun 19, 2026
@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Pipelines

Fix all issues with BitsAI

⚠️ Warnings

🚦 1 Pipeline job failed

DataDog/datadog-agent | oracle: [21.3.0-xe]   View in Datadog   GitLab

ℹ️ Info

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 50.94% (+0.01%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: f393356 | Docs | Datadog PR Page | Give us feedback!

@ofek ofek marked this pull request as ready for review June 19, 2026 18:15
@ofek ofek requested a review from a team as a code owner June 19, 2026 18:15
@github-actions github-actions Bot deleted a comment from chatgpt-codex-connector Bot Jun 19, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 14016695ec

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .adms/go/gitlab.yaml
@github-actions github-actions Bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Jun 19, 2026

@rdesgroppes rdesgroppes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but think about augmenting the ADMS mirror allowlist as spotted by Codex.

@dd-octo-sts

dd-octo-sts Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor d049f7e8:

Results for datadog-agent_7.82.0~devel.git.240.f393356.pipeline.120253458-1_amd64.deb:

No change detected

@ofek ofek force-pushed the ofek/reduce-go-adms-flakiness branch from fdd43e4 to 84b4d6a Compare June 22, 2026 01:15
@ofek ofek requested review from a team as code owners June 22, 2026 01:15
@ofek ofek requested review from truthbk and removed request for a team June 22, 2026 01:15

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 84b4d6a277

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .adms/go/gitlab.yaml
Comment thread Dockerfiles/agent-ddot/Dockerfile.agent-otel Outdated
@dd-octo-sts

dd-octo-sts Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Gitlab CI Configuration Changes

⚠️ Diff too large to display on Github.

Changes Summary

Removed Modified Added Renamed
0 156 2 0

ℹ️ Diff available in the job log.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Jun 22, 2026

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: b8bed0a6-4e53-40ff-b29f-71dd6481bcdc

Baseline: d049f7e
Comparison: f393356
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_idle_all_features memory utilization +0.17 [+0.13, +0.21] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization +0.16 [-0.09, +0.41] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -0.07 [-1.16, +1.02] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization -0.20 [-0.25, -0.15] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gate_idle intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 146.29MiB ≤ 154MiB bounds checks dashboard
quality_gate_idle total_bytes_received 10/10 579.91KiB ≤ 819.20KiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 479.85MiB ≤ 495MiB bounds checks dashboard
quality_gate_idle_all_features total_bytes_received 10/10 0.88MiB ≤ 1.25MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 3 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 180.97MiB ≤ 195MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs total_bytes_received 10/10 264.19MiB ≤ 292MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 324.44 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 3 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 397.91MiB ≤ 430MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs total_bytes_received 10/10 0.86GiB ≤ 1.04GiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment Variant Replicates Failure Logs Debug Dashboard
experiment_with_failures baseline 0 (x8) 1 (x6) Oom killed Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment Variant Replicates Failure Debug Dashboard
quality_gate_idle_all_features baseline 10 Oom killed Debug Dashboard
quality_gate_idle_all_features comparison 10 Oom killed Debug Dashboard
quality_gate_logs baseline 10 Oom killed Debug Dashboard
quality_gate_logs comparison 10 Oom killed Debug Dashboard
quality_gate_metrics_logs baseline 10 Oom killed Debug Dashboard
quality_gate_metrics_logs comparison 10 Oom killed Debug Dashboard

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@dd-octo-sts

dd-octo-sts Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor d049f7e
📊 Static Quality Gates Dashboard
🔗 SQG Job

33 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 747.917 MiB
agent_deb_amd64_fips 703.861 MiB
agent_heroku_amd64 308.587 MiB
agent_msi 615.907 MiB
agent_rpm_amd64 747.900 MiB
agent_rpm_amd64_fips 703.845 MiB
agent_rpm_arm64 723.518 MiB
agent_rpm_arm64_fips 683.115 MiB
agent_suse_amd64 747.900 MiB
agent_suse_amd64_fips 703.845 MiB
agent_suse_arm64 723.518 MiB
agent_suse_arm64_fips 683.115 MiB
docker_agent_amd64 807.616 MiB
docker_agent_arm64 808.129 MiB
docker_agent_jmx_amd64 998.513 MiB
docker_agent_jmx_arm64 987.679 MiB
docker_cluster_agent_amd64 208.044 MiB
docker_cluster_agent_arm64 221.251 MiB
docker_cws_instrumentation_amd64 7.447 MiB
docker_cws_instrumentation_arm64 6.877 MiB
docker_dogstatsd_amd64 39.008 MiB
docker_dogstatsd_arm64 37.117 MiB
docker_host_profiler_amd64 304.990 MiB
docker_host_profiler_arm64 316.090 MiB
dogstatsd_deb_amd64 29.747 MiB
dogstatsd_deb_arm64 27.798 MiB
dogstatsd_rpm_amd64 29.747 MiB
dogstatsd_suse_amd64 29.747 MiB
iot_agent_deb_amd64 45.675 MiB
iot_agent_deb_arm64 42.390 MiB
iot_agent_deb_armhf 43.175 MiB
iot_agent_rpm_amd64 45.676 MiB
iot_agent_suse_amd64 45.675 MiB

@ofek ofek requested a review from a team as a code owner June 22, 2026 03:32
@ofek ofek requested a review from hush-hush June 22, 2026 03:32
@github-actions github-actions Bot removed the medium review PR review might take time label Jun 22, 2026
@github-actions github-actions Bot added the long review PR is complex, plan time to review it label Jun 22, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bdbb964960

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Dockerfiles/agent-ddot/Dockerfile.agent-otel Outdated
@ofek ofek force-pushed the ofek/reduce-go-adms-flakiness branch from bdbb964 to d52e957 Compare June 22, 2026 04:58
@ofek ofek force-pushed the ofek/reduce-go-adms-flakiness branch from d52e957 to 1a152ca Compare June 22, 2026 13:30

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1a152ca130

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .gitlab/.pre/common/macos.yml
@ofek ofek force-pushed the ofek/reduce-go-adms-flakiness branch from 1a152ca to 5a7a623 Compare June 22, 2026 14:12
@ofek ofek force-pushed the ofek/reduce-go-adms-flakiness branch from 5a7a623 to f393356 Compare June 22, 2026 15:36
@ofek ofek requested a review from a team as a code owner June 22, 2026 15:36
@ofek

ofek commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jun 23, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-06-23 07:50:30 UTC ℹ️ Start processing command /merge


2026-06-23 07:50:35 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 2h (p90).


2026-06-23 08:47:55 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit ceea175 into main Jun 23, 2026
304 of 305 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the ofek/reduce-go-adms-flakiness branch June 23, 2026 08:47
@github-actions github-actions Bot added this to the 7.82.0 milestone Jun 23, 2026
@kacper-murzyn kacper-murzyn added the backport/7.81.x Automatically create a backport PR to the 7.81.x branch once the PR is merged label Jun 24, 2026
@Ishirui Ishirui added the backport/7.80.x Automatically create a backport PR to the 7.80.x branch once the PR is merged label Jun 24, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

⚠️ Automatic backport to 7.80.x failed.

This usually happens when the cherry-pick has merge conflicts and needs manual resolution.

To backport manually, run:

git fetch
git worktree add .worktrees/backport-7.80.x 7.80.x
cd .worktrees/backport-7.80.x
git switch --create backport-52499-to-7.80.x
git cherry-pick -x --mainline 1 ceea175a0fef26433ad39b8fceedd74defaaf420
git push --set-upstream origin backport-52499-to-7.80.x

Workflow logs: https://github.com/DataDog/datadog-agent/actions/runs/28084414113

Ishirui pushed a commit that referenced this pull request Jun 24, 2026
Service-to-service traffic is supposed to use internal DNS instead of the currently-prioritized gateway proxy, which intermittently throws 503s even though the underlying service is healthy.

CI will pass when the build images have been updated, as seen here #52547

Co-authored-by: ofek.lev <ofek.lev@datadoghq.com>
(cherry picked from commit ceea175)
gh-worker-dd-mergequeue-cf854d Bot pushed a commit that referenced this pull request Jun 25, 2026
…rored Go packages (#52499) (#52698)

Backport of #52499



Co-authored-by: ofek <ofekmeister@gmail.com>
Co-authored-by: ali.benabdallah <ali.benabdallah@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/7.80.x Automatically create a backport PR to the 7.80.x branch once the PR is merged backport/7.81.x Automatically create a backport PR to the 7.81.x branch once the PR is merged changelog/no-changelog No changelog entry needed internal Identify a non-fork PR long review PR is complex, plan time to review it qa/no-code-change No code change in Agent code requiring validation team/agent-build team/agent-configuration team/agent-devx team/ebpf-platform team/windows-products

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants