Skip to content

fix(ci): include *_windows_test.go in Windows change detection#52506

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
mainfrom
regis.desgroppes/ci-windows-path-detect-test-files
Jun 22, 2026
Merged

fix(ci): include *_windows_test.go in Windows change detection#52506
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
mainfrom
regis.desgroppes/ci-windows-path-detect-test-files

Conversation

@rdesgroppes

@rdesgroppes rdesgroppes commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Add **/*_windows_test.go to the .windows_path change filter, alongside the existing **/*_windows.go, so that edits confined to Windows-only test files set SKIP_WINDOWS=false and pull the Windows job set into dev-branch pipelines.

Motivation

Inspired by #incident-56493, this targets the broader family of "platform-specific code not triggering its platform CI" rather than that the incident specifically.

The filter indeed recognizes Windows code by the _windows.go filename convention but not its _windows_test.go test counterpart: GitLab changes: matches globs literally, and **/*_windows.go does not match foo_windows_test.go because of the _test infix.
A change limited to a Windows-only test file therefore skips every Windows job on dev branches, and the gap only surfaces on main.

Additional Notes

The incident's package diverges by host OS at runtime, where pkg/security/rules/monitor/policy_monitor_test.go embeds a runtime.GOOS code branch, which no filename filter can catch and which may instead require extracting the per-OS expectations into dedicated _windows_test.go / _linux_test.go files.
This might come as a separate, code-level follow-up - out of scope here.

### What does this PR do?
Add `**/*_windows_test.go` to the `.windows_path` change filter,
alongside the existing `**/*_windows.go`, so that edits confined to
Windows-only test files set `SKIP_WINDOWS=false` and pull the Windows
job set into dev-branch pipelines.

### Motivation
After [#incident-56493](https://dd.enterprise.slack.com/archives/C0BCQMGKKH6),
this targets the broader family of "platform-specific code not
triggering its platform CI" rather than that the incident specifically.

The filter indeed recognizes Windows code by the `_windows.go` filename
convention but not its `_windows_test.go` test counterpart: GitLab
`changes:` matches globs literally, and `**/*_windows.go` does not
match `foo_windows_test.go` because of the `_test` infix.
A change limited to a Windows-only test file therefore skips every
Windows job on dev branches, and the gap only surfaces on `main`.

The incident's package diverges by host OS **at runtime**, where
`pkg/security/rules/monitor/policy_monitor_test.go` embeds a
`runtime.GOOS` code branch, which no filename filter can catch and which
may instead require extracting the per-OS expectations into dedicated
`_windows_test.go` / `_linux_test.go` files.

### Additional Notes
The incident's package diverges by host OS **at runtime**, where
`pkg/security/rules/monitor/policy_monitor_test.go` embeds a
`runtime.GOOS` code branch, which no filename filter can catch and which
may instead require extracting the per-OS expectations into dedicated
`_windows_test.go` / `_linux_test.go` files.
This should come as a separate, code-level follow-up, out of scope here.
@rdesgroppes rdesgroppes added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Jun 19, 2026
@dd-octo-sts dd-octo-sts Bot added the internal Identify a non-fork PR label Jun 19, 2026
@github-actions github-actions Bot added the short review PR is simple enough to be reviewed quickly label Jun 19, 2026
@datadog-official

datadog-official Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 50.87% (-0.05%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 4c0ab9f | Docs | Datadog PR Page | Give us feedback!

@rdesgroppes rdesgroppes marked this pull request as ready for review June 19, 2026 22:40
@rdesgroppes rdesgroppes requested a review from a team as a code owner June 19, 2026 22:40
@github-actions github-actions Bot deleted a comment from chatgpt-codex-connector Bot Jun 19, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Gitlab CI Configuration Changes

Modified Jobs

workflow (configuration)
  workflow:
    rules:
    - if: $DDR_WORKFLOW_ID != null && $CI_COMMIT_BRANCH == "main"
      variables:
        BAZEL_CACHE_POLICY_SUFFIX: -push
        GO_TEST_SKIP_FLAKE: 'false'
        WINDOWS_SIGNING_CERT: s3://windows-code-signing-certificates/certs/beta/kms-signed.crt
        WINDOWS_SIGNING_CONFIG: s3://windows-code-signing-certificates/certs/beta/config.json
    - if: $CI_PIPELINE_SOURCE == "trigger" || $CI_PIPELINE_SOURCE == "pipeline"
    - if: $CI_COMMIT_BRANCH == "main"
      variables:
        BAZEL_CACHE_POLICY_SUFFIX: -push
        GO_TEST_SKIP_FLAKE: 'false'
    - if: $CI_COMMIT_BRANCH =~ /^[0-9]+\.[0-9]+\.x$/
    - if: $DEPLOY_AGENT == "true" || $DDR_WORKFLOW_ID != null
    - if: $RUN_E2E_TESTS == "on"
    - if: $DEPLOY_INSTALLER == "true" || $DDR_WORKFLOW_ID != null
    - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
    - changes:
        compare_to: main
        paths:
        - '**/*_windows.go'
+       - '**/*_windows_test.go'
        - pkg/util/winutil/**/*
        - pkg/windowsdriver/**/*
        - pkg/util/pdhutil/**/*
        - pkg/util/crashreport/**/*
        - pkg/collector/corechecks/system/wincrashdetect/**/*
        - pkg/collector/corechecks/system/windowscertificate/**/*
        - pkg/collector/corechecks/system/winkmem/**/*
        - pkg/collector/corechecks/system/winproc/**/*
        - pkg/collector/corechecks/net/wlan/**/*
        - pkg/logs/launchers/windowsevent/**/*
        - pkg/logs/tailers/windowsevent/**/*
        - pkg/logs/util/windowsevent/**/*
        - pkg/network/driver/**/*
        - pkg/config/**/*
        - cmd/agent/**/*
        - cmd/process-agent/**/*
        - cmd/security-agent/**/*
        - cmd/otel-agent/**/*
        - cmd/privateactionrunner/**/*
        - cmd/system-probe/**/*
        - cmd/trace-agent/**/*
        - cmd/installer/**/*
        - cmd/systray/**/*
        - cmd/otel-agent/**/*
      variables:
        SKIP_WINDOWS: 'false'
    - changes:
        compare_to: main
        paths:
        - comp/systray/**/*
        - comp/updater/**/*
        - comp/checks/agentcrashdetect/**/*
        - comp/checks/windowseventlog/**/*
        - comp/checks/winregistry/**/*
        - comp/metadata/hostsysteminfo/**/*
        - comp/trace/etwtracer/**/*
        - comp/etw/**/*
        - comp/notableevents/**/*
        - comp/publishermetadatacache/**/*
        - comp/softwareinventory/**/*
        - tools/windows/**/*
        - omnibus/**/*
        - packages/**/*
        - rtloader/**/*
        - Dockerfiles/agent/windows/**/*
        - Dockerfiles/agent/entrypoint.ps1
        - Dockerfiles/agent/entrypoint.d.windows/**/*
        - chocolatey/**/*
        - tasks/msi.py
        - tasks/winbuild.py
        - tasks/winbuildscripts/**/*
        - tasks/windows_resources.py
        - tasks/systray.py
        - release.json
        - .gitlab-ci.yml
        - .gitlab/**/*
      variables:
        SKIP_WINDOWS: 'false'
    - changes:
        compare_to: main
        paths:
        - test/new-e2e/tests/fleet/**/*
        - test/new-e2e/tests/installer/windows/**/*
        - test/new-e2e/tests/windows/**/*
        - test/new-e2e/tests/sysprobe-functional/**/*
        - test/new-e2e/tests/process/**/*
        - test/new-e2e/tests/agent-runtimes/**/*
      variables:
        SKIP_WINDOWS: 'false'
    - changes:
        compare_to: main
        paths:
        - '*.bazel*'
        - deps/**/*
        - bazel/**/*
        - tasks/build_tags.bzl
      variables:
        SKIP_WINDOWS: 'false'
    - if: $CI_COMMIT_TAG == null
      variables:
        SKIP_WINDOWS: 'true'
.windows_path
  .windows_path:
  - '**/*_windows.go'
+ - '**/*_windows_test.go'
  - pkg/util/winutil/**/*
  - pkg/windowsdriver/**/*
  - pkg/util/pdhutil/**/*
  - pkg/util/crashreport/**/*
  - pkg/collector/corechecks/system/wincrashdetect/**/*
  - pkg/collector/corechecks/system/windowscertificate/**/*
  - pkg/collector/corechecks/system/winkmem/**/*
  - pkg/collector/corechecks/system/winproc/**/*
  - pkg/collector/corechecks/net/wlan/**/*
  - pkg/logs/launchers/windowsevent/**/*
  - pkg/logs/tailers/windowsevent/**/*
  - pkg/logs/util/windowsevent/**/*
  - pkg/network/driver/**/*
  - pkg/config/**/*
  - cmd/agent/**/*
  - cmd/process-agent/**/*
  - cmd/security-agent/**/*
  - cmd/otel-agent/**/*
  - cmd/privateactionrunner/**/*
  - cmd/system-probe/**/*
  - cmd/trace-agent/**/*
  - cmd/installer/**/*
  - cmd/systray/**/*
  - cmd/otel-agent/**/*

Changes Summary

Removed Modified Added Renamed
0 2 0 0

ℹ️ Diff available in the job log.

@dd-octo-sts

dd-octo-sts Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor 409dcc9d:

Results for datadog-agent_7.82.0~devel.git.189.4c0ab9f.pipeline.120029391-1_amd64.deb:

No change detected

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit 292262a into main Jun 22, 2026
282 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the regis.desgroppes/ci-windows-path-detect-test-files branch June 22, 2026 17:37
@github-actions github-actions Bot added this to the 7.82.0 milestone Jun 22, 2026
@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 4d633197-7b02-4796-a79e-c5aefb1013e1

Baseline: e1c395e
Comparison: 292262a
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_security_mean_fs_load memory utilization +0.44 [+0.40, +0.48] 1 Logs bounds checks dashboard
quality_gate_security_idle memory utilization +0.28 [+0.21, +0.35] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization +0.15 [-0.10, +0.39] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization -0.02 [-0.07, +0.03] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization -0.25 [-0.29, -0.22] 1 Logs bounds checks dashboard
quality_gate_security_no_fs_load memory utilization -0.44 [-0.53, -0.34] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -1.77 [-2.83, -0.71] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gate_idle intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 147.07MiB ≤ 154MiB bounds checks dashboard
quality_gate_idle total_bytes_received 10/10 576.45KiB ≤ 819.20KiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 484.42MiB ≤ 495MiB bounds checks dashboard
quality_gate_idle_all_features total_bytes_received 10/10 0.89MiB ≤ 1.25MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 178.82MiB ≤ 195MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs total_bytes_received 10/10 264.18MiB ≤ 292MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 335.27 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 392.34MiB ≤ 430MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs total_bytes_received 10/10 0.86GiB ≤ 1.04GiB bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 29.31 ≤ 40 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 297.09MiB ≤ 330MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 62.78 ≤ 70 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 276.38MiB ≤ 320MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 21.96 ≤ 40 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 281.88MiB ≤ 320MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment Variant Replicates Failure Logs Debug Dashboard
experiment_with_failures baseline 0 (x8) 1 (x6) Oom killed Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment Variant Replicates Failure Debug Dashboard
quality_gate_idle_all_features baseline 10 Oom killed Debug Dashboard
quality_gate_logs baseline 10 Oom killed Debug Dashboard
quality_gate_logs comparison 10 Oom killed Debug Dashboard
quality_gate_metrics_logs baseline 10 Oom killed Debug Dashboard
quality_gate_metrics_logs comparison 10 Oom killed Debug Dashboard
quality_gate_security_idle baseline 10 Oom killed Debug Dashboard

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-devx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants