Update module github.com/DataDog/orchestrion to v1.10.0#52525
Conversation
renovate
Bot
added
changelog/no-changelog
ℹ️ Artifact update noticeFile name: test/new-e2e/go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
|
|
PRApprover will approve and merge this PR, FAQ, #dx-source-code-management 🛠️ PRApproval Status
➡️ Current phase: CI tests failed. Please fix the failing tests to continue. |
github-actions
Bot
added
the
short review
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4be3a06847
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| github.com/DataDog/datadog-go/v5 v5.8.3 | ||
| github.com/DataDog/dd-trace-go/v2 v2.8.2 | ||
| github.com/DataDog/orchestrion v1.4.0 | ||
| github.com/DataDog/orchestrion v1.10.0 |
There was a problem hiding this comment.
When this module is used to build precompiled E2E test binaries, the go_e2e_test_binaries job still installs github.com/DataDog/orchestrion@v1.4.0 before invoking new-e2e-tests.build-binaries (.gitlab/test/e2e/e2e.yml lines 198-201), and that task runs the orchestrion go test -c executable from PATH (tasks/new_e2e_tests.py line 140). As a result, this bump to v1.10.0 is not exercised in the CI path that builds those binaries; update the install command or derive it from this go.mod so the new tool version is actually used.
Useful? React with 👍 / 👎.
|
Files inventory check summaryFile checks results against ancestor d5959ae8: Results for datadog-agent_7.82.0~devel.git.225.d3840de.pipeline.120180256-1_amd64.deb:No change detected |
renovate
Bot
force-pushed
the
renovate/github.com-datadog-orchestrion-1.x
branch
3 times, most recently
from
761224d to
de2c880
Compare
![dd-prapprover[bot]](https://avatars.githubusercontent.com/in/1493831?s=60&v=4){kind=small}
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
devflow unqueued this merge request: It did not become mergeable within the expected time |
dd-prapprover
Bot
dismissed
their stale review
new commit added, dismiss all previous approvals
renovate
Bot
force-pushed
the
renovate/github.com-datadog-orchestrion-1.x
branch
2 times, most recently
from
4631a52 to
81b0351
Compare
renovate
Bot
force-pushed
the
renovate/github.com-datadog-orchestrion-1.x
branch
from
2231ec0 to
11cd984
Compare
This commit was created from the local commit with hash 4c0591da59178c71bcb4ed4d3e4dee9f59501580.
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
Gitlab CI Configuration ChangesModified Jobsgo_e2e_test_binaries go_e2e_test_binaries:
before_script:
- mkdir -p $GOPATH/pkg/mod/cache && zstd -dc modcache_e2e.tar.zst | tar xf - -C
$GOPATH/pkg/mod/cache
- rm -f modcache_e2e.tar.zst
image: registry.ddbuild.io/ci/datadog-agent-buildimages/linux$CI_IMAGE_LINUX_SUFFIX:$CI_IMAGE_LINUX
needs:
- go_e2e_deps
rules:
- if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
when: never
- when: on_success
script:
- pushd test/new-e2e
- - go install github.com/DataDog/orchestrion@v1.4.0
? ^
+ - go install github.com/DataDog/orchestrion@v1.10.0
? ^^
- popd
- dda inv -- -e new-e2e-tests.build-binaries --output-dir test-binaries -p $KUBERNETES_CPU_REQUEST
--manifest-file-path manifest.json
- dda inv -- -e new-e2e-tests.upload-binaries --output-dir test-binaries --manifest-file-path
manifest.json --s3-base-uri $S3_PERMANENT_ARTIFACTS_URI/e2e-pre-build/$CI_PIPELINE_ID
stage: binary_build
tags:
- arch:amd64
- specific:true
variables:
KUBERNETES_CPU_REQUEST: 4
KUBERNETES_MEMORY_LIMIT: 64Gi
KUBERNETES_MEMORY_REQUEST: 64GiChanges Summary
ℹ️ Diff available in the job log. |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
|
/merge |
|
View all feedbacks in Devflow UI.
PR already in the queue with status waiting |
gh-worker-dd-mergequeue-cf854d
Bot
merged commit bf824a8
into
main
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
renovate/github.com-datadog-orchestrion-1.x
branch
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: cda900e Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_idle_all_features | memory utilization | -0.11 | [-0.15, -0.07] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_idle | memory utilization | -0.35 | [-0.39, -0.30] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_logs | % cpu utilization | -0.59 | [-1.70, +0.51] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_metrics_logs | memory utilization | -0.90 | [-1.15, -0.65] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | quality_gate_idle | intake_connections | 10/10 | 3 ≤ 4 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | 146.02MiB ≤ 154MiB | bounds checks dashboard |
| ✅ | quality_gate_idle | total_bytes_received | 10/10 | 577.81KiB ≤ 819.20KiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | 3 ≤ 4 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | 487.03MiB ≤ 495MiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | total_bytes_received | 10/10 | 0.89MiB ≤ 1.25MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | 181.57MiB ≤ 195MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_logs | total_bytes_received | 10/10 | 264.18MiB ≤ 292MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 333.45 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 3 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 408.40MiB ≤ 430MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | total_bytes_received | 10/10 | 0.87GiB ≤ 1.04GiB | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Replicate Execution Details
We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.
Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.
| Experiment | Variant | Replicates | Failure | Logs | Debug Dashboard |
|---|---|---|---|---|---|
| experiment_with_failures | baseline | 0 (x8) 1 (x6) | Oom killed | Debug Dashboard |
The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.
❌ Retried Profiling Replicate Execution Failures (ddprof)
Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.
| Experiment | Variant | Replicates | Failure | Debug Dashboard |
|---|---|---|---|---|
| quality_gate_idle_all_features | baseline | 10 | Oom killed | Debug Dashboard |
| quality_gate_idle_all_features | comparison | 10 | Oom killed | Debug Dashboard |
| quality_gate_logs | baseline | 10 | Oom killed | Debug Dashboard |
| quality_gate_logs | comparison | 10 | Oom killed | Debug Dashboard |
| quality_gate_metrics_logs | baseline | 10 | Oom killed | Debug Dashboard |
| quality_gate_metrics_logs | comparison | 10 | Oom killed | Debug Dashboard |
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
2 participants
This PR contains the following updates:
v1.4.0→v1.10.0Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
DataDog/orchestrion (github.com/DataDog/orchestrion)
v1.10.0Compare Source
What's Changed
🐛 Bug Fixes
🔧 Maintenance
New Contributors
Full Changelog: DataDog/orchestrion@v1.9.0...v1.10.0
v1.9.0Compare Source
What's Changed
🚀 Features
🐛 Bug Fixes
ArgumentThatImplementsalways fails forcontext.Contextby @darccio in #798🔧 Maintenance
New Contributors
Full Changelog: DataDog/orchestrion@v1.8.0...v1.9.0
v1.8.0Compare Source
What's Changed
🚀 Features
dd-trace-gotov2.6.0by @nsrip-dd in #780Full Changelog: DataDog/orchestrion@v1.7.0...v1.8.0
v1.7.0Compare Source
What's Changed
🚀 Features
dd-trace-gotov2.5.0by @darccio in #765Full Changelog: DataDog/orchestrion@v1.6.1...v1.7.0
v1.6.1Compare Source
What's Changed
🐛 Bug Fixes
Full Changelog: DataDog/orchestrion@v1.6.0...v1.6.1
v1.6.0Compare Source
What's Changed
🚀 Features
🐛 Bug Fixes
dst.SelectorExprby @rarguelloF in #678New Contributors
Full Changelog: DataDog/orchestrion@v1.5.0...v1.6.0
v1.5.0Compare Source
What's Changed
🚀 Features
🐛 Bug Fixes
🔧 Maintenance
New Contributors
Full Changelog: DataDog/orchestrion@v1.4.0...v1.5.0
Configuration
📅 Schedule: (in timezone Europe/Paris)
* 0-4,22-23 * * 1-5)* * * * 0,6)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.