Skip to content

test: skip AIX-unsupported tests#53668

Open
pgimalac wants to merge 8 commits into
mainfrom
pgimalac/aix-skip-unsupported-tests
Open

test: skip AIX-unsupported tests#53668
pgimalac wants to merge 8 commits into
mainfrom
pgimalac/aix-skip-unsupported-tests

Conversation

@pgimalac

@pgimalac pgimalac commented Jul 15, 2026

Copy link
Copy Markdown
Member

What does this PR do?

Excludes tests which shouldn't (or can't) run on AIX.

Motivation

Fix unit tests on AIX.

Describe how you validated your changes

Ran tests on an AIX host.

Additional Notes

There are still a few tests failing, this is just the very first step to add an AIX unit test job in CI.

Two test packages fail on AIX because they exercise functionality that is not
available there:

- pkg/collector/corechecks/agentprofiling reads the agent process' memory/CPU
  usage via gopsutil (process.NewProcess), which returns "not implemented yet"
  on AIX, so every test that runs the check fails.
- pkg/fleet/installer/packages/user asserts Go's os/user error types
  (UnknownGroupError / UnknownUserError), which AIX's os/user does not return.

Exclude both test files on AIX with a //go:build constraint. Other platforms are
unaffected (verified: the test files are still compiled on linux and dropped
only for GOOS=aix).
@pgimalac pgimalac added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Jul 15, 2026
@dd-octo-sts dd-octo-sts Bot added the internal Identify a non-fork PR label Jul 15, 2026
@github-actions github-actions Bot added the short review PR is simple enough to be reviewed quickly label Jul 15, 2026
@datadog-prod-us1-6

datadog-prod-us1-6 Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 51.89% (+0.12%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: e65e16a | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor 19d25293:

Results for datadog-agent_7.83.0~devel.git.165.e65e16a.pipeline.125063045-1_amd64.deb:

No change detected

@dd-octo-sts

dd-octo-sts Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 19d2529
📊 Static Quality Gates Dashboard
🔗 SQG Job

33 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 750.991 MiB
agent_deb_amd64_fips 705.880 MiB
agent_heroku_amd64 307.701 MiB
agent_msi 645.658 MiB
agent_rpm_amd64 750.975 MiB
agent_rpm_amd64_fips 705.864 MiB
agent_rpm_arm64 726.058 MiB
agent_rpm_arm64_fips 684.632 MiB
agent_suse_amd64 750.975 MiB
agent_suse_amd64_fips 705.864 MiB
agent_suse_arm64 726.058 MiB
agent_suse_arm64_fips 684.632 MiB
docker_agent_amd64 809.698 MiB
docker_agent_arm64 809.785 MiB
docker_agent_jmx_amd64 1000.595 MiB
docker_agent_jmx_arm64 989.335 MiB
docker_cluster_agent_amd64 209.881 MiB
docker_cluster_agent_arm64 222.952 MiB
docker_cws_instrumentation_amd64 7.447 MiB
docker_cws_instrumentation_arm64 6.877 MiB
docker_dogstatsd_amd64 39.216 MiB
docker_dogstatsd_arm64 37.367 MiB
docker_host_profiler_amd64 303.100 MiB
docker_host_profiler_arm64 314.593 MiB
dogstatsd_deb_amd64 29.955 MiB
dogstatsd_deb_arm64 27.994 MiB
dogstatsd_rpm_amd64 29.955 MiB
dogstatsd_suse_amd64 29.955 MiB
iot_agent_deb_amd64 46.194 MiB
iot_agent_deb_arm64 42.882 MiB
iot_agent_deb_armhf 43.647 MiB
iot_agent_rpm_amd64 46.195 MiB
iot_agent_suse_amd64 46.194 MiB

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Jul 15, 2026

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 0b2bc939-e65e-43e9-a93a-02210fd16ba1

Baseline: 19d2529
Comparison: e65e16a
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_metrics_logs memory utilization +0.91 [+0.65, +1.17] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization +0.33 [+0.25, +0.41] 1 Logs bounds checks dashboard
quality_gate_security_no_fs_load memory utilization +0.23 [+0.13, +0.32] 1 Logs bounds checks dashboard
quality_gate_security_mean_fs_load memory utilization +0.22 [+0.18, +0.26] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.02 [-0.03, +0.07] 1 Logs bounds checks dashboard
quality_gate_security_idle memory utilization -0.12 [-0.17, -0.06] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -0.54 [-1.53, +0.45] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gate_idle intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 145.58MiB ≤ 154MiB bounds checks dashboard
quality_gate_idle total_bytes_received 10/10 733.33KiB ≤ 819.20KiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 491.85MiB ≤ 495MiB bounds checks dashboard
quality_gate_idle_all_features total_bytes_received 10/10 1.12MiB ≤ 1.25MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 181.52MiB ≤ 195MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs total_bytes_received 10/10 264.16MiB ≤ 292MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 352.99 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 3 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 398.37MiB ≤ 430MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs total_bytes_received 10/10 0.93GiB ≤ 1.04GiB bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 36.49 ≤ 100 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 299.75MiB ≤ 330MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 62.20 ≤ 200 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 281.90MiB ≤ 310MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 24.06 ≤ 100 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 284.06MiB ≤ 320MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment Variant Replicates Failure Logs Debug Dashboard
experiment_with_failures baseline 0 (x8) 1 (x6) Oom killed Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment Variant Replicates Failure Debug Dashboard
quality_gate_idle baseline 10 Oom killed Debug Dashboard
quality_gate_idle comparison 10 Oom killed Debug Dashboard
quality_gate_idle_all_features baseline 10 Oom killed Debug Dashboard
quality_gate_idle_all_features comparison 10 Oom killed Debug Dashboard
quality_gate_logs baseline 10 Oom killed Debug Dashboard
quality_gate_logs comparison 10 Oom killed Debug Dashboard
quality_gate_metrics_logs baseline 10 Oom killed Debug Dashboard
quality_gate_metrics_logs comparison 10 Oom killed Debug Dashboard
quality_gate_security_idle baseline 10 Crashed (exit code: 134) Debug Dashboard
quality_gate_security_idle comparison 10 Crashed (exit code: 134) Debug Dashboard
quality_gate_security_mean_fs_load baseline 10 Crashed (exit code: 134) Debug Dashboard
quality_gate_security_mean_fs_load comparison 10 Crashed (exit code: 134) Debug Dashboard
quality_gate_security_no_fs_load baseline 10 Oom killed Debug Dashboard
quality_gate_security_no_fs_load comparison 10 Oom killed Debug Dashboard

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.

pgimalac added 4 commits July 16, 2026 14:16
AIX, like macOS, does not support any system-probe modules, so no
connection to system-probe should be attempted in the flare profile
tests. Extend the existing darwin GOOS guards and share the no-op
InjectConnectionFailures helper (renamed command_darwin_test.go ->
command_nosysprobe_test.go, //go:build darwin || aix).
@github-actions github-actions Bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Jul 16, 2026
The devicecheck test enables ping, so NewDeviceCheck builds a real pinger
via pinger.New before the mock pinger is injected. pinger_aix.go does not
support ping (AIX has no unprivileged ICMP datagram sockets), so
NewDeviceCheck errors out and the test panics dereferencing the nil check.
Skip it on AIX.
@pgimalac pgimalac changed the title test: skip AIX-unsupported tests (agent-profiling, installer os/user) test: skip AIX-unsupported tests Jul 16, 2026
@pgimalac
pgimalac marked this pull request as ready for review July 16, 2026 15:45
@pgimalac
pgimalac requested review from a team as code owners July 16, 2026 15:45
@pgimalac
pgimalac requested review from Enzu83, FlorianVeaux and hush-hush and removed request for a team July 16, 2026 15:45
@github-actions github-actions Bot deleted a comment from chatgpt-codex-connector Bot Jul 16, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9f300cd9a3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

TestDeviceCheck_WithFailingPing enables ping too, so it hits the same
pinger.New failure on AIX as TestDeviceCheck_WithPing. Factor the guard
into skipIfPingUnsupported and apply it to both.
@pgimalac

Copy link
Copy Markdown
Member Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 17, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-17 15:59:30 UTC ℹ️ Start processing command /merge


2026-07-17 15:59:34 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 2h (p90).


2026-07-17 16:43:23 UTCMergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for 8450567:

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.
Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants