Skip to content

Add Network Path Dynamic Test filters via Remote Config#53716

Draft
AlexandreYang wants to merge 30 commits into
mainfrom
alex/netpath-rc-dynamic
Draft

Add Network Path Dynamic Test filters via Remote Config#53716
AlexandreYang wants to merge 30 commits into
mainfrom
alex/netpath-rc-dynamic

Conversation

@AlexandreYang

@AlexandreYang AlexandreYang commented Jul 16, 2026

Copy link
Copy Markdown
Member

What does this PR do?

Adds Agent support for Network Path Dynamic Test filters delivered through the existing NETWORK_PATH Remote Config product.

  • Applies filters in built-in, local, then RC order so the last matching rule wins.
  • Rejects a malformed dynamic document atomically and preserves the previous valid config for that RC path.
  • Falls back to built-in and local filters when multiple dynamic configs match an Agent.
  • Applies updates atomically in both the core Agent (NetFlow paths) and Process Agent (connection paths).
  • Attributes a Dynamic Test payload with the responsible test_config_id and test_config_source: remote only when an RC include rule is the final winning rule; attribution is captured when the path is admitted.
  • Keeps scheduled and dynamic apply-status ownership separate.
  • Acknowledges valid RC policy while Dynamic Tests are disabled without enabling collection.
  • Adds a dedicated release note.

Motivation

Network Path Dynamic Tests need to be configurable from the Network Path UI without Agent restarts. This implements the Agent-side behavior defined by the Network Path RC RFC and API/storage contract.

Describe how you validated your changes

  • dda inv test --targets=./comp/networkpath/npcollector/impl,./comp/core/autodiscovery/providers/networkpath — 171 tests passed.
  • Targeted dda inv linter.go runs for the implementation, Agent/Process Agent wiring, and E2E packages — 0 issues.
  • Agent and Process Agent command packages compiled through to the local rtloader link step; linking is unavailable without the generated rtloader artifact.
  • E2E package compile-only check passed.
  • Updated the host-traffic Dynamic Test E2E so local config excludes all destinations and only an RC-delivered include permits the expected fakeintake Network Path event. This exercises RC delivery, Process Agent application, filter precedence, and payload production in CI.

Datadog configuration for manual testing

Add the following to datadog.yaml, then restart the Agent and Process Agent:

remote_configuration:
  enabled: true

network_path:
  remote_config:
    enabled: true
  connections_monitoring:
    enabled: true

remote_configuration.enabled is already true by default except on GovCloud, but it is shown explicitly here for clarity. network_path.remote_config.enabled opts Network Path into Remote Configuration; it does not enable a Dynamic Test monitoring source by itself. To test NetFlow paths instead of host connection paths, enable network_path.netflow_monitoring.enabled: true (and configure NetFlow collection) in place of connections_monitoring. After the Agent reconnects, create or update a Network Path Dynamic Test in the UI and verify that matching traffic produces Network Path events.

Additional Notes

This PR is stacked on #53699, which introduces test_config_source. This PR broadens that field to represent configuration provenance independently of test_run_type: remote covers both scheduled RC tests and Dynamic Test paths admitted by a winning RC filter.

The infrastructure E2E scenario was not provisioned locally; it is intended to run in CI.

@github-actions

Copy link
Copy Markdown
Contributor

@codex review

@dd-octo-sts dd-octo-sts Bot added the internal Identify a non-fork PR label Jul 16, 2026
@github-actions github-actions Bot added the short review PR is simple enough to be reviewed quickly label Jul 16, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: e17a40de77

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@dd-octo-sts

dd-octo-sts Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor 86915561:

Results for datadog-agent_7.83.0~devel.git.216.671fd39.pipeline.125229768-1_amd64.deb:

No change detected

@github-actions github-actions Bot added long review PR is complex, plan time to review it and removed short review PR is simple enough to be reviewed quickly labels Jul 16, 2026
@AlexandreYang AlexandreYang changed the title alex/netpath-rc-dynamic Add Network Path Dynamic Test filters via Remote Config Jul 16, 2026
@datadog-official

datadog-official Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 81.12%
Overall Coverage: 52.02% (+0.14%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 671fd39 | Docs | Datadog PR Page | Give us feedback!

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Jul 16, 2026

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 38cb1067-33f6-4fdd-9f21-3be96a53fdfb

Baseline: 8691556
Comparison: 671fd39
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_idle_all_features memory utilization +0.67 [+0.59, +0.74] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization +0.59 [-0.39, +1.57] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.48 [+0.42, +0.53] 1 Logs bounds checks dashboard
quality_gate_security_mean_fs_load memory utilization +0.30 [+0.26, +0.34] 1 Logs bounds checks dashboard
quality_gate_security_no_fs_load memory utilization +0.26 [+0.17, +0.35] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization +0.05 [-0.20, +0.31] 1 Logs bounds checks dashboard
quality_gate_security_idle memory utilization +0.02 [-0.04, +0.08] 1 Logs bounds checks dashboard

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gate_idle intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 147.51MiB ≤ 154MiB bounds checks dashboard
quality_gate_idle total_bytes_received 10/10 726.02KiB ≤ 819.20KiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 9/10 503.91MiB > 495MiB bounds checks dashboard
quality_gate_idle_all_features total_bytes_received 10/10 1.12MiB ≤ 1.25MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 183.22MiB ≤ 195MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs total_bytes_received 10/10 263.83MiB ≤ 292MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 364.26 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 3 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 395.01MiB ≤ 430MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs total_bytes_received 10/10 0.93GiB ≤ 1.04GiB bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 34.87 ≤ 100 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 300.97MiB ≤ 330MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 62.64 ≤ 200 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 280.22MiB ≤ 310MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 23.17 ≤ 100 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 285.82MiB ≤ 320MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment Variant Replicates Failure Logs Debug Dashboard
experiment_with_failures baseline 0 (x8) 1 (x6) Oom killed Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment Variant Replicates Failure Debug Dashboard
quality_gate_idle_all_features comparison 10 Oom killed Debug Dashboard
quality_gate_logs comparison 10 Oom killed Debug Dashboard
quality_gate_metrics_logs baseline 10 Oom killed Debug Dashboard
quality_gate_metrics_logs comparison 10 Oom killed Debug Dashboard
quality_gate_security_idle baseline 10 Crashed (exit code: 134) Debug Dashboard
quality_gate_security_no_fs_load baseline 10 Crashed (exit code: 134) Debug Dashboard
quality_gate_security_no_fs_load comparison 10 Crashed (exit code: 134) Debug Dashboard

CI Pass/Fail Decision

Failed. Some Quality Gates were violated.

  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 9/10 replicas passed. Failed 1 which is > 0. Gate FAILED.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.

Comment thread cmd/agent/subcommands/run/command.go
@AlexandreYang AlexandreYang added the qa/done QA done before merge and regressions are covered by tests label Jul 16, 2026
@AlexandreYang

Copy link
Copy Markdown
Member Author

@codex review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Agent + Process Agent support for receiving Network Path Dynamic Test filters via the existing NETWORK_PATH Remote Config product, so filters can be updated without restarts while preserving precedence/atomicity guarantees.

Changes:

  • Introduces a dynamic RC snapshot parser + filter-layer application in the Network Path collector, with validation and atomic replacement.
  • Wires NETWORK_PATH RC subscription into the core Agent and Process Agent, and updates the scheduled-test RC provider to ignore dynamic configs.
  • Updates E2E coverage + fixtures to validate that local exclude rules can be overridden by RC-delivered include rules.

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/new-e2e/tests/netpath/dynamic-tests/host_traffic_dynamic_path_test.go Extends E2E to inject dynamic RC filters and assert both local + RC destinations produce events.
test/new-e2e/tests/netpath/dynamic-tests/fixtures/host_traffic_dns.py Updates DNS fixture to serve multiple comma-separated domains for the E2E scenario.
test/new-e2e/tests/netpath/dynamic-tests/config/host_traffic_dynamic_path.yaml Enables network_path.remote_config.enabled in the E2E agent config.
releasenotes/notes/network-path-dynamic-remote-config-8c6b3d34e51f0a27.yaml Release note documenting dynamic filter delivery via Remote Config.
pkg/config/schema/yaml/core_schema.yaml Documents the network_path.remote_config.enabled setting in the config schema.
comp/networkpath/npcollector/impl/remote_config.go Implements parsing/validation + atomic application of dynamic filter snapshots from RC.
comp/networkpath/npcollector/impl/remote_config_test.go Unit tests for dynamic RC lifecycle, conflict behavior, and validation.
comp/networkpath/npcollector/impl/npcollectorcomp.go Exposes the collector as an RC handler via Provides.RCHandler.
comp/networkpath/npcollector/impl/npcollector.go Adds locking for filter reads to support atomic filter replacement from RC.
comp/networkpath/npcollector/impl/npcollector_mock.go Updates mock to satisfy the new RemoteConfigHandler interface.
comp/networkpath/npcollector/impl/connfilter/connfiltertype.go Adds JSON tags so filter configs can be unmarshaled from RC payloads.
comp/networkpath/npcollector/impl/BUILD.bazel Adds new remote-config sources/tests and dependencies to Bazel targets.
comp/networkpath/npcollector/def/component.go Introduces RemoteConfigHandler interface for dynamic filter snapshots.
comp/networkpath/npcollector/def/BUILD.bazel Adds remoteconfig/state dep for the new interface.
comp/core/autodiscovery/providers/networkpath/provider.go Ensures scheduled provider ignores dynamic configs (so dynamic handler owns them).
comp/core/autodiscovery/providers/networkpath/provider_test.go Adjusts tests to validate dynamic configs are ignored (not errored) by scheduled provider.
cmd/process-agent/command/main_common.go Subscribes the process-agent to NETWORK_PATH RC updates for dynamic filters.
cmd/agent/subcommands/run/command.go Subscribes core agent to NETWORK_PATH RC and dispatches to both scheduled provider + dynamic handler.
cmd/agent/subcommands/run/command_windows.go Wires RemoteConfigHandler dependency through Windows agent startup.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread comp/core/autodiscovery/providers/networkpath/provider.go
@dd-octo-sts

dd-octo-sts Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 9dd000a
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64 +28.0 KiB (0.00% increase, -0.38% of buffer) 750.987 → 751.014 → 758.200
agent_deb_amd64_fips +32.0 KiB (0.00% increase, -0.79% of buffer) 705.884 → 705.915 → 709.840
agent_heroku_amd64 +16.0 KiB (0.01% increase, -0.21% of buffer) 307.705 → 307.720 → 315.230
agent_msi +28.5 KiB (0.00% increase, -0.25% of buffer) 645.659 → 645.687 → 656.640
agent_rpm_amd64 +28.0 KiB (0.00% increase, -0.38% of buffer) 750.971 → 750.998 → 758.170
agent_rpm_amd64_fips +32.0 KiB (0.00% increase, -0.79% of buffer) 705.868 → 705.899 → 709.840
agent_rpm_arm64 +28.0 KiB (0.00% increase, -0.76% of buffer) 726.055 → 726.082 → 729.660
agent_rpm_arm64_fips +24.0 KiB (0.00% increase, -0.55% of buffer) 684.633 → 684.656 → 688.860
agent_suse_amd64 +28.0 KiB (0.00% increase, -0.38% of buffer) 750.971 → 750.998 → 758.170
agent_suse_amd64_fips +32.0 KiB (0.00% increase, -0.79% of buffer) 705.868 → 705.899 → 709.840
agent_suse_arm64 +28.0 KiB (0.00% increase, -0.76% of buffer) 726.055 → 726.082 → 729.660
agent_suse_arm64_fips +24.0 KiB (0.00% increase, -0.55% of buffer) 684.633 → 684.656 → 688.860
docker_agent_amd64 +28.0 KiB (0.00% increase, -0.67% of buffer) 809.694 → 809.721 → 813.790
docker_agent_arm64 +28.0 KiB (0.00% increase, -0.52% of buffer) 809.782 → 809.810 → 815.030
docker_agent_jmx_amd64 +28.0 KiB (0.00% increase, -0.69% of buffer) 1000.591 → 1000.619 → 1004.550
docker_agent_jmx_arm64 +28.0 KiB (0.00% increase, -0.51% of buffer) 989.332 → 989.360 → 994.710
iot_agent_deb_amd64 +12.0 KiB (0.03% increase, -6.31% of buffer) 46.194 → 46.206 → 46.380
iot_agent_deb_arm64 +12.0 KiB (0.03% increase, -1.40% of buffer) 42.882 → 42.894 → 43.720
iot_agent_deb_armhf +12.0 KiB (0.03% increase, -3.74% of buffer) 43.647 → 43.658 → 43.960
iot_agent_rpm_amd64 +12.0 KiB (0.03% increase, -6.33% of buffer) 46.195 → 46.207 → 46.380
iot_agent_suse_amd64 +12.0 KiB (0.03% increase, -6.29% of buffer) 46.194 → 46.206 → 46.380
12 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
docker_cluster_agent_amd64 209.881 MiB
docker_cluster_agent_arm64 222.952 MiB
docker_cws_instrumentation_amd64 7.447 MiB
docker_cws_instrumentation_arm64 6.877 MiB
docker_dogstatsd_amd64 39.216 MiB
docker_dogstatsd_arm64 37.367 MiB
docker_host_profiler_amd64 303.100 MiB
docker_host_profiler_arm64 314.592 MiB
dogstatsd_deb_amd64 29.951 MiB
dogstatsd_deb_arm64 27.994 MiB
dogstatsd_rpm_amd64 29.951 MiB
dogstatsd_suse_amd64 29.951 MiB

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fb725f7ecc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread comp/core/autodiscovery/providers/networkpath/provider.go

@AlexandreYang AlexandreYang left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review summary

The implementation is cohesive and the shared filter-update path has strong lifecycle coverage, but I found two issues that should be fixed before merge.

Area Coverage
Valid RC dynamic filter application and local/RC precedence Covered by unit tests
Invalid replacement retains last valid config Covered by unit tests
Config deletion and fallback Covered by unit tests
Multiple-config conflict and recovery Covered by unit tests
Scheduled config ignored by dynamic handler Covered by unit tests
Process Agent connection-monitoring RC flow Covered by E2E
Core Agent NetFlow RC filter flow Partial: shared handler is tested, but the Core Agent wiring is not exercised with an RC dynamic filter
Malformed JSON, nil payload, and maximum-filter validation boundaries Partial

Overall: needs fixes. CI for the current head is still running.

Comment thread cmd/process-agent/command/main_common.go Outdated
Comment thread pkg/config/schema/yaml/core_schema.yaml Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 25 out of 25 changed files in this pull request and generated 4 comments.

Comment thread comp/networkpath/npcollector/impl/npcollector.go
Comment thread comp/core/autodiscovery/providers/networkpath/provider.go
Comment thread comp/networkpath/npcollector/impl/pathteststore/pathteststore_test.go Outdated
@AlexandreYang

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0fc1951359

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread comp/core/autodiscovery/providers/networkpath/provider.go
@AlexandreYang

Copy link
Copy Markdown
Member Author

@codex review

@AlexandreYang
AlexandreYang requested a review from Copilot July 17, 2026 08:36
Base automatically changed from alex/netpath-config-source to main July 17, 2026 08:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 31 out of 31 changed files in this pull request and generated 1 comment.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0c8caaa174

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread cmd/process-agent/command/main_common.go Outdated
@AlexandreYang

Copy link
Copy Markdown
Member Author

@codex review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 26 out of 26 changed files in this pull request and generated no new comments.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ebcb2124e8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


for path := range s.remoteConfigState {
if _, found := seenDynamicPaths[path]; !found {
delete(s.remoteConfigState, path)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Evict paths when deleting RC filters

When the RC snapshot no longer contains a dynamic config path, this removes only the filter state; any pathtest that was already admitted by that RC rule remains in pathtestStore with its TestConfigID/TestConfigSource and will keep flushing until network_path.collector.pathtest_ttl expires (70m by default). In a delete or disable rollout, the Agent can therefore continue sending Dynamic Test payloads for a remote test that has been removed; please clear stored contexts attributed to the deleted RC config when dropping its filters.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Identify a non-fork PR long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/agent-build team/agent-configuration team/agent-runtimes team/container-experiences team/container-platform The Container Platform Team team/network-path team/windows-products

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants