Skip to content

Commit 4c5c973

Browse files
walidcaveliusclaude
walidcavelius
and
claude
committed
fix(generator): empty additionalProperties treated as falsy, breaking nullable map example generation (AAWF-1198) (#3952)
* fix(formatter): handle empty additionalProperties as map[string]interface{} When `additionalProperties: {}` is set on a schema, Python's truthiness evaluates the empty dict as falsy, causing the additionalProperties block to be skipped. The generator then fell through to the nullable path and emitted `*NewNullableXxx(&Xxx{})` — a constructor that is never generated for map schemas — resulting in a Go compile error. Fix the condition to check for the presence of the key and an explicit `false` value rather than relying on truthiness. When additionalProperties is an empty dict or boolean `true`, normalize to `interface{}` as the nested value type and format values inline. Also remove the now-unreachable dead-code branch that previously handled `type: object + additionalProperties: {}` after the nullable check. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * pre-commit fixes * fix(formatter): properly escape values in untyped additionalProperties When formatting values for untyped additionalProperties (e.g. additionalProperties: {}), infer the schema from the Python value type so that string escaping, boolean and number formatting are handled correctly. Previously, the fallback `f'"{v}"'` would embed raw newlines in Go string literals, causing compile errors for values like multi-line strings. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * pre-commit fixes * fix(formatter): use map type for named map schemas in array items When array items are a $ref to a schema with additionalProperties (and no properties), schema_name() returned the ref name (e.g. IDPConfigValueItem) which was used as the Go type — but no struct is ever generated for map schemas, causing a compile error. Apply the same additionalProperties != False guard used elsewhere so that named map schemas resolve to map[string]T instead of the struct name, consistent with how type_to_go() handles them. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: ci.datadog-api-spec <packages@datadoghq.com> 064ea68
0 parents  commit 4c5c973

6,217 files changed

Lines changed: 3283914 additions & 0 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.nojekyll‎

Whitespace-only changes.

‎404.html‎

Lines changed: 70 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,70 @@
1+
<!DOCTYPE html>
2+
<html>
3+
<head>
4+
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
5+
<meta name="viewport" content="width=device-width, initial-scale=1">
6+
<meta name="theme-color" content="#375EAB">
7+
8+
<title>Page not found - Datadog</title>
9+
10+
<link type="text/css" rel="stylesheet" href="/datadog-api-client-go/lib/godoc/style.css">
11+
12+
<script>window.initFuncs = [];</script>
13+
<script src="/datadog-api-client-go/lib/godoc/jquery.js" defer></script>
14+
15+
16+
17+
18+
<script>var goVersion = "go1.25.9";</script>
19+
<script src="/datadog-api-client-go/lib/godoc/godocs.js" defer></script>
20+
21+
</head>
22+
<body>
23+
24+
<div id='lowframe' style="position: fixed; bottom: 0; left: 0; height: 0; width: 100%; border-top: thin solid grey; background-color: white; overflow: auto;">
25+
...
26+
</div><!-- #lowframe -->
27+
28+
<div id="topbar" class="wide"><div class="container">
29+
<div class="top-heading" id="heading-wide"><a href="/datadog-api-client-go/pkg/github.com/DataDog/datadog-api-client-go/v2/">Datadog | Datadog API client for GO</a></div>
30+
<div class="top-heading" id="heading-narrow"><a href="/datadog-api-client-go/pkg/github.com/DataDog/datadog-api-client-go/v2/">Datadog</a></div>
31+
<a href="#" id="menu-button"><span id="menu-button-arrow">&#9661;</span></a>
32+
33+
</div></div>
34+
35+
36+
37+
<div id="page" class="wide">
38+
<div class="container">
39+
40+
41+
<h1>
42+
Page not found
43+
<span class="text-muted"></span>
44+
</h1>
45+
46+
47+
48+
49+
50+
51+
52+
<div id="nav"></div>
53+
54+
55+
<p>
56+
<span class="alert" style="font-size:120%">
57+
Oops, this page doesn't exist.
58+
</span>
59+
</p>
60+
<p>If something should be here, <a href="https://github.com/JohnStarich/go/issues/new" target="_blank">open an issue</a>.</p>
61+
62+
63+
<div id="footer">
64+
Build version go1.25.9.<br>
65+
</div>
66+
67+
</div><!-- .container -->
68+
</div><!-- #page -->
69+
</body>
70+
</html>

‎index.html‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
<!DOCTYPE html>
2+
<html>
3+
<head>
4+
<script>
5+
window.location = "pkg/github.com/DataDog/datadog-api-client-go/v2/"
6+
</script>
7+
</head>
8+
<body>
9+
<a href="pkg/github.com/DataDog/datadog-api-client-go/v2/">Click here to see this module's documentation.</a>
10+
</body>
11+
</html>

‎lib/godoc/analysis/call-eg.png‎

11.1 KB
Loading

‎lib/godoc/analysis/call3.png‎

16.6 KB
Loading

‎lib/godoc/analysis/callers1.png‎

12.8 KB
Loading

‎lib/godoc/analysis/callers2.png‎

20.3 KB
Loading

‎lib/godoc/analysis/chan1.png‎

43.2 KB
Loading

‎lib/godoc/analysis/chan2a.png‎

19.1 KB
Loading

‎lib/godoc/analysis/chan2b.png‎

17.8 KB
Loading

0 commit comments

Comments
 (0)