Add slo_query to SLO Correction API for global correction support (#4207)

* Wrap SloId with PtrString in SLO lifecycle tests

slo_id is now optional in SLOCorrectionCreateRequestAttributes (a correction
can target slo_query instead of slo_id), so the generated SloId field is now
*string. Update the hand-written SLO lifecycle test accordingly.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Regenerate client from commit 948302c of spec repo

---------

Co-authored-by: Blaise von Ohlen <blaise.vonohlen@datadoghq.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: ci.datadog-api-spec <packages@datadoghq.com>

Author: 4 people

.generator/schemas/v1/openapi.yaml

@@ -13177,13 +13177,16 @@ components:
       type: object
     SLOCorrectionCreateRequest:
       description: |-
-        An object that defines a correction to be applied to an SLO.
+        An object that defines a correction to be applied to one or more SLOs.
       properties:
         data:
           $ref: "#/components/schemas/SLOCorrectionCreateData"
       type: object
     SLOCorrectionCreateRequestAttributes:
-      description: The attribute object associated with the SLO correction to be created.
+      description: |-
+        The attribute object associated with the SLO correction to be created.
+
+        Exactly one of `slo_id` or `slo_query` must be provided.
       properties:
         category:
           $ref: "#/components/schemas/SLOCorrectionCategory"
@@ -13207,9 +13210,16 @@ components:
           example: FREQ=DAILY;INTERVAL=10;COUNT=5
           type: string
         slo_id:
-          description: ID of the SLO that this correction applies to.
+          description: ID of the single SLO that this correction applies to.
           example: sloId
           type: string
+        slo_query:
+          description: |-
+            Query that matches the SLOs this correction applies to.
+            The query uses the [Events search syntax](https://docs.datadoghq.com/events/explorer/searching/)
+            and can filter SLOs by SLO tags.
+          example: "env:prod service:checkout"
+          type: string
         start:
           description: Starting time of the correction in epoch seconds.
           example: 1600000000
@@ -13220,7 +13230,6 @@ components:
           example: UTC
           type: string
       required:
-        - slo_id
         - start
         - category
       type: object
@@ -13284,7 +13293,12 @@ components:
           nullable: true
           type: string
         slo_id:
-          description: ID of the SLO that this correction applies to.
+          description: ID of the single SLO that this correction applies to.
+          nullable: true
+          type: string
+        slo_query:
+          description: Query that matches the SLOs this correction applies to.
+          nullable: true
           type: string
         start:
           description: Starting time of the correction in epoch seconds.
@@ -13356,6 +13370,13 @@ components:
             are `FREQ`, `INTERVAL`, `COUNT`, `UNTIL` and `BYDAY`.
           example: FREQ=DAILY;INTERVAL=10;COUNT=5
           type: string
+        slo_query:
+          description: |-
+            Query that matches the SLOs this correction applies to.
+            The query uses the [Events search syntax](https://docs.datadoghq.com/events/explorer/searching/)
+            and can filter SLOs by SLO tags.
+          example: "env:prod service:checkout"
+          type: string
         start:
           description: Starting time of the correction in epoch seconds.
           example: 1600000000
@@ -37493,7 +37514,8 @@ paths:
           - slos_read
     post:
       description: |-
-        Create an SLO Correction.
+        Create an SLO correction. Use `slo_id` to apply the correction to a single SLO, or `slo_query` to apply the
+        correction to SLOs that match a query. Exactly one of `slo_id` or `slo_query` is required.
       operationId: CreateSLOCorrection
       requestBody:
         content:
@@ -37510,6 +37532,17 @@ paths:
                       start: 1600000000
                       timezone: UTC
                     type: correction
+              slo_query:
+                value:
+                  data:
+                    attributes:
+                      category: "Scheduled Maintenance"
+                      description: "Planned maintenance window for checkout services."
+                      end: 1600003600
+                      slo_query: "env:prod service:checkout"
+                      start: 1600000000
+                      timezone: UTC
+                    type: correction
             schema:
               $ref: "#/components/schemas/SLOCorrectionCreateRequest"
         description: Create an SLO Correction
@@ -37669,6 +37702,17 @@ paths:
                       start: 1600000000
                       timezone: UTC
                     type: correction
+              slo_query:
+                value:
+                  data:
+                    attributes:
+                      category: "Scheduled Maintenance"
+                      description: "Updated correction for checkout services."
+                      end: 1600003600
+                      slo_query: "env:prod service:checkout"
+                      start: 1600000000
+                      timezone: UTC
+                    type: correction
             schema:
               $ref: "#/components/schemas/SLOCorrectionUpdateRequest"
         description: The edited SLO correction object.

api/datadogV1/api_service_level_objective_corrections.go

@@ -16,7 +16,8 @@ import (
 type ServiceLevelObjectiveCorrectionsApi datadog.Service
 
 // CreateSLOCorrection Create an SLO correction.
-// Create an SLO Correction.
+// Create an SLO correction. Use `slo_id` to apply the correction to a single SLO, or `slo_query` to apply the
+// correction to SLOs that match a query. Exactly one of `slo_id` or `slo_query` is required.
 func (a *ServiceLevelObjectiveCorrectionsApi) CreateSLOCorrection(ctx _context.Context, body SLOCorrectionCreateRequest) (SLOCorrectionResponse, *_nethttp.Response, error) {
 	var (
 		localVarHTTPMethod  = _nethttp.MethodPost

api/datadogV1/model_slo_correction_create_data.go

@@ -13,6 +13,8 @@ import (
 // SLOCorrectionCreateData The data object associated with the SLO correction to be created.
 type SLOCorrectionCreateData struct {
 	// The attribute object associated with the SLO correction to be created.
+	//
+	// Exactly one of `slo_id` or `slo_query` must be provided.
 	Attributes *SLOCorrectionCreateRequestAttributes `json:"attributes,omitempty"`
 	// SLO correction resource type.
 	Type SLOCorrectionType `json:"type"`

api/datadogV1/model_slo_correction_create_request.go

@@ -8,7 +8,7 @@ import (
 	"github.com/DataDog/datadog-api-client-go/v2/api/datadog"
 )
 
-// SLOCorrectionCreateRequest An object that defines a correction to be applied to an SLO.
+// SLOCorrectionCreateRequest An object that defines a correction to be applied to one or more SLOs.
 type SLOCorrectionCreateRequest struct {
 	// The data object associated with the SLO correction to be created.
 	Data *SLOCorrectionCreateData `json:"data,omitempty"`

api/datadogV1/model_slo_correction_create_request_attributes.go

@@ -11,6 +11,8 @@ import (
 )
 
 // SLOCorrectionCreateRequestAttributes The attribute object associated with the SLO correction to be created.
+//
+// Exactly one of `slo_id` or `slo_query` must be provided.
 type SLOCorrectionCreateRequestAttributes struct {
 	// Category the SLO correction belongs to.
 	Category SLOCorrectionCategory `json:"category"`
@@ -23,8 +25,12 @@ type SLOCorrectionCreateRequestAttributes struct {
 	// The recurrence rules as defined in the iCalendar RFC 5545. The supported rules for SLO corrections
 	// are `FREQ`, `INTERVAL`, `COUNT`, `UNTIL` and `BYDAY`.
 	Rrule *string `json:"rrule,omitempty"`
-	// ID of the SLO that this correction applies to.
-	SloId string `json:"slo_id"`
+	// ID of the single SLO that this correction applies to.
+	SloId *string `json:"slo_id,omitempty"`
+	// Query that matches the SLOs this correction applies to.
+	// The query uses the [Events search syntax](https://docs.datadoghq.com/events/explorer/searching/)
+	// and can filter SLOs by SLO tags.
+	SloQuery *string `json:"slo_query,omitempty"`
 	// Starting time of the correction in epoch seconds.
 	Start int64 `json:"start"`
 	// The timezone to display in the UI for the correction times (defaults to "UTC").
@@ -38,10 +44,9 @@ type SLOCorrectionCreateRequestAttributes struct {
 // This constructor will assign default values to properties that have it defined,
 // and makes sure properties required by API are set, but the set of arguments
 // will change when the set of required properties is changed.
-func NewSLOCorrectionCreateRequestAttributes(category SLOCorrectionCategory, sloId string, start int64) *SLOCorrectionCreateRequestAttributes {
+func NewSLOCorrectionCreateRequestAttributes(category SLOCorrectionCategory, start int64) *SLOCorrectionCreateRequestAttributes {
 	this := SLOCorrectionCreateRequestAttributes{}
 	this.Category = category
-	this.SloId = sloId
 	this.Start = start
 	return &this
 }
@@ -189,27 +194,60 @@ func (o *SLOCorrectionCreateRequestAttributes) SetRrule(v string) {
 	o.Rrule = &v
 }
 
-// GetSloId returns the SloId field value.
+// GetSloId returns the SloId field value if set, zero value otherwise.
 func (o *SLOCorrectionCreateRequestAttributes) GetSloId() string {
-	if o == nil {
+	if o == nil || o.SloId == nil {
 		var ret string
 		return ret
 	}
-	return o.SloId
+	return *o.SloId
 }
 
-// GetSloIdOk returns a tuple with the SloId field value
+// GetSloIdOk returns a tuple with the SloId field value if set, nil otherwise
 // and a boolean to check if the value has been set.
 func (o *SLOCorrectionCreateRequestAttributes) GetSloIdOk() (*string, bool) {
-	if o == nil {
+	if o == nil || o.SloId == nil {
 		return nil, false
 	}
-	return &o.SloId, true
+	return o.SloId, true
+}
+
+// HasSloId returns a boolean if a field has been set.
+func (o *SLOCorrectionCreateRequestAttributes) HasSloId() bool {
+	return o != nil && o.SloId != nil
 }
 
-// SetSloId sets field value.
+// SetSloId gets a reference to the given string and assigns it to the SloId field.
 func (o *SLOCorrectionCreateRequestAttributes) SetSloId(v string) {
-	o.SloId = v
+	o.SloId = &v
+}
+
+// GetSloQuery returns the SloQuery field value if set, zero value otherwise.
+func (o *SLOCorrectionCreateRequestAttributes) GetSloQuery() string {
+	if o == nil || o.SloQuery == nil {
+		var ret string
+		return ret
+	}
+	return *o.SloQuery
+}
+
+// GetSloQueryOk returns a tuple with the SloQuery field value if set, nil otherwise
+// and a boolean to check if the value has been set.
+func (o *SLOCorrectionCreateRequestAttributes) GetSloQueryOk() (*string, bool) {
+	if o == nil || o.SloQuery == nil {
+		return nil, false
+	}
+	return o.SloQuery, true
+}
+
+// HasSloQuery returns a boolean if a field has been set.
+func (o *SLOCorrectionCreateRequestAttributes) HasSloQuery() bool {
+	return o != nil && o.SloQuery != nil
+}
+
+// SetSloQuery gets a reference to the given string and assigns it to the SloQuery field.
+func (o *SLOCorrectionCreateRequestAttributes) SetSloQuery(v string) {
+	o.SloQuery = &v
 }
 
 // GetStart returns the Start field value.
@@ -282,7 +320,12 @@ func (o SLOCorrectionCreateRequestAttributes) MarshalJSON() ([]byte, error) {
 	if o.Rrule != nil {
 		toSerialize["rrule"] = o.Rrule
 	}
-	toSerialize["slo_id"] = o.SloId
+	if o.SloId != nil {
+		toSerialize["slo_id"] = o.SloId
+	}
+	if o.SloQuery != nil {
+		toSerialize["slo_query"] = o.SloQuery
+	}
 	toSerialize["start"] = o.Start
 	if o.Timezone != nil {
 		toSerialize["timezone"] = o.Timezone
@@ -302,7 +345,8 @@ func (o *SLOCorrectionCreateRequestAttributes) UnmarshalJSON(bytes []byte) (err
 		Duration    *int64                 `json:"duration,omitempty"`
 		End         *int64                 `json:"end,omitempty"`
 		Rrule       *string                `json:"rrule,omitempty"`
-		SloId       *string                `json:"slo_id"`
+		SloId       *string                `json:"slo_id,omitempty"`
+		SloQuery    *string                `json:"slo_query,omitempty"`
 		Start       *int64                 `json:"start"`
 		Timezone    *string                `json:"timezone,omitempty"`
 	}{}
@@ -312,15 +356,12 @@ func (o *SLOCorrectionCreateRequestAttributes) UnmarshalJSON(bytes []byte) (err
 	if all.Category == nil {
 		return fmt.Errorf("required field category missing")
 	}
-	if all.SloId == nil {
-		return fmt.Errorf("required field slo_id missing")
-	}
 	if all.Start == nil {
 		return fmt.Errorf("required field start missing")
 	}
 	additionalProperties := make(map[string]interface{})
 	if err = datadog.UnmarshalUseNumber(bytes, &additionalProperties); err == nil {
-		datadog.DeleteKeys(additionalProperties, &[]string{"category", "description", "duration", "end", "rrule", "slo_id", "start", "timezone"})
+		datadog.DeleteKeys(additionalProperties, &[]string{"category", "description", "duration", "end", "rrule", "slo_id", "slo_query", "start", "timezone"})
 	} else {
 		return err
 	}
@@ -335,7 +376,8 @@ func (o *SLOCorrectionCreateRequestAttributes) UnmarshalJSON(bytes []byte) (err
 	o.Duration = all.Duration
 	o.End = all.End
 	o.Rrule = all.Rrule
-	o.SloId = *all.SloId
+	o.SloId = all.SloId
+	o.SloQuery = all.SloQuery
 	o.Start = *all.Start
 	o.Timezone = all.Timezone