Skip to content

Add Get Tag Cardinalities Endpoint Spec#3169

Merged
api-clients-generation-pipeline[bot] merged 1 commit into
masterfrom
datadog-api-spec/generated/3992
Jul 18, 2025
Merged

Add Get Tag Cardinalities Endpoint Spec#3169
api-clients-generation-pipeline[bot] merged 1 commit into
masterfrom
datadog-api-spec/generated/3992

Conversation

@api-clients-generation-pipeline
Copy link
Copy Markdown
Contributor

@api-clients-generation-pipeline api-clients-generation-pipeline Bot commented Jun 23, 2025

// but it doesn't guarantee that properties required by API are set.
func NewMetricTagCardinalityWithDefaults() *MetricTagCardinality {
this := MetricTagCardinality{}
var typeVar string = "get-tag-cardinalities"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Code Quality Violation

Suggested change
var typeVar string = "get-tag-cardinalities"
var typeVar = "get-tag-cardinalities"
redundant type declaration (...read more)

In Go, it is considered good practice to avoid declaring the type when it is obvious or when the type can be inferred from the assignment. This is known as type inference, and it offers several benefits:

  1. Readability: By omitting the explicit type declaration, the code becomes more concise and easier to read. Redundant type declarations can clutter the code and introduce unnecessary noise. When the type is obvious from the assigned value, omitting the type declaration can improve code readability and make it more expressive.
  2. Flexibility and maintainability: Using type inference allows for easier changes to the underlying type without manually updating every instance where it is declared. If the type needs to be changed in the future, you only need to modify the assignment, and Go's type inference mechanism will handle the rest. This reduces the maintenance effort required and improves code maintainability.
  3. Clean code appearance: Omitting the type declaration when it is obvious results in cleaner code syntax. Code that is free from excessive explicit type declarations tends to look more elegant and consistent. It minimizes redundancy and focuses on the essential logic, contributing to a cleaner and more streamlined codebase.
  4. Compatibility: Go's type inference mechanism ensures compatibility with future changes to the type of the assigned value. If the assigned value is changed to a type-compatible value, the code will continue to compile and run without any modifications. This allows for flexibility in your code while maintaining correctness.

That being said, it is important to strike a balance and avoid excessive use of type inference. Clear and explicit type declarations are still valuable when they enhance code clarity, such as when documenting or expressing the intent of the code. It is essential to find the right balance between brevity and clarity in your codebase.

By utilizing Go's type inference mechanism and avoiding explicit type declarations when the type is obvious, you can achieve more readable, maintainable, and concise code that adheres to Go's idiomatic style.

View in Datadog  Leave us feedback  Documentation

@api-clients-generation-pipeline api-clients-generation-pipeline Bot changed the title [METEXP-2030] Add Get Tag Cardinalities Endpoint Spec Add Get Tag Cardinalities Endpoint Spec Jul 8, 2025
@api-clients-generation-pipeline api-clients-generation-pipeline Bot added the changelog/Added Added features results into a minor version bump label Jul 8, 2025
@api-clients-generation-pipeline api-clients-generation-pipeline Bot force-pushed the datadog-api-spec/generated/3992 branch from bd406c1 to 13527dd Compare July 8, 2025 18:42
@api-clients-generation-pipeline api-clients-generation-pipeline Bot force-pushed the datadog-api-spec/generated/3992 branch from 13527dd to 3710fae Compare July 18, 2025 14:00
@api-clients-generation-pipeline api-clients-generation-pipeline Bot merged commit 5da39b3 into master Jul 18, 2025
12 checks passed
@api-clients-generation-pipeline api-clients-generation-pipeline Bot deleted the datadog-api-spec/generated/3992 branch July 18, 2025 14:56
github-actions Bot pushed a commit that referenced this pull request Jul 18, 2025
Co-authored-by: ci.datadog-api-spec <packages@datadoghq.com> 5da39b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/Added Added features results into a minor version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant