Fix nullable UUID type mismatch in Go code generator#4172
Merged
Conversation
Nullable UUID fields (format: uuid, nullable: true) were being mapped to NullableString, causing getter/setter methods to return *string while the method signatures expected uuid.UUID — a compile error. Add a dedicated NullableUUID type to utils.j2 and update formatter.py to use it for nullable uuid fields instead of NullableString. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
MintsInc
approved these changes
Jun 1, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 1, 2026
* Fix nullable UUID type mismatch in Go code generator Nullable UUID fields (format: uuid, nullable: true) were being mapped to NullableString, causing getter/setter methods to return *string while the method signatures expected uuid.UUID — a compile error. Add a dedicated NullableUUID type to utils.j2 and update formatter.py to use it for nullable uuid fields instead of NullableString. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * pre-commit fixes --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: ci.datadog-api-spec <packages@datadoghq.com> 7670114
github-actions Bot
pushed a commit
to ConnectionMaster/datadog-api-client-go
that referenced
this pull request
Jun 1, 2026
* Fix nullable UUID type mismatch in Go code generator Nullable UUID fields (format: uuid, nullable: true) were being mapped to NullableString, causing getter/setter methods to return *string while the method signatures expected uuid.UUID — a compile error. Add a dedicated NullableUUID type to utils.j2 and update formatter.py to use it for nullable uuid fields instead of NullableString. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * pre-commit fixes --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: ci.datadog-api-spec <packages@datadoghq.com> 7670114
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
format: uuid+nullable: true) were being mapped toNullableStringinformatter.py, causing generated getter/setter methods to return*stringwhile the method signatures expecteduuid.UUID— resulting in compile errors.NullableUUIDstruct toutils.j2(matching the pattern ofNullableBool,NullableString,NullableTime, etc.).formatter.pyline 158 to emitNullableUUID/NewNullableUUIDfor nullable uuid fields instead ofNullableString.Example compile errors this fixes (from
datadog-api-specPR #5821 CI run):Test plan
NullableUUIDmarshal/unmarshal round-trips correctly (JSON UUID strings ↔uuid.UUID).🤖 Generated with Claude Code