Skip to content

[OnCall] replacing connection name with unique name #2774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
api-clients-generation-pipeline merged 1 commit into from
Apr 4, 2025
Merged

[OnCall] replacing connection name with unique name #2774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .apigentools-info
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
"spec_versions": {
"v1": {
"apigentools_version": "1.6.6",
"regenerated": "2025-04-04 12:49:29.243722",
"spec_repo_commit": "73e22797"
"regenerated": "2025-04-04 16:55:47.238517",
"spec_repo_commit": "da94868e"
},
"v2": {
"apigentools_version": "1.6.6",
"regenerated": "2025-04-04 12:49:29.261107",
"spec_repo_commit": "73e22797"
"regenerated": "2025-04-04 16:55:47.254022",
"spec_repo_commit": "da94868e"
}
}
}
2 changes: 1 addition & 1 deletion examples/v2/action-connection/CreateActionConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public static void main(String[] args) {
.type(ActionConnectionDataType.ACTION_CONNECTION)
.attributes(
new ActionConnectionAttributes()
.name("Cassette Connection DELETE_ME")
.name("Cassette Connection exampleactionconnection")
.integration(
new ActionConnectionIntegration(
new AWSIntegration()
Expand Down
5 changes: 4 additions & 1 deletion examples/v2/action-connection/DeleteActionConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,11 @@ public static void main(String[] args) {
ApiClient defaultClient = ApiClient.getDefaultApiClient();
ActionConnectionApi apiInstance = new ActionConnectionApi(defaultClient);

// there is a valid "action_connection" in the system
String ACTION_CONNECTION_DATA_ID = System.getenv("ACTION_CONNECTION_DATA_ID");

try {
apiInstance.deleteActionConnection("connection_id");
apiInstance.deleteActionConnection(ACTION_CONNECTION_DATA_ID);
} catch (ApiException e) {
System.err.println("Exception when calling ActionConnectionApi#deleteActionConnection");
System.err.println("Status code: " + e.getCode());
Expand Down
25 changes: 0 additions & 25 deletions examples/v2/action-connection/DeleteActionConnection_2142905164.java
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion .../cassettes/features/v2/Create_a_new_Action_Connection_returns_Bad_Request_response.freeze
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2025-01-06T22:02:35.383Z
2025-03-26T20:24:59.622Z
2 changes: 1 addition & 1 deletion ...te_a_new_Action_Connection_returns_Successfully_created_Action_Connection_response.freeze
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2025-01-06T22:02:35.598Z
2025-03-26T20:24:59.727Z
10 changes: 5 additions & 5 deletions ...eate_a_new_Action_Connection_returns_Successfully_created_Action_Connection_response.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"httpRequest": {
"body": {
"type": "JSON",
"json": "{\"data\":{\"attributes\":{\"integration\":{\"credentials\":{\"account_id\":\"123456789123\",\"role\":\"MyRoleUpdated\",\"type\":\"AWSAssumeRole\"},\"type\":\"AWS\"},\"name\":\"Cassette Connection DELETE_ME\"},\"type\":\"action_connection\"}}"
"json": "{\"data\":{\"attributes\":{\"integration\":{\"credentials\":{\"account_id\":\"123456789123\",\"role\":\"MyRoleUpdated\",\"type\":\"AWSAssumeRole\"},\"type\":\"AWS\"},\"name\":\"Cassette Connection testcreateanewactionconnectionreturnssuccessfullycreatedactionconnectionresponse1743020699\"},\"type\":\"action_connection\"}}"
},
"headers": {},
"method": "POST",
Expand All @@ -12,7 +12,7 @@
"secure": true
},
"httpResponse": {
"body": "{\"data\":{\"id\":\"db41b6cb-ef93-45bd-9857-548e9474737c\",\"type\":\"action_connection\",\"attributes\":{\"integration\":{\"credentials\":{\"account_id\":\"123456789123\",\"role\":\"MyRoleUpdated\",\"external_id\":\"c6f62d439f14423b963e4dd4246af4a7\",\"principal_id\":\"464622532012\",\"type\":\"AWSAssumeRole\"},\"type\":\"AWS\"},\"name\":\"Cassette Connection DELETE_ME\"}}}",
"body": "{\"data\":{\"id\":\"67aa2f61-266d-48d1-a1ee-cf7c3acc6b20\",\"type\":\"action_connection\",\"attributes\":{\"integration\":{\"credentials\":{\"account_id\":\"123456789123\",\"external_id\":\"70f4660c99684420821b0c13a67eb4d1\",\"principal_id\":\"464622532012\",\"role\":\"MyRoleUpdated\",\"type\":\"AWSAssumeRole\"},\"type\":\"AWS\"},\"name\":\"Cassette Connection testcreateanewactionconnectionreturnssuccessfullycreatedactionconnectionresponse1743020699\"}}}",
"headers": {
"Content-Type": [
"application/vnd.api+json"
Expand All @@ -27,13 +27,13 @@
"timeToLive": {
"unlimited": true
},
"id": "143d1c35-6301-e638-823f-d266922b4a2b"
"id": "04556392-bb7b-98ed-b374-d36633910050"
},
{
"httpRequest": {
"headers": {},
"method": "DELETE",
"path": "/api/v2/actions/connections/db41b6cb-ef93-45bd-9857-548e9474737c",
"path": "/api/v2/actions/connections/67aa2f61-266d-48d1-a1ee-cf7c3acc6b20",
"keepAlive": false,
"secure": true
},
Expand All @@ -48,6 +48,6 @@
"timeToLive": {
"unlimited": true
},
"id": "bf4a6792-05b2-4047-13ab-b319f5aac56c"
"id": "7561c857-b479-1fb9-a517-18620d730ba3"
}
]
2 changes: 1 addition & 1 deletion ...settes/features/v2/Delete_an_existing_Action_Connection_returns_Not_Found_response.freeze
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2025-01-06T22:02:36.467Z
2025-03-26T20:25:00.311Z
1 change: 1 addition & 0 deletions ..._existing_Action_Connection_returns_The_resource_was_deleted_successfully_response.freeze
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
2025-03-26T20:25:00.458Z
79 changes: 79 additions & 0 deletions ...an_existing_Action_Connection_returns_The_resource_was_deleted_successfully_response.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
[
{
"httpRequest": {
"body": {
"type": "JSON",
"json": "{\"data\":{\"attributes\":{\"integration\":{\"credentials\":{\"account_id\":\"123456789123\",\"role\":\"MyRole\",\"type\":\"AWSAssumeRole\"},\"type\":\"AWS\"},\"name\":\"Cassette Connection testdeleteanexistingactionconnectionreturnstheresourcewasdeletedsuccessfullyresponse1743020700\"},\"type\":\"action_connection\"}}"
},
"headers": {},
"method": "POST",
"path": "/api/v2/actions/connections",
"keepAlive": false,
"secure": true
},
"httpResponse": {
"body": "{\"data\":{\"id\":\"c3c3d83b-c495-4c1b-bb1d-592825d21db0\",\"type\":\"action_connection\",\"attributes\":{\"integration\":{\"credentials\":{\"account_id\":\"123456789123\",\"external_id\":\"6183670d1ceb4278808cf2df9aa03a07\",\"principal_id\":\"464622532012\",\"role\":\"MyRole\",\"type\":\"AWSAssumeRole\"},\"type\":\"AWS\"},\"name\":\"Cassette Connection testdeleteanexistingactionconnectionreturnstheresourcewasdeletedsuccessfullyresponse1743020700\"}}}",
"headers": {
"Content-Type": [
"application/vnd.api+json"
]
},
"statusCode": 201,
"reasonPhrase": "Created"
},
"times": {
"remainingTimes": 1
},
"timeToLive": {
"unlimited": true
},
"id": "d622b652-bd44-a22d-1527-2fe726a42d5a"
},
{
"httpRequest": {
"headers": {},
"method": "DELETE",
"path": "/api/v2/actions/connections/c3c3d83b-c495-4c1b-bb1d-592825d21db0",
"keepAlive": false,
"secure": true
},
"httpResponse": {
"headers": {},
"statusCode": 204,
"reasonPhrase": "No Content"
},
"times": {
"remainingTimes": 1
},
"timeToLive": {
"unlimited": true
},
"id": "67294d8d-49a4-c8c6-e910-111ce63e8aeb"
},
{
"httpRequest": {
"headers": {},
"method": "DELETE",
"path": "/api/v2/actions/connections/c3c3d83b-c495-4c1b-bb1d-592825d21db0",
"keepAlive": false,
"secure": true
},
"httpResponse": {
"body": "{\"errors\":[{\"title\":\"Generic Error\",\"detail\":\"error deleting connection: rpc error: code = NotFound desc = connection not found\"}]}",
"headers": {
"Content-Type": [
"application/vnd.api+json"
]
},
"statusCode": 404,
"reasonPhrase": "Not Found"
},
"times": {
"remainingTimes": 1
},
"timeToLive": {
"unlimited": true
},
"id": "67294d8d-49a4-c8c6-e910-111ce63e8aec"
}
]
2 changes: 1 addition & 1 deletion ...ssettes/features/v2/Get_an_existing_Action_Connection_returns_Bad_Request_response.freeze
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2025-01-06T22:02:37.403Z
2025-03-26T20:25:01.150Z
2 changes: 1 addition & 1 deletion ...cassettes/features/v2/Get_an_existing_Action_Connection_returns_Not_Found_response.freeze
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2025-01-06T22:02:37.563Z
2025-03-26T20:25:01.247Z
2 changes: 1 addition & 1 deletion ..._an_existing_Action_Connection_returns_Successfully_get_Action_Connection_response.freeze
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2025-01-06T22:02:37.743Z
2025-03-26T20:25:01.398Z
2 changes: 1 addition & 1 deletion ...et_an_existing_Action_Connection_returns_Successfully_get_Action_Connection_response.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"secure": true
},
"httpResponse": {
"body": "{\"data\":{\"id\":\"cb460d51-3c88-4e87-adac-d47131d0423d\",\"type\":\"action_connection\",\"attributes\":{\"integration\":{\"credentials\":{\"account_id\":\"123456789123\",\"role\":\"MyRoleUpdated\",\"external_id\":\"909b33b1242748cfbef42f20011e2fa0\",\"principal_id\":\"464622532012\",\"type\":\"AWSAssumeRole\"},\"type\":\"AWS\"},\"name\":\"Cassette Connection\"}}}",
"body": "{\"data\":{\"id\":\"cb460d51-3c88-4e87-adac-d47131d0423d\",\"type\":\"action_connection\",\"attributes\":{\"integration\":{\"credentials\":{\"account_id\":\"123456789123\",\"external_id\":\"909b33b1242748cfbef42f20011e2fa0\",\"principal_id\":\"464622532012\",\"role\":\"MyRoleUpdated\",\"type\":\"AWSAssumeRole\"},\"type\":\"AWS\"},\"name\":\"Cassette Connection\"}}}",
"headers": {
"Content-Type": [
"application/vnd.api+json"
Expand Down
2 changes: 1 addition & 1 deletion ...ttes/features/v2/Update_an_existing_Action_Connection_returns_Bad_Request_response.freeze
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2025-01-06T22:02:38.001Z
2025-03-26T20:25:01.521Z
2 changes: 1 addition & 1 deletion ...settes/features/v2/Update_an_existing_Action_Connection_returns_Not_Found_response.freeze
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2025-01-06T22:02:38.092Z
2025-03-26T20:25:01.625Z
2 changes: 1 addition & 1 deletion ...existing_Action_Connection_returns_Successfully_updated_Action_Connection_response.freeze
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2025-01-06T22:02:38.186Z
2025-03-26T20:25:01.719Z
2 changes: 1 addition & 1 deletion ...n_existing_Action_Connection_returns_Successfully_updated_Action_Connection_response.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"secure": true
},
"httpResponse": {
"body": "{\"data\":{\"id\":\"cb460d51-3c88-4e87-adac-d47131d0423d\",\"type\":\"action_connection\",\"attributes\":{\"integration\":{\"credentials\":{\"account_id\":\"123456789123\",\"role\":\"MyRoleUpdated\",\"external_id\":\"909b33b1242748cfbef42f20011e2fa0\",\"principal_id\":\"464622532012\",\"type\":\"AWSAssumeRole\"},\"type\":\"AWS\"},\"name\":\"Cassette Connection\"}}}",
"body": "{\"data\":{\"id\":\"cb460d51-3c88-4e87-adac-d47131d0423d\",\"type\":\"action_connection\",\"attributes\":{\"integration\":{\"credentials\":{\"account_id\":\"123456789123\",\"external_id\":\"909b33b1242748cfbef42f20011e2fa0\",\"principal_id\":\"464622532012\",\"role\":\"MyRoleUpdated\",\"type\":\"AWSAssumeRole\"},\"type\":\"AWS\"},\"name\":\"Cassette Connection\"}}}",
"headers": {
"Content-Type": [
"application/vnd.api+json"
Expand Down
11 changes: 2 additions & 9 deletions src/test/resources/com/datadog/api/client/v2/api/action_connection.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Feature: Action Connection
@team:DataDog/workflow-automation-dev
Scenario: Create a new Action Connection returns "Successfully created Action Connection" response
Given new "CreateActionConnection" request
And body with value {"data":{"type":"action_connection","attributes":{"name":"Cassette Connection DELETE_ME","integration":{"type":"AWS","credentials":{"type":"AWSAssumeRole","role":"MyRoleUpdated","account_id":"123456789123"}}}}}
And body with value {"data":{"type":"action_connection","attributes":{"name":"Cassette Connection {{ unique_lower_alnum }}","integration":{"type":"AWS","credentials":{"type":"AWSAssumeRole","role":"MyRoleUpdated","account_id":"123456789123"}}}}}
When the request is sent
Then the response status is 201 Successfully created Action Connection

Expand All @@ -36,20 +36,13 @@ Feature: Action Connection
Then the response status is 404 Not Found

@team:DataDog/workflow-automation-dev
Scenario: Delete an existing Action Connection returns "Successfully deleted Action Connection" response
Scenario: Delete an existing Action Connection returns "The resource was deleted successfully." response
Given there is a valid "action_connection" in the system
And new "DeleteActionConnection" request
And request contains "connection_id" parameter from "action_connection.data.id"
When the request is sent
Then the response status is 204 The resource was deleted successfully.

@generated @skip @team:DataDog/workflow-automation-dev
Scenario: Delete an existing Action Connection returns "The resource was deleted successfully." response
Given new "DeleteActionConnection" request
And request contains "connection_id" parameter from "REPLACE.ME"
When the request is sent
Then the response status is 204 The resource was deleted successfully.

@team:DataDog/workflow-automation-dev
Scenario: Get an existing Action Connection returns "Bad Request" response
Given new "GetActionConnection" request
Expand Down
2 changes: 1 addition & 1 deletion src/test/resources/com/datadog/api/client/v2/api/given.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"parameters": [
{
"name": "body",
"value": "{\n \"data\": {\n \"type\": \"action_connection\",\n \"attributes\": {\n \"name\": \"Cassette Connection DELETE\",\n \"integration\": {\n \"type\": \"AWS\",\n \"credentials\": {\n \"type\": \"AWSAssumeRole\",\n \"role\": \"MyRole\",\n \"account_id\": \"123456789123\"\n }\n }\n }\n }\n}"
"value": "{\n \"data\": {\n \"type\": \"action_connection\",\n \"attributes\": {\n \"name\": \"Cassette Connection {{ unique_lower_alnum }}\",\n \"integration\": {\n \"type\": \"AWS\",\n \"credentials\": {\n \"type\": \"AWSAssumeRole\",\n \"role\": \"MyRole\",\n \"account_id\": \"123456789123\"\n }\n }\n }\n }\n}"
}
],
"step": "there is a valid \"action_connection\" in the system",
Expand Down