Skip to content

Remove isReadOnly default when creating dashboards #2839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NaOHman merged 2 commits into from
May 9, 2025
Merged

Remove isReadOnly default when creating dashboards #2839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e015988
Regenerate client from commit 39adb7c0 of spec repo
May 9, 2025
2d82791
update recordings
michaelmcchen May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .apigentools-info
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
"spec_versions": {
"v1": {
"apigentools_version": "1.6.6",
"regenerated": "2025-05-08 14:34:53.877121",
"spec_repo_commit": "4b632dba"
"regenerated": "2025-05-09 02:41:26.674771",
"spec_repo_commit": "39adb7c0"
},
"v2": {
"apigentools_version": "1.6.6",
"regenerated": "2025-05-08 14:34:53.893015",
"spec_repo_commit": "4b632dba"
"regenerated": "2025-05-09 02:41:26.695479",
"spec_repo_commit": "39adb7c0"
}
}
}
1 change: 0 additions & 1 deletion .generator/schemas/v1/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1181,7 +1181,6 @@ components:
readOnly: true
type: string
is_read_only:
default: false
deprecated: true
description: 'Whether this dashboard is read-only. If True, only the author
and admins can make changes to it.
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/datadog/api/client/v1/model/Dashboard.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public class Dashboard {
private String id;

public static final String JSON_PROPERTY_IS_READ_ONLY = "is_read_only";
private Boolean isReadOnly = false;
private Boolean isReadOnly;

public static final String JSON_PROPERTY_LAYOUT_TYPE = "layout_type";
private DashboardLayoutType layoutType;
Expand Down
4 changes: 2 additions & 2 deletions src/test/resources/cassettes/v1/DashboardsApiTest.dashboardCreateErrorsTest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"secure" : true,
"body" : {
"type" : "JSON",
"json" : "{\"is_read_only\":false,\"layout_type\":null,\"title\":null,\"widgets\":[]}"
"json" : "{\"layout_type\":null,\"title\":null,\"widgets\":[]}"
}
},
"times" : {
Expand Down Expand Up @@ -58,7 +58,7 @@
"secure" : true,
"body" : {
"type" : "JSON",
"json" : "{\"is_read_only\":false,\"layout_type\":null,\"title\":null,\"widgets\":[]}"
"json" : "{\"layout_type\":null,\"title\":null,\"widgets\":[]}"
}
},
"times" : {
Expand Down
6 changes: 3 additions & 3 deletions src/test/resources/cassettes/v1/DashboardsApiTest.dashboardLifecycleTest.json
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions src/test/resources/cassettes/v1/DashboardsApiTest.dashboardUpdateErrorsTest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"secure" : true,
"body" : {
"type" : "JSON",
"json" : "{\"is_read_only\":false,\"layout_type\":null,\"title\":null,\"widgets\":[]}"
"json" : "{\"layout_type\":null,\"title\":null,\"widgets\":[]}"
}
},
"times" : {
Expand Down Expand Up @@ -58,7 +58,7 @@
"secure" : true,
"body" : {
"type" : "JSON",
"json" : "{\"is_read_only\":false,\"layout_type\":null,\"title\":null,\"widgets\":[]}"
"json" : "{\"layout_type\":null,\"title\":null,\"widgets\":[]}"
}
},
"times" : {
Expand Down Expand Up @@ -96,7 +96,7 @@
"secure" : true,
"body" : {
"type" : "JSON",
"json" : "{\"description\":\"Test dashboard for Java client\",\"is_read_only\":false,\"layout_type\":\"free\",\"title\":\"java-dashboardUpdateErrorsTest-local-1595946448\",\"widgets\":[]}"
"json" : "{\"description\":\"Test dashboard for Java client\",\"layout_type\":\"free\",\"title\":\"java-dashboardUpdateErrorsTest-local-1595946448\",\"widgets\":[]}"
}
},
"times" : {
Expand Down