Skip to content

Handle additionalProperties objects with no properties #2920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skarimo merged 2 commits into from
Jun 12, 2025
Merged

Handle additionalProperties objects with no properties #2920

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0449674
handle maps
skarimo Jun 12, 2025
fcf8eb3
Merge branch 'master' into sherz/fix-example
skarimo Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .generator/src/generator/formatter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,7 +605,7 @@ def format_data_with_schema_dict(
return _format_oneof(schema, data, name, default_name, replace_values, imports)

# NOTE this is a special case for unnamed objects that should be avoided in the future
if schema.get("type") == "object" and not data:
if schema.get("type") == "object" and not data and "additionalProperties" not in schema:
return "Object", "new Object()", set()

if schema.get("type") == "object" and "properties" not in schema and schema.get("additionalProperties") == {}:
Expand Down