Skip to content

Add equals to reserved keywords and escape method names#3499

Merged
nogates merged 5 commits into
masterfrom
nogates/fix-templates-for-equals-and-class-fields
Feb 18, 2026
Merged

Add equals to reserved keywords and escape method names#3499
nogates merged 5 commits into
masterfrom
nogates/fix-templates-for-equals-and-class-fields

Conversation

@nogates

@nogates nogates commented Feb 13, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Fix code generation for Java model attributes that conflict with reserved keywords and method names.

Changes

  • Added equals to the list of reserved Java keywords
  • Created escape_method_reserved_names() function to handle method name conflicts for getClass and setClass
  • Updated model template to apply method name escaping to JSON property annotations

Additional Notes

Review checklist

Please check relevant items below:

  • This PR includes all newly recorded cassettes for any modified tests.

  • This PR does not rely on API client schema changes.

    • The CI should be fully passing.
  • Or, this PR relies on API schema changes and this is a Draft PR that includes tests.

    • Note: CI shouldn't be run on this Draft PR, as its expected to fail without the corresponding schema changes.

@nogates nogates requested review from a team as code owners February 13, 2026 11:51
@nogates nogates added the changelog/Fixed Fixed features results into a bug fix version bump label Feb 13, 2026
@nogates nogates force-pushed the nogates/fix-templates-for-equals-and-class-fields branch from 08b1968 to fc61846 Compare February 13, 2026 12:43
@nogates nogates force-pushed the nogates/fix-templates-for-equals-and-class-fields branch from 0a2f308 to 41e32bc Compare February 13, 2026 13:58
@nogates nogates force-pushed the nogates/fix-templates-for-equals-and-class-fields branch from 5b477e4 to d714965 Compare February 13, 2026 14:03
@nogates nogates force-pushed the nogates/fix-templates-for-equals-and-class-fields branch from f693dd6 to 35ec441 Compare February 13, 2026 14:14
@nogates nogates merged commit 175527b into master Feb 18, 2026
17 checks passed
@nogates nogates deleted the nogates/fix-templates-for-equals-and-class-fields branch February 18, 2026 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/Fixed Fixed features results into a bug fix version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants