add custom extent prop for geomap widget#2602
Closed
api-clients-generation-pipeline[bot] wants to merge 1 commit into
Closed
add custom extent prop for geomap widget#2602api-clients-generation-pipeline[bot] wants to merge 1 commit into
api-clients-generation-pipeline[bot] wants to merge 1 commit into
Conversation
| } | ||
|
|
||
| def __init__(self_, focus: str, **kwargs): | ||
| def __init__(self_, focus: str, custom_extent: Union[List[float], UnsetType] = unset, **kwargs): |
There was a problem hiding this comment.
🔴 Code Quality Violation
Suggested change
| def __init__(self_, focus: str, custom_extent: Union[List[float], UnsetType] = unset, **kwargs): | |
| def __init__(self, focus: str, custom_extent: Union[List[float], UnsetType] = unset, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
0fe7558 to
c49361c
Compare
jack-edmonds-dd
approved these changes
Jun 18, 2025
eb20773 to
d2de444
Compare
3aaefc3 to
a159d93
Compare
|
|
||
| def __init__(self_, focus: str, **kwargs): | ||
| def __init__( | ||
| self_, custom_extent: Union[List[float], UnsetType] = unset, focus: Union[str, UnsetType] = unset, **kwargs |
There was a problem hiding this comment.
🔴 Code Quality Violation
Suggested change
| self_, custom_extent: Union[List[float], UnsetType] = unset, focus: Union[str, UnsetType] = unset, **kwargs | |
| self, custom_extent: Union[List[float], UnsetType] = unset, focus: Union[str, UnsetType] = unset, **kwargs |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
5e8ac13 to
08552e8
Compare
08552e8 to
152e80b
Compare
|
This PR has been automatically marked as stale because it has not had activity in the last 30 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See DataDog/datadog-api-spec#3923 Test branch datadog-api-spec/test/victor.wei/DEX-114/add_custom_extent_to_tiledef