Support x-keep-typed-in-additional-properties in Python model generator#3665
Open
charlie-zhang109 wants to merge 2 commits into
Open
Support x-keep-typed-in-additional-properties in Python model generator#3665charlie-zhang109 wants to merge 2 commits into
charlie-zhang109 wants to merge 2 commits into
Conversation
When a schema sets `x-keep-typed-in-additional-properties: true`, emit a `_keep_typed_in_additional_properties = True` class attribute. In Python all fields are already stored in `_data_store` and accessible via `model["key"]` regardless of type; this marker makes the intent explicit for tooling. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…mantic marker In Python, typed fields are already reachable via bracket notation through _data_store, so no runtime behaviour change is required. The marker makes the flag visible for introspection and aligns semantics with other language SDKs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When a schema sets
x-keep-typed-in-additional-properties: true(introduced in DataDog/datadog-api-spec#5941), the Python model generator emits a_keep_typed_in_additional_properties = Trueclass attribute.In Python, all fields (typed and untyped) are already stored in
_data_storeand accessible via bothmodel.python_attrandmodel["json_key"]syntax — no deserialization change is needed. The class attribute is a marker for tooling and for consistency with other SDK clients.The first consumer is
UsageSummaryDate,UsageSummaryDateOrg, andUsageSummaryResponse.Companion PRs:
Review checklist
This PR includes all newly recorded cassettes for any modified tests.
This PR does not rely on API client schema changes.
Or, this PR relies on API schema changes and this is a Draft PR to include tests for that new functionality.