Skip to content

Support x-keep-typed-in-additional-properties in Rust model generator #1730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
charlie-zhang109 wants to merge 3 commits into
base: master
Choose a base branch
from
+7 −0
Open

Support x-keep-typed-in-additional-properties in Rust model generator #1730

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
336a84c
Support x-keep-typed-in-additional-properties in Rust model generator
charlie-zhang109 Jun 8, 2026
638fa84
docs: clarify that if let Ok guard on from_value is infallible for se…
charlie-zhang109 Jun 8, 2026
269f2ab
docs: clarify silent-drop behavior for typed AP schemas in if let Ok …
charlie-zhang109 Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .generator/src/generator/templates/model_simple.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,13 @@ impl<'de> Deserialize<'de> for {{ name }} {
let mut _unparsed = false;

while let Some((k, v)) = map.next_entry::<String, serde_json::Value>()? {
{%- if additionalProperties != false and model.get("x-keep-typed-in-additional-properties") %}
// from_value::<serde_json::Value> is infallible so Ok always fires;
// for typed AP schemas a type mismatch silently drops the entry (same as the catch-all arm).
if let Ok(ap_value) = serde_json::from_value(v.clone()) {
additional_properties.insert(k.clone(), ap_value);
}
{%- endif %}
match k.as_str() {
{%- for attr, schema in model.get("properties", {}).items() %}
{%- set required = attr in model.required %}
Expand Down
Loading