Skip to content

Commit 7c2a340

Browse files
authored
Revert "Fix consistency issues in security monitoring signal triage routes (#…" (#3805)
This reverts commit d7c2151.
1 parent d7c2151 commit 7c2a340

File tree

4 files changed

+46
-36
lines changed

4 files changed

+46
-36
lines changed

.generator/schemas/v2/openapi.yaml

Lines changed: 45 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -57909,7 +57909,6 @@ components:
5790957909
- none
5791057910
- false_positive
5791157911
- testing_or_maintenance
57912-
- remediated
5791357912
- investigated_case_opened
5791457913
- true_positive_benign
5791557914
- true_positive_malicious
@@ -57919,7 +57918,6 @@ components:
5791957918
- NONE
5792057919
- FALSE_POSITIVE
5792157920
- TESTING_OR_MAINTENANCE
57922-
- REMEDIATED
5792357921
- INVESTIGATED_CASE_OPENED
5792457922
- TRUE_POSITIVE_BENIGN
5792557923
- TRUE_POSITIVE_MALICIOUS
@@ -102449,8 +102447,6 @@ paths:
102449102447
schema:
102450102448
$ref: "#/components/schemas/SecurityMonitoringSignalResponse"
102451102449
description: OK
102452-
"403":
102453-
$ref: "#/components/responses/NotAuthorizedResponse"
102454102450
"404":
102455102451
$ref: "#/components/responses/NotFoundResponse"
102456102452
"429":
@@ -102488,17 +102484,25 @@ paths:
102488102484
$ref: "#/components/schemas/SecurityMonitoringSignalTriageUpdateResponse"
102489102485
description: OK
102490102486
"400":
102491-
$ref: "#/components/responses/BadRequestResponse"
102487+
content:
102488+
application/json:
102489+
schema:
102490+
$ref: "#/components/schemas/APIErrorResponse"
102491+
description: Bad Request
102492102492
"403":
102493-
$ref: "#/components/responses/NotAuthorizedResponse"
102493+
content:
102494+
application/json:
102495+
schema:
102496+
$ref: "#/components/schemas/APIErrorResponse"
102497+
description: Forbidden
102494102498
"404":
102495-
$ref: "#/components/responses/NotFoundResponse"
102499+
content:
102500+
application/json:
102501+
schema:
102502+
$ref: "#/components/schemas/APIErrorResponse"
102503+
description: Not Found
102496102504
"429":
102497102505
$ref: "#/components/responses/TooManyRequestsResponse"
102498-
security:
102499-
- apiKeyAuth: []
102500-
appKeyAuth: []
102501-
- AuthZ: []
102502102506
summary: Modify the triage assignee of a security signal
102503102507
tags: ["Security Monitoring"]
102504102508
x-codegen-request-body-name: body
@@ -102528,17 +102532,25 @@ paths:
102528102532
$ref: "#/components/schemas/SecurityMonitoringSignalTriageUpdateResponse"
102529102533
description: OK
102530102534
"400":
102531-
$ref: "#/components/responses/BadRequestResponse"
102535+
content:
102536+
application/json:
102537+
schema:
102538+
$ref: "#/components/schemas/APIErrorResponse"
102539+
description: Bad Request
102532102540
"403":
102533-
$ref: "#/components/responses/NotAuthorizedResponse"
102541+
content:
102542+
application/json:
102543+
schema:
102544+
$ref: "#/components/schemas/APIErrorResponse"
102545+
description: Forbidden
102534102546
"404":
102535-
$ref: "#/components/responses/NotFoundResponse"
102547+
content:
102548+
application/json:
102549+
schema:
102550+
$ref: "#/components/schemas/APIErrorResponse"
102551+
description: Not Found
102536102552
"429":
102537102553
$ref: "#/components/responses/TooManyRequestsResponse"
102538-
security:
102539-
- apiKeyAuth: []
102540-
appKeyAuth: []
102541-
- AuthZ: []
102542102554
summary: Change the related incidents of a security signal
102543102555
tags: ["Security Monitoring"]
102544102556
x-codegen-request-body-name: body
@@ -102568,17 +102580,25 @@ paths:
102568102580
$ref: "#/components/schemas/SecurityMonitoringSignalTriageUpdateResponse"
102569102581
description: OK
102570102582
"400":
102571-
$ref: "#/components/responses/BadRequestResponse"
102583+
content:
102584+
application/json:
102585+
schema:
102586+
$ref: "#/components/schemas/APIErrorResponse"
102587+
description: Bad Request
102572102588
"403":
102573-
$ref: "#/components/responses/NotAuthorizedResponse"
102589+
content:
102590+
application/json:
102591+
schema:
102592+
$ref: "#/components/schemas/APIErrorResponse"
102593+
description: Forbidden
102574102594
"404":
102575-
$ref: "#/components/responses/NotFoundResponse"
102595+
content:
102596+
application/json:
102597+
schema:
102598+
$ref: "#/components/schemas/APIErrorResponse"
102599+
description: Not Found
102576102600
"429":
102577102601
$ref: "#/components/responses/TooManyRequestsResponse"
102578-
security:
102579-
- apiKeyAuth: []
102580-
appKeyAuth: []
102581-
- AuthZ: []
102582102602
summary: Change the triage state of a security signal
102583102603
tags: ["Security Monitoring"]
102584102604
x-codegen-request-body-name: body

services/security_monitoring/src/v2/SecurityMonitoringApi.ts

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1599,7 +1599,6 @@ export class SecurityMonitoringApiRequestFactory extends BaseAPIRequestFactory {
15991599
applySecurityAuthentication(_config, requestContext, [
16001600
"apiKeyAuth",
16011601
"appKeyAuth",
1602-
"AuthZ",
16031602
]);
16041603

16051604
return requestContext;
@@ -1668,7 +1667,6 @@ export class SecurityMonitoringApiRequestFactory extends BaseAPIRequestFactory {
16681667
applySecurityAuthentication(_config, requestContext, [
16691668
"apiKeyAuth",
16701669
"appKeyAuth",
1671-
"AuthZ",
16721670
]);
16731671

16741672
return requestContext;
@@ -1734,7 +1732,6 @@ export class SecurityMonitoringApiRequestFactory extends BaseAPIRequestFactory {
17341732
applySecurityAuthentication(_config, requestContext, [
17351733
"apiKeyAuth",
17361734
"appKeyAuth",
1737-
"AuthZ",
17381735
]);
17391736

17401737
return requestContext;
@@ -8098,11 +8095,7 @@ export class SecurityMonitoringApiResponseProcessor {
80988095
) as SecurityMonitoringSignalResponse;
80998096
return body;
81008097
}
8101-
if (
8102-
response.httpStatusCode === 403 ||
8103-
response.httpStatusCode === 404 ||
8104-
response.httpStatusCode === 429
8105-
) {
8098+
if (response.httpStatusCode === 404 || response.httpStatusCode === 429) {
81068099
const bodyText = parse(await response.body.text(), contentType);
81078100
let body: APIErrorResponse;
81088101
try {

services/security_monitoring/src/v2/models/SecurityMonitoringSignalArchiveReason.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ export type SecurityMonitoringSignalArchiveReason =
77
| typeof NONE
88
| typeof FALSE_POSITIVE
99
| typeof TESTING_OR_MAINTENANCE
10-
| typeof REMEDIATED
1110
| typeof INVESTIGATED_CASE_OPENED
1211
| typeof TRUE_POSITIVE_BENIGN
1312
| typeof TRUE_POSITIVE_MALICIOUS
@@ -16,7 +15,6 @@ export type SecurityMonitoringSignalArchiveReason =
1615
export const NONE = "none";
1716
export const FALSE_POSITIVE = "false_positive";
1817
export const TESTING_OR_MAINTENANCE = "testing_or_maintenance";
19-
export const REMEDIATED = "remediated";
2018
export const INVESTIGATED_CASE_OPENED = "investigated_case_opened";
2119
export const TRUE_POSITIVE_BENIGN = "true_positive_benign";
2220
export const TRUE_POSITIVE_MALICIOUS = "true_positive_malicious";

services/security_monitoring/src/v2/models/TypingInfo.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -544,7 +544,6 @@ export const TypingInfo: ModelTypingInfo = {
544544
"none",
545545
"false_positive",
546546
"testing_or_maintenance",
547-
"remediated",
548547
"investigated_case_opened",
549548
"true_positive_benign",
550549
"true_positive_malicious",

0 commit comments

Comments
 (0)