Trigger format pipeline for TS (#2135)

* add basic linter and formatter

* install before run

* run on ts files only

* js files as well

* add back generate.sh

* Regenerate client from commit 13d1130f23c1897768dad6288021e8ac9fd73e01 of spec repo

---------

Co-authored-by: Sherzod Karimov <sherzod.karimov@datadoghq.com>
Co-authored-by: ci.datadog-api-spec <packages@datadoghq.com>

Author: 3 people

.apigentools-info

@@ -4,13 +4,13 @@
     "spec_versions": {
         "v1": {
             "apigentools_version": "1.6.6",
-            "regenerated": "2025-04-03 13:11:44.896804",
-            "spec_repo_commit": "341c3f5"
+            "regenerated": "2025-04-03 18:18:29.713122",
+            "spec_repo_commit": "13d1130"
         },
         "v2": {
             "apigentools_version": "1.6.6",
-            "regenerated": "2025-04-03 13:11:44.912645",
-            "spec_repo_commit": "341c3f5"
+            "regenerated": "2025-04-03 18:18:29.728290",
+            "spec_repo_commit": "13d1130"
         }
     }
 }

.generator/schemas/v1/openapi.yaml

@@ -13489,6 +13489,10 @@ components:
           default: true
           description: Show the main body of the alert event.
           type: boolean
+        mute_buttons:
+          default: false
+          description: Show interactive buttons to mute the alerting monitor.
+          type: boolean
         notified:
           default: true
           description: Show the list of @-handles in the alert event.
@@ -13507,12 +13511,14 @@ components:
       example:
       - display:
           message: true
+          mute_buttons: true
           notified: true
           snapshot: true
           tags: true
         name: '#channel_name_main_account'
       - display:
           message: true
+          mute_buttons: true
           notified: true
           snapshot: false
           tags: true

.generator/schemas/v2/openapi.yaml

@@ -30212,7 +30212,7 @@ components:
           type: string
       type: object
     SingleAggregatedConnectionResponseArray:
-      description: The definition of `SingleAggregatedConnectionResponseArray` object.
+      description: List of aggregated connections.
       example:
         data:
         - attributes:
@@ -30236,25 +30236,25 @@ components:
           type: aggregated_connection
       properties:
         data:
-          description: The `SingleAggregatedConnectionResponseArray` `data`.
+          description: Array of aggregated connection objects.
           items:
             $ref: '#/components/schemas/SingleAggregatedConnectionResponseData'
           type: array
       type: object
     SingleAggregatedConnectionResponseData:
-      description: The definition of `SingleAggregatedConnectionResponseData` object.
+      description: Object describing an aggregated connection.
       properties:
         attributes:
           $ref: '#/components/schemas/SingleAggregatedConnectionResponseDataAttributes'
         id:
-          description: The `SingleAggregatedConnectionResponseData` `id`.
+          description: A unique identifier for the aggregated connection based on
+            the group by values.
           type: string
         type:
           $ref: '#/components/schemas/SingleAggregatedConnectionResponseDataType'
       type: object
     SingleAggregatedConnectionResponseDataAttributes:
-      description: The definition of `SingleAggregatedConnectionResponseDataAttributes`
-        object.
+      description: Attributes for an aggregated connection.
       properties:
         bytes_sent_by_client:
           description: The total number of bytes sent by the client over the given
@@ -30268,10 +30268,11 @@ components:
           type: integer
         group_bys:
           additionalProperties:
+            description: The values for each group by.
             items:
               type: string
             type: array
-          description: The `attributes` `group_bys`.
+          description: The key, value pairs for each group by.
           type: object
         packets_sent_by_client:
           description: The total number of packets sent by the client over the given
@@ -30322,9 +30323,7 @@ components:
       type: object
     SingleAggregatedConnectionResponseDataType:
       default: aggregated_connection
-      description: 'Aggregated connection resource type. Allowed enum values: `aggregated_connection`.
-
-        default: `aggregated_connection`'
+      description: Aggregated connection resource type.
       enum:
       - aggregated_connection
       type: string
@@ -44426,22 +44425,22 @@ paths:
       - Network Device Monitoring
   /api/v2/network/connections/aggregate:
     get:
-      description: Get aggregated connections
+      description: Get all aggregated connections.
       operationId: GetAggregatedConnections
       parameters:
       - description: Unix timestamp (number of seconds since epoch) of the start of
           the query window. If not provided, the start of the query window is 15 minutes
-          before the "to" timestamp. If neither "from" nor "to" are provided, the
-          query window is [now - 15m, now].
+          before the `to` timestamp. If neither `from` nor `to` are provided, the
+          query window is `[now - 15m, now]`.
         in: query
         name: from
         schema:
           format: int64
           type: integer
       - description: Unix timestamp (number of seconds since epoch) of the end of
           the query window. If not provided, the end of the query window is the current
-          time. If neither "from" nor "to" are provided, the query window is [now
-          - 15m, now].
+          time. If neither `from` nor `to` are provided, the query window is `[now
+          - 15m, now]`.
         in: query
         name: to
         schema:
@@ -44478,7 +44477,7 @@ paths:
           $ref: '#/components/responses/BadRequestResponse'
         '429':
           $ref: '#/components/responses/TooManyRequestsResponse'
-      summary: Get aggregated connections
+      summary: Get all aggregated connections
       tags:
       - Cloud Network Monitoring
       x-unstable: '**Note**: This endpoint is in Preview. If you have any feedback,

.github/workflows/test.yml

@@ -38,7 +38,6 @@ jobs:
       - uses: actions/checkout@v3
         if: github.event.pull_request.head.repo.full_name == github.repository
         with:
-          fetch-depth: 0
           ref: ${{ github.event.pull_request.head.sha }}
           token: ${{ steps.get_token.outputs.token }}
       - uses: actions/setup-python@v4
@@ -59,13 +58,9 @@ jobs:
           path: ~/.cache/pre-commit
           key: pre-commit|${{ env.PY }}|${{ hashFiles('.pre-commit-config.yaml') }}
       - id: pre_commit
-        name: Run pre-commit
+        name: Run generate to fix lint and format
         if: github.event.action != 'closed' && github.event.pull_request.merged != true
-        run: |
-          pre-commit run --from-ref "${FROM_REF}" --to-ref "${TO_REF}" --show-diff-on-failure --color=always
-        env:
-          FROM_REF: ${{ github.event.pull_request.base.sha }}
-          TO_REF: ${{ github.event.pull_request.head.sha }}
+        run: bash -c "./generate.sh"
       - name: Commit changes
         if: github.event.pull_request.head.repo.full_name == github.repository && failure()
         run: |-

.gitignore

@@ -23,4 +23,3 @@ version.ts
 __pycache__
 *.pyc
 *.pyo
-

.pre-commit-config.yaml

@@ -1,10 +1,22 @@
 repos:
   - repo: local
     hooks:
+      - id: generate
+        name: Generate
+        language: node
+        entry: bash -c "./generate.sh"
+        pass_filenames: false
       - id: lint
         name: Lint
         language: node
         entry: yarn run lint:fix
         stages: [manual]
         pass_filenames: false
         language_version: "21.7.3"
+      - id: format
+        name: Format code
+        language: node
+        entry: yarn run format
+        stages: [manual]
+        pass_filenames: false
+        language_version: "21.7.3"

eslint.config.mjs

@@ -0,0 +1,10 @@
+// @ts-check
+
+import tseslint from 'typescript-eslint';
+
+export default tseslint.config(
+    // // TODO: Enable and fix all issues after the migration and tests are passing
+    // tseslint.configs.recommended,
+    // tseslint.configs.strict,
+    // tseslint.configs.stylistic,
+);

features/v1/slack_integration.feature

@@ -9,122 +9,122 @@ Feature: Slack Integration
     And a valid "appKeyAuth" key in the system
     And an instance of "SlackIntegration" API
 
-  @generated @skip @team:DataDog/saas-integrations
+  @generated @skip @team:DataDog/chat-integrations
   Scenario: Create a Slack integration channel returns "Bad Request" response
     Given new "CreateSlackIntegrationChannel" request
     And request contains "account_name" parameter from "REPLACE.ME"
-    And body with value {"display": {"message": true, "notified": true, "snapshot": true, "tags": true}, "name": "#general"}
+    And body with value {"display": {"message": true, "mute_buttons": false, "notified": true, "snapshot": true, "tags": true}, "name": "#general"}
     When the request is sent
     Then the response status is 400 Bad Request
 
-  @generated @skip @team:DataDog/saas-integrations
+  @generated @skip @team:DataDog/chat-integrations
   Scenario: Create a Slack integration channel returns "Item Not Found" response
     Given new "CreateSlackIntegrationChannel" request
     And request contains "account_name" parameter from "REPLACE.ME"
-    And body with value {"display": {"message": true, "notified": true, "snapshot": true, "tags": true}, "name": "#general"}
+    And body with value {"display": {"message": true, "mute_buttons": false, "notified": true, "snapshot": true, "tags": true}, "name": "#general"}
     When the request is sent
     Then the response status is 404 Item Not Found
 
-  @generated @skip @team:DataDog/saas-integrations
+  @generated @skip @team:DataDog/chat-integrations
   Scenario: Create a Slack integration channel returns "OK" response
     Given new "CreateSlackIntegrationChannel" request
     And request contains "account_name" parameter from "REPLACE.ME"
-    And body with value {"display": {"message": true, "notified": true, "snapshot": true, "tags": true}, "name": "#general"}
+    And body with value {"display": {"message": true, "mute_buttons": false, "notified": true, "snapshot": true, "tags": true}, "name": "#general"}
     When the request is sent
     Then the response status is 200 OK
 
-  @generated @skip @team:DataDog/saas-integrations
+  @generated @skip @team:DataDog/chat-integrations
   Scenario: Get a Slack integration channel returns "Bad Request" response
     Given new "GetSlackIntegrationChannel" request
     And request contains "account_name" parameter from "REPLACE.ME"
     And request contains "channel_name" parameter from "REPLACE.ME"
     When the request is sent
     Then the response status is 400 Bad Request
 
-  @generated @skip @team:DataDog/saas-integrations
+  @generated @skip @team:DataDog/chat-integrations
   Scenario: Get a Slack integration channel returns "Item Not Found" response
     Given new "GetSlackIntegrationChannel" request
     And request contains "account_name" parameter from "REPLACE.ME"
     And request contains "channel_name" parameter from "REPLACE.ME"
     When the request is sent
     Then the response status is 404 Item Not Found
 
-  @generated @skip @team:DataDog/saas-integrations
+  @generated @skip @team:DataDog/chat-integrations
   Scenario: Get a Slack integration channel returns "OK" response
     Given new "GetSlackIntegrationChannel" request
     And request contains "account_name" parameter from "REPLACE.ME"
     And request contains "channel_name" parameter from "REPLACE.ME"
     When the request is sent
     Then the response status is 200 OK
 
-  @generated @skip @team:DataDog/saas-integrations
+  @generated @skip @team:DataDog/chat-integrations
   Scenario: Get all channels in a Slack integration returns "Bad Request" response
     Given new "GetSlackIntegrationChannels" request
     And request contains "account_name" parameter from "REPLACE.ME"
     When the request is sent
     Then the response status is 400 Bad Request
 
-  @generated @skip @team:DataDog/saas-integrations
+  @generated @skip @team:DataDog/chat-integrations
   Scenario: Get all channels in a Slack integration returns "Item Not Found" response
     Given new "GetSlackIntegrationChannels" request
     And request contains "account_name" parameter from "REPLACE.ME"
     When the request is sent
     Then the response status is 404 Item Not Found
 
-  @generated @skip @team:DataDog/saas-integrations
+  @generated @skip @team:DataDog/chat-integrations
   Scenario: Get all channels in a Slack integration returns "OK" response
     Given new "GetSlackIntegrationChannels" request
     And request contains "account_name" parameter from "REPLACE.ME"
     When the request is sent
     Then the response status is 200 OK
 
-  @generated @skip @team:DataDog/saas-integrations
+  @generated @skip @team:DataDog/chat-integrations
   Scenario: Remove a Slack integration channel returns "Bad Request" response
     Given new "RemoveSlackIntegrationChannel" request
     And request contains "account_name" parameter from "REPLACE.ME"
     And request contains "channel_name" parameter from "REPLACE.ME"
     When the request is sent
     Then the response status is 400 Bad Request
 
-  @generated @skip @team:DataDog/saas-integrations
+  @generated @skip @team:DataDog/chat-integrations
   Scenario: Remove a Slack integration channel returns "Item Not Found" response
     Given new "RemoveSlackIntegrationChannel" request
     And request contains "account_name" parameter from "REPLACE.ME"
     And request contains "channel_name" parameter from "REPLACE.ME"
     When the request is sent
     Then the response status is 404 Item Not Found
 
-  @generated @skip @team:DataDog/saas-integrations
+  @generated @skip @team:DataDog/chat-integrations
   Scenario: Remove a Slack integration channel returns "The channel was removed successfully." response
     Given new "RemoveSlackIntegrationChannel" request
     And request contains "account_name" parameter from "REPLACE.ME"
     And request contains "channel_name" parameter from "REPLACE.ME"
     When the request is sent
     Then the response status is 204 The channel was removed successfully.
 
-  @generated @skip @team:DataDog/saas-integrations
+  @generated @skip @team:DataDog/chat-integrations
   Scenario: Update a Slack integration channel returns "Bad Request" response
     Given new "UpdateSlackIntegrationChannel" request
     And request contains "account_name" parameter from "REPLACE.ME"
     And request contains "channel_name" parameter from "REPLACE.ME"
-    And body with value {"display": {"message": true, "notified": true, "snapshot": true, "tags": true}, "name": "#general"}
+    And body with value {"display": {"message": true, "mute_buttons": false, "notified": true, "snapshot": true, "tags": true}, "name": "#general"}
     When the request is sent
     Then the response status is 400 Bad Request
 
-  @generated @skip @team:DataDog/saas-integrations
+  @generated @skip @team:DataDog/chat-integrations
   Scenario: Update a Slack integration channel returns "Item Not Found" response
     Given new "UpdateSlackIntegrationChannel" request
     And request contains "account_name" parameter from "REPLACE.ME"
     And request contains "channel_name" parameter from "REPLACE.ME"
-    And body with value {"display": {"message": true, "notified": true, "snapshot": true, "tags": true}, "name": "#general"}
+    And body with value {"display": {"message": true, "mute_buttons": false, "notified": true, "snapshot": true, "tags": true}, "name": "#general"}
     When the request is sent
     Then the response status is 404 Item Not Found
 
-  @generated @skip @team:DataDog/saas-integrations
+  @generated @skip @team:DataDog/chat-integrations
   Scenario: Update a Slack integration channel returns "OK" response
     Given new "UpdateSlackIntegrationChannel" request
     And request contains "account_name" parameter from "REPLACE.ME"
     And request contains "channel_name" parameter from "REPLACE.ME"
-    And body with value {"display": {"message": true, "notified": true, "snapshot": true, "tags": true}, "name": "#general"}
+    And body with value {"display": {"message": true, "mute_buttons": false, "notified": true, "snapshot": true, "tags": true}, "name": "#general"}
     When the request is sent
     Then the response status is 200 OK

features/v2/cloud_network_monitoring.feature

@@ -12,11 +12,6 @@ Feature: Cloud Network Monitoring
     And operation "GetAggregatedConnections" enabled
     And new "GetAggregatedConnections" request
 
-  @generated @skip @team:Datadog/networks
-  Scenario: Get aggregated connections returns "Bad Request" response
-    When the request is sent
-    Then the response status is 400 Bad Request
-
   @team:Datadog/networks
   Scenario: Get aggregated connections returns "OK" response
     When the request is sent
@@ -27,3 +22,8 @@ Feature: Cloud Network Monitoring
     Given request contains "limit" parameter with value 6000
     When the request is sent
     Then the response status is 400 Bad Request
+
+  @generated @skip @team:Datadog/networks
+  Scenario: Get all aggregated connections returns "OK" response
+    When the request is sent
+    Then the response status is 200 OK

generate.sh

@@ -24,3 +24,4 @@ pre_commit_wrapper () {
 }
 
 # pre_commit_wrapper lint
+pre_commit_wrapper format