Fix "does not have field" assertion to accept undefined#3922
Merged
Conversation
ObjectSerializer.deserialize() always assigns `instance[attr] = undefined` for optional fields absent from the JSON response, so the property key exists on the object even when the field was not present. Chai's `.not.have.property()` uses hasOwnProperty() which returns true for undefined-valued keys, causing the assertion to fail. Treat a property value of `undefined` as equivalent to "field not present" by asserting the value `.to.be.undefined` instead of checking key existence. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
skarimo
approved these changes
Apr 13, 2026
MintsInc
deleted the
ulysse.mavrocordatos/fix-does-not-have-field-assertion
branch
github-actions Bot
pushed a commit
that referenced
this pull request
Apr 13, 2026
ObjectSerializer.deserialize() always assigns `instance[attr] = undefined` for optional fields absent from the JSON response, so the property key exists on the object even when the field was not present. Chai's `.not.have.property()` uses hasOwnProperty() which returns true for undefined-valued keys, causing the assertion to fail. Treat a property value of `undefined` as equivalent to "field not present" by asserting the value `.to.be.undefined` instead of checking key existence. Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> f569eb4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ObjectSerializer.deserialize()always assignsinstance[attr] = undefinedfor optional fields absent from the JSON response, so the property key exists on the object even when the field was not present in JSON.not.have.property()useshasOwnProperty(), which returnstrueforundefined-valued keys, causing the"does not have field"step to fail for any optional model field that is absent from the API response.to.be.undefinedon the value instead of checking key non-existence — semantically identical for JSON deserialization, but tolerates the wayObjectSerializerinitialises optional fieldsTest plan
./run-tests.sh) — 1418 scenarios passed, 0 failed🤖 Generated with Claude Code