Skip to content

Commit 0e7d7b0

Browse files
authored
[SVLS-8796] fix: Change client_drop_p0s from true to false (#1155)
## Overview Right now the `/info` endpoint of bottlecap returns `client_drop_p0s: true`, among other things. This is wrong, as "true" means the agent supports client-side P0 span dropping, but we never want the client to drop spans. In both cases (Agent-Side Stats and Backend Stats), we need the client to send all spans to the agent. Therefore, this PR changes the value from `true` to `false`. ## Testing N/A. Let me know if there's a good way to test this. ## Notes Thanks @ajgajg1134 @lucaspimentel @purple4reina for proposing this change and contributing to some words in the PR summary.
1 parent 29e1215 commit 0e7d7b0

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

bottlecap/src/traces/trace_agent.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -458,7 +458,7 @@ impl TraceAgent {
458458
V2_DEBUGGER_ENDPOINT_PATH,
459459
DEBUGGER_DIAGNOSTICS_ENDPOINT_PATH,
460460
],
461-
"client_drop_p0s": true,
461+
"client_drop_p0s": false,
462462
}
463463
);
464464
(StatusCode::OK, response_json.to_string()).into_response()

0 commit comments

Comments
 (0)