Commit 1c181be
authored
## Overview
Bump all `libdd-*` dependencies from `db05e1f` to `48da0d8` to pick up
[libdatadog PR #2071](DataDog/libdatadog#2071),
which fixes how the `datadog-client-computed-stats` and
`datadog-client-computed-top-level` headers are parsed so the behavior
matches the Go trace-agent.
Bottlecap consumes this exact path in
`bottlecap/src/traces/trace_agent.rs` via `(&parts.headers).into()`, so
it directly benefits from the fix.
### Adapting to breaking API changes between the two revisions
- `HttpClientTrait` was renamed to `HttpClientCapability`
- `SendData::send` now requires `C: HttpClientCapability +
SleepCapability`, so implemented `SleepCapability` for `HttpClient`
### Testing
Added Tier 0 coverage in `trace_agent.rs` pinning the new header-parsing
behavior at the `(&headers).into()` boundary `handle_traces` uses:
- `true`, `yes`, `t`, `1` -> flag set
- `false`, `0`, `f`, `F`, `FALSE`, `False` -> flag clear
- absent/empty -> clear
- `client_computed_top_level` no longer set by presence alone (pre-bump
regression)
These test would fail on the pre-bump rev (`db05e1f`), so they lock in
the fix.
> *"Turns out `yes` means yes and `false` means false. Took a whole PR
to teach the parser what every toddler already knows."* — Claude 🤖
[APMSVLS-487](https://datadoghq.atlassian.net/browse/APMSVLS-487)
[APMSVLS-487]:
https://datadoghq.atlassian.net/browse/APMSVLS-487?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
1 parent 06d0872 commit 1c181be
5 files changed
Lines changed: 171 additions & 54 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
| 15 | + | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| |||
21 | 22 | | |
22 | 23 | | |
23 | 24 | | |
| 25 | + | |
24 | 26 | | |
25 | 27 | | |
26 | 28 | | |
| |||
29 | 31 | | |
30 | 32 | | |
31 | 33 | | |
32 | | - | |
33 | | - | |
| 34 | + | |
| 35 | + | |
34 | 36 | | |
35 | 37 | | |
36 | 38 | | |
| |||
42 | 44 | | |
43 | 45 | | |
44 | 46 | | |
45 | | - | |
| 47 | + | |
46 | 48 | | |
47 | 49 | | |
48 | | - | |
| 50 | + | |
49 | 51 | | |
50 | 52 | | |
51 | 53 | | |
| |||
76 | 78 | | |
77 | 79 | | |
78 | 80 | | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
79 | 95 | | |
80 | 96 | | |
81 | 97 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| |||
0 commit comments