Skip to content

Commit 1dc502e

Browse files
authored
aj/timestamp metrics (#582)
* feat: use metric ts buckets * feat: debug * fix: flush strategy interval parsing * clean up periodicity * fix: fmt * feat: use main merge commit * feat: lockfile. remove println * fix: licenses, tests * fix: fmt strikes again * fix: floor ts because get_by_id is a helper method used only by tests * feat: CR Feedback. Remove struct, just use the enum val as timestamp carrier. Move timestamp into enhanced metric
1 parent 9c8660d commit 1dc502e

File tree

11 files changed

+324
-132
lines changed

11 files changed

+324
-132
lines changed

bottlecap/Cargo.lock

Lines changed: 5 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

bottlecap/Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ datadog-trace-utils = { git = "https://github.com/DataDog/libdatadog", rev = "b5
1515
datadog-trace-mini-agent = { git = "https://github.com/DataDog/libdatadog", rev = "b58170645053a75fcb7abd6920bdafb6ab2e5a45" }
1616
datadog-trace-normalization = { git = "https://github.com/DataDog/libdatadog", rev = "b58170645053a75fcb7abd6920bdafb6ab2e5a45" }
1717
datadog-trace-obfuscation = { git = "https://github.com/DataDog/libdatadog", rev = "b58170645053a75fcb7abd6920bdafb6ab2e5a45" }
18-
dogstatsd = { git = "https://github.com/DataDog/libdatadog", rev = "b58170645053a75fcb7abd6920bdafb6ab2e5a45" }
18+
dogstatsd = { git = "https://github.com/DataDog/libdatadog", rev = "89754a92d3725c10b6e6e14202efd541a9fdc5a7" }
1919
figment = { version = "0.10", default-features = false, features = ["yaml", "env"] }
2020
hyper = { version = "0.14", default-features = false, features = ["server"] }
2121
lazy_static = { version = "1.5", default-features = false }
@@ -40,7 +40,7 @@ rmp-serde = { version = "1.3.0", default-features = false }
4040
rustls = { version = "0.23.18", default-features = false, features = ["aws-lc-rs"] }
4141
rand = { version = "0.8", default-features = false }
4242
prost = { version = "0.11.6", default-features = false }
43-
zstd = { version = "0.13.2", default-features = false }
43+
zstd = { version = "0.13.3", default-features = false }
4444
futures = { version = "0.3.31", default-features = false}
4545

4646
[dev-dependencies]

bottlecap/LICENSE-3rdparty.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6445,7 +6445,7 @@ third_party_libraries:
64456445
- license: Apache-2.0
64466446
text: " Apache License\n Version 2.0, January 2004\n http://www.apache.org/licenses/\n\nTERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION\n\n1. Definitions.\n\n \"License\" shall mean the terms and conditions for use, reproduction,\n and distribution as defined by Sections 1 through 9 of this document.\n\n \"Licensor\" shall mean the copyright owner or entity authorized by\n the copyright owner that is granting the License.\n\n \"Legal Entity\" shall mean the union of the acting entity and all\n other entities that control, are controlled by, or are under common\n control with that entity. For the purposes of this definition,\n \"control\" means (i) the power, direct or indirect, to cause the\n direction or management of such entity, whether by contract or\n otherwise, or (ii) ownership of fifty percent (50%) or more of the\n outstanding shares, or (iii) beneficial ownership of such entity.\n\n \"You\" (or \"Your\") shall mean an individual or Legal Entity\n exercising permissions granted by this License.\n\n \"Source\" form shall mean the preferred form for making modifications,\n including but not limited to software source code, documentation\n source, and configuration files.\n\n \"Object\" form shall mean any form resulting from mechanical\n transformation or translation of a Source form, including but\n not limited to compiled object code, generated documentation,\n and conversions to other media types.\n\n \"Work\" shall mean the work of authorship, whether in Source or\n Object form, made available under the License, as indicated by a\n copyright notice that is included in or attached to the work\n (an example is provided in the Appendix below).\n\n \"Derivative Works\" shall mean any work, whether in Source or Object\n form, that is based on (or derived from) the Work and for which the\n editorial revisions, annotations, elaborations, or other modifications\n represent, as a whole, an original work of authorship. For the purposes\n of this License, Derivative Works shall not include works that remain\n separable from, or merely link (or bind by name) to the interfaces of,\n the Work and Derivative Works thereof.\n\n \"Contribution\" shall mean any work of authorship, including\n the original version of the Work and any modifications or additions\n to that Work or Derivative Works thereof, that is intentionally\n submitted to Licensor for inclusion in the Work by the copyright owner\n or by an individual or Legal Entity authorized to submit on behalf of\n the copyright owner. For the purposes of this definition, \"submitted\"\n means any form of electronic, verbal, or written communication sent\n to the Licensor or its representatives, including but not limited to\n communication on electronic mailing lists, source code control systems,\n and issue tracking systems that are managed by, or on behalf of, the\n Licensor for the purpose of discussing and improving the Work, but\n excluding communication that is conspicuously marked or otherwise\n designated in writing by the copyright owner as \"Not a Contribution.\"\n\n \"Contributor\" shall mean Licensor and any individual or Legal Entity\n on behalf of whom a Contribution has been received by Licensor and\n subsequently incorporated within the Work.\n\n2. Grant of Copyright License. Subject to the terms and conditions of\n this License, each Contributor hereby grants to You a perpetual,\n worldwide, non-exclusive, no-charge, royalty-free, irrevocable\n copyright license to reproduce, prepare Derivative Works of,\n publicly display, publicly perform, sublicense, and distribute the\n Work and such Derivative Works in Source or Object form.\n\n3. Grant of Patent License. Subject to the terms and conditions of\n this License, each Contributor hereby grants to You a perpetual,\n worldwide, non-exclusive, no-charge, royalty-free, irrevocable\n (except as stated in this section) patent license to make, have made,\n use, offer to sell, sell, import, and otherwise transfer the Work,\n where such license applies only to those patent claims licensable\n by such Contributor that are necessarily infringed by their\n Contribution(s) alone or by combination of their Contribution(s)\n with the Work to which such Contribution(s) was submitted. If You\n institute patent litigation against any entity (including a\n cross-claim or counterclaim in a lawsuit) alleging that the Work\n or a Contribution incorporated within the Work constitutes direct\n or contributory patent infringement, then any patent licenses\n granted to You under this License for that Work shall terminate\n as of the date such litigation is filed.\n\n4. Redistribution. You may reproduce and distribute copies of the\n Work or Derivative Works thereof in any medium, with or without\n modifications, and in Source or Object form, provided that You\n meet the following conditions:\n\n (a) You must give any other recipients of the Work or\n Derivative Works a copy of this License; and\n\n (b) You must cause any modified files to carry prominent notices\n stating that You changed the files; and\n\n (c) You must retain, in the Source form of any Derivative Works\n that You distribute, all copyright, patent, trademark, and\n attribution notices from the Source form of the Work,\n excluding those notices that do not pertain to any part of\n the Derivative Works; and\n\n (d) If the Work includes a \"NOTICE\" text file as part of its\n distribution, then any Derivative Works that You distribute must\n include a readable copy of the attribution notices contained\n within such NOTICE file, excluding those notices that do not\n pertain to any part of the Derivative Works, in at least one\n of the following places: within a NOTICE text file distributed\n as part of the Derivative Works; within the Source form or\n documentation, if provided along with the Derivative Works; or,\n within a display generated by the Derivative Works, if and\n wherever such third-party notices normally appear. The contents\n of the NOTICE file are for informational purposes only and\n do not modify the License. You may add Your own attribution\n notices within Derivative Works that You distribute, alongside\n or as an addendum to the NOTICE text from the Work, provided\n that such additional attribution notices cannot be construed\n as modifying the License.\n\n You may add Your own copyright statement to Your modifications and\n may provide additional or different license terms and conditions\n for use, reproduction, or distribution of Your modifications, or\n for any such Derivative Works as a whole, provided Your use,\n reproduction, and distribution of the Work otherwise complies with\n the conditions stated in this License.\n\n5. Submission of Contributions. Unless You explicitly state otherwise,\n any Contribution intentionally submitted for inclusion in the Work\n by You to the Licensor shall be under the terms and conditions of\n this License, without any additional terms or conditions.\n Notwithstanding the above, nothing herein shall supersede or modify\n the terms of any separate license agreement you may have executed\n with Licensor regarding such Contributions.\n\n6. Trademarks. This License does not grant permission to use the trade\n names, trademarks, service marks, or product names of the Licensor,\n except as required for reasonable and customary use in describing the\n origin of the Work and reproducing the content of the NOTICE file.\n\n7. Disclaimer of Warranty. Unless required by applicable law or\n agreed to in writing, Licensor provides the Work (and each\n Contributor provides its Contributions) on an \"AS IS\" BASIS,\n WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or\n implied, including, without limitation, any warranties or conditions\n of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A\n PARTICULAR PURPOSE. You are solely responsible for determining the\n appropriateness of using or redistributing the Work and assume any\n risks associated with Your exercise of permissions under this License.\n\n8. Limitation of Liability. In no event and under no legal theory,\n whether in tort (including negligence), contract, or otherwise,\n unless required by applicable law (such as deliberate and grossly\n negligent acts) or agreed to in writing, shall any Contributor be\n liable to You for damages, including any direct, indirect, special,\n incidental, or consequential damages of any character arising as a\n result of this License or out of the use or inability to use the\n Work (including but not limited to damages for loss of goodwill,\n work stoppage, computer failure or malfunction, or any and all\n other commercial damages or losses), even if such Contributor\n has been advised of the possibility of such damages.\n\n9. Accepting Warranty or Additional Liability. While redistributing\n the Work or Derivative Works thereof, You may choose to offer,\n and charge a fee for, acceptance of support, warranty, indemnity,\n or other liability obligations and/or rights consistent with this\n License. However, in accepting such obligations, You may act only\n on Your own behalf and on Your sole responsibility, not on behalf\n of any other Contributor, and only if You agree to indemnify,\n defend, and hold each Contributor harmless for any liability\n incurred by, or claims asserted against, such Contributor by reason\n of your accepting any such warranty or additional liability.\n\nEND OF TERMS AND CONDITIONS\n\nAPPENDIX: How to apply the Apache License to your work.\n\n To apply the Apache License to your work, attach the following\n boilerplate notice, with the fields enclosed by brackets \"[]\"\n replaced with your own identifying information. (Don't include\n the brackets!) The text should be enclosed in the appropriate\n comment syntax for the file format. We also recommend that a\n file or class name and description of purpose be included on the\n same \"printed page\" as the copyright notice for easier\n identification within third-party archives.\n\nCopyright [yyyy] [name of copyright owner]\n\nLicensed under the Apache License, Version 2.0 (the \"License\");\nyou may not use this file except in compliance with the License.\nYou may obtain a copy of the License at\n\n\thttp://www.apache.org/licenses/LICENSE-2.0\n\nUnless required by applicable law or agreed to in writing, software\ndistributed under the License is distributed on an \"AS IS\" BASIS,\nWITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\nSee the License for the specific language governing permissions and\nlimitations under the License.\n"
64476447
- package_name: dogstatsd
6448-
package_version: 16.0.2
6448+
package_version: 16.0.3
64496449
repository: ''
64506450
license: Apache-2.0
64516451
licenses:
@@ -27933,7 +27933,7 @@ third_party_libraries:
2793327933
Portions of ICU4X may have been adapted from ICU4C and/or ICU4J.
2793427934
ICU 1.8.1 to ICU 57.1 © 1995-2016 International Business Machines Corporation and others.
2793527935
- package_name: zstd
27936-
package_version: 0.13.2
27936+
package_version: 0.13.3
2793727937
repository: https://github.com/gyscos/zstd-rs
2793827938
license: MIT
2793927939
licenses:

bottlecap/src/bin/bottlecap/main.rs

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -383,7 +383,8 @@ async fn extension_loop_active(
383383
config.clone(),
384384
tags_provider.clone(),
385385
trace_processor.clone(),
386-
trace_agent_channel.clone()
386+
trace_agent_channel.clone(),
387+
runtime_done_meta.timestamp,
387388
).await;
388389
drop(p);
389390
break 'inner;
@@ -414,6 +415,7 @@ async fn extension_loop_active(
414415
} else if flush_control.should_periodic_flush() {
415416
// Should flush at the top of the invocation, which is now
416417
// flush
418+
//
417419
flush_all(
418420
&logs_flusher,
419421
&mut metrics_flusher,
@@ -457,7 +459,8 @@ async fn extension_loop_active(
457459
config.clone(),
458460
tags_provider.clone(),
459461
trace_processor.clone(),
460-
trace_agent_channel.clone()
462+
trace_agent_channel.clone(),
463+
runtime_done_meta.timestamp,
461464
).await;
462465
drop(p);
463466
}
@@ -507,7 +510,8 @@ async fn extension_loop_active(
507510
config.clone(),
508511
tags_provider.clone(),
509512
trace_processor.clone(),
510-
trace_agent_channel.clone()
513+
trace_agent_channel.clone(),
514+
runtime_done_meta.timestamp,
511515
).await;
512516
drop(p);
513517
}
@@ -561,6 +565,7 @@ struct RuntimeDoneMeta {
561565
request_id: String,
562566
status: Status,
563567
metrics: RuntimeDoneMetrics,
568+
timestamp: i64,
564569
}
565570

566571
async fn handle_event_bus_event(
@@ -571,9 +576,9 @@ async fn handle_event_bus_event(
571576
Event::Metric(event) => {
572577
debug!("Metric event: {:?}", event);
573578
}
574-
Event::OutOfMemory => {
579+
Event::OutOfMemory(event_timestamp) => {
575580
let mut p = invocation_processor.lock().await;
576-
p.on_out_of_memory_error();
581+
p.on_out_of_memory_error(event_timestamp);
577582
drop(p);
578583
}
579584
Event::Telemetry(event) => match event.record {
@@ -589,7 +594,7 @@ async fn handle_event_bus_event(
589594
} => {
590595
debug!("Platform init report for initialization_type: {:?} with phase: {:?} and metrics: {:?}", initialization_type, phase, metrics);
591596
let mut p = invocation_processor.lock().await;
592-
p.on_platform_init_report(metrics.duration_ms);
597+
p.on_platform_init_report(metrics.duration_ms, event.time.timestamp());
593598
drop(p);
594599
}
595600
TelemetryRecord::PlatformStart { request_id, .. } => {
@@ -616,6 +621,7 @@ async fn handle_event_bus_event(
616621
request_id,
617622
status,
618623
metrics,
624+
timestamp: event.time.timestamp(),
619625
});
620626
}
621627
}
@@ -633,7 +639,7 @@ async fn handle_event_bus_event(
633639
error_type.unwrap_or("None".to_string())
634640
);
635641
let mut p = invocation_processor.lock().await;
636-
p.on_platform_report(&request_id, metrics);
642+
p.on_platform_report(&request_id, metrics, event.time.timestamp());
637643
drop(p);
638644
}
639645
_ => {

bottlecap/src/events/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,5 @@ impl MetricEvent {
1919
pub enum Event {
2020
Metric(MetricEvent),
2121
Telemetry(TelemetryEvent),
22-
OutOfMemory,
22+
OutOfMemory(i64),
2323
}

bottlecap/src/lifecycle/flush_control.rs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,13 @@ impl FlushControl {
7676
.as_secs();
7777
match &self.flush_strategy {
7878
FlushStrategy::Default | FlushStrategy::Periodically(_) => {
79-
if now - self.last_flush > (TWENTY_SECONDS / 1000) {
79+
let interval = match &self.flush_strategy {
80+
FlushStrategy::Default => TWENTY_SECONDS,
81+
FlushStrategy::Periodically(strategy) => strategy.interval,
82+
_ => return false,
83+
};
84+
85+
if now - self.last_flush > interval / 1000 {
8086
self.last_flush = now;
8187
true
8288
} else {

0 commit comments

Comments
 (0)