chore: do cargo fmt, check, and clippy only once

Author: apiarian-datadog

.gitlab/datasources/flavors.yaml

@@ -3,7 +3,6 @@ flavors:
     arch: amd64
     alpine: 0
     fips: 0
-    needs_code_checks: true
     needs_layer_publish: true
     suffix: amd64
     layer_name_base_suffix: ""
@@ -14,7 +13,6 @@ flavors:
     arch: arm64
     alpine: 0
     fips: 0
-    needs_code_checks: true
     needs_layer_publish: true
     suffix: arm64
     layer_name_base_suffix: "-ARM"
@@ -25,23 +23,20 @@ flavors:
     arch: amd64
     alpine: 1
     fips: 0
-    needs_code_checks: false
     needs_layer_publish: false
     suffix: amd64-alpine
 
   - name: arm64, alpine
     arch: arm64
     alpine: 1
     fips: 0
-    needs_code_checks: false
     needs_layer_publish: false
     suffix: arm64-alpine
 
   - name: amd64, fips
     arch: amd64
     alpine: 0
     fips: 1
-    needs_code_checks: false
     needs_layer_publish: true
     suffix: amd64-fips
     layer_name_base_suffix: "-FIPS"
@@ -52,7 +47,6 @@ flavors:
     arch: arm64
     alpine: 0
     fips: 1
-    needs_code_checks: false
     needs_layer_publish: true
     suffix: arm64-fips
     layer_name_base_suffix: "-FIPS-ARM"
@@ -63,15 +57,13 @@ flavors:
     arch: amd64
     alpine: 1
     fips: 1
-    needs_code_checks: false
     needs_layer_publish: false
     suffix: amd64-fips-alpine
 
   - name: arm64, fips, alpine
     arch: arm64
     alpine: 1
     fips: 1
-    needs_code_checks: false
     needs_layer_publish: false
     suffix: arm64-fips-alpine
 

.gitlab/templates/pipeline.yaml.tpl

@@ -16,35 +16,31 @@ variables:
   CI_DOCKER_TARGET_IMAGE: registry.ddbuild.io/ci/datadog-lambda-extension
   CI_DOCKER_TARGET_VERSION: latest
 
-{{ range $flavor := (ds "flavors").flavors }}
-
-{{ if $flavor.needs_code_checks }}
-
-cargo fmt ({{ $flavor.arch }}):
+cargo fmt:
   stage: test
-  tags: ["arch:{{ $flavor.arch }}"]
+  tags: ["arch:amd64"]
   image: ${CI_DOCKER_TARGET_IMAGE}:${CI_DOCKER_TARGET_VERSION}
   needs: []
   script:
     - cd bottlecap && cargo fmt
 
-cargo check ({{ $flavor.arch }}):
+cargo check:
   stage: test
-  tags: ["arch:{{ $flavor.arch }}"]
+  tags: ["arch:amd64"]
   image: ${CI_DOCKER_TARGET_IMAGE}:${CI_DOCKER_TARGET_VERSION}
   needs: []
   script:
     - cd bottlecap && cargo check
 
-cargo clippy ({{ $flavor.arch }}):
+cargo clippy:
   stage: test
-  tags: ["arch:{{ $flavor.arch }}"]
+  tags: ["arch:amd64"]
   image: ${CI_DOCKER_TARGET_IMAGE}:${CI_DOCKER_TARGET_VERSION}
   needs: []
   script:
     - cd bottlecap && cargo clippy --all-features
 
-{{ end }} # end needs_code_checks
+{{ range $flavor := (ds "flavors").flavors }}
 
 go agent ({{ $flavor.name }}):
   stage: compile
@@ -92,9 +88,9 @@ layer ({{ $flavor.name }}):
   needs:
     - go agent ({{ $flavor.name }})
     - bottlecap ({{ $flavor.name }})
-    - cargo fmt ({{ $flavor.arch }})
-    - cargo check ({{ $flavor.arch }})
-    - cargo clippy ({{ $flavor.arch }})
+    - cargo fmt
+    - cargo check
+    - cargo clippy
   dependencies:
     - go agent ({{ $flavor.name }})
     - bottlecap ({{ $flavor.name }})