chore: fix upx compression (#583)

* install upx in runner

* remove installation from ci image

* remove compression on compilation

* compile on layer building

Author: duncanista

images/Dockerfile.build_layer

@@ -4,13 +4,26 @@ ARG FILE_SUFFIX
 
 # Install dependencies
 RUN apt-get update
-RUN apt-get install -y zip binutils
+RUN apt-get install -y zip binutils wget tar xz-utils
+
+# UPX installation directly from GitHub
+ENV UPX_VERSION=5.0.0
+RUN ARCH=$(uname -m) && \
+    if [ "$ARCH" = "x86_64" ]; then \
+        ARCH_NAME="amd64"; \
+    elif [ "$ARCH" = "aarch64" ]; then \
+        ARCH_NAME="arm64"; \
+    fi && \
+    wget https://github.com/upx/upx/releases/download/v${UPX_VERSION}/upx-${UPX_VERSION}-${ARCH_NAME}_linux.tar.xz && \
+    tar -xf upx-${UPX_VERSION}-${ARCH_NAME}_linux.tar.xz && \
+    mv upx-${UPX_VERSION}-${ARCH_NAME}_linux/upx /usr/local/bin/ && \
+    rm -rf upx-${UPX_VERSION}-${ARCH_NAME}_linux upx-${UPX_VERSION}-${ARCH_NAME}_linux.tar.xz
 
 # Copy Go Agent binary
 COPY .binaries/datadog-agent-$FILE_SUFFIX /datadog-agent-go
 
-# UPX compress on x86_64
-RUN if [ "$PLATFORM" = "x86_64" ]; then apt-get install -y upx=3.96-r0 && upx -1 /datadog-agent-go; fi
+# UPX compress
+RUN upx -1 /datadog-agent-go
 
 RUN mkdir /extensions
 WORKDIR /extensions

images/Dockerfile.go_agent.alpine.compile

@@ -48,12 +48,6 @@ RUN /usr/lib/go/bin/go tool nm datadog-agent | grep -w 'github.com/DataDog/datad
 # Strip the binary to reduce size
 RUN strip datadog-agent
 
-# Compress the binary with UPX, but only if the architecture is x86_64
-RUN arch="$(uname -m)"; \
-    if [ "${arch}" = 'x86_64' ]; then \
-      apk add --no-cache upx=3.96-r1 && upx -1 datadog-agent; \
-    fi;
-
 # Use the smallest image possible
 FROM scratch
 COPY --from=compiler /tmp/dd/datadog-agent/cmd/serverless/datadog-agent /

images/Dockerfile.go_agent.compile

@@ -50,9 +50,6 @@ RUN /usr/local/go/bin/go tool nm datadog-agent | grep -w 'github.com/DataDog/dat
 # Strip the binary to reduce size
 RUN strip datadog-agent
 
-# Compress the binary with UPX, but only if the architecture is x86_64
-RUN if [ "$arch" = "x86_64" ]; then apt-get install -y upx=3.96-r0 && upx -1 /datadog-agent; fi
-
 # Use the smallest image possible
 FROM scratch
 COPY --from=compiler /tmp/dd/datadog-agent/cmd/serverless/datadog-agent /