Skip to content

Commit 53cba3c

Browse files
authored
fix: remove extra task (#854)
Both the otlp agent and telemetry client themselves spawn tasks, we probably don't need another task to do the spawning.
1 parent 7466374 commit 53cba3c

1 file changed

Lines changed: 6 additions & 10 deletions

File tree

bottlecap/src/bin/bottlecap/main.rs

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1109,11 +1109,9 @@ async fn setup_telemetry_client(
11091109
TelemetryListener::new(EXTENSION_HOST_IP, TELEMETRY_PORT, logs_agent_channel);
11101110

11111111
let cancel_token = telemetry_listener.cancel_token();
1112-
tokio::spawn(async move {
1113-
if let Err(e) = telemetry_listener.start() {
1114-
error!("Error starting telemetry listener: {e:?}");
1115-
}
1116-
});
1112+
if let Err(e) = telemetry_listener.start() {
1113+
error!("Error starting telemetry listener: {e:?}");
1114+
}
11171115

11181116
telemetry::subscribe(
11191117
client,
@@ -1140,11 +1138,9 @@ fn start_otlp_agent(
11401138

11411139
let agent = OtlpAgent::new(config.clone(), tags_provider, trace_processor, trace_tx);
11421140
let cancel_token = agent.cancel_token();
1143-
tokio::spawn(async move {
1144-
if let Err(e) = agent.start() {
1145-
error!("Error starting OTLP agent: {e:?}");
1146-
}
1147-
});
1141+
if let Err(e) = agent.start() {
1142+
error!("Error starting OTLP agent: {e:?}");
1143+
}
11481144

11491145
Some(cancel_token)
11501146
}

0 commit comments

Comments
 (0)