Skip to content

Commit 6b30126

Browse files
committed
Add comment
1 parent b7384dd commit 6b30126

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

bottlecap/src/traces/span_dedup_service.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,9 @@ impl DedupHandle {
4545
.send(DedupCommand::CheckAndAdd(key, response_tx))
4646
.map_err(DedupError::SendError)?;
4747

48+
// Sometimes the dedup service fails to send a response for unknown reasons, so we
49+
// timeout after 5 seconds to avoid blocking the caller forever. We may remove the
50+
// timeout if we can figure out and fix the root cause.
4851
tokio::time::timeout(Duration::from_secs(5), response_rx)
4952
.await
5053
.map_err(|_| DedupError::Timeout)?

0 commit comments

Comments
 (0)