fix(deps): upgrade libdatadog (#1039)

## Overview

- Upgrade libdatadog dependencies from 158b594 to c8121f4 (v28),
adapting to upstream API changes (hyper_migration → http_common,
HyperClient → HttpClient, new use_system_resolver field on Endpoint,
SendData no
  longer Clone)
- Rename hyper_client module to http_client to match the upstream naming
change
- Fix dual-shipping to additional endpoints: previously
TracerHeaderTags::default() was used (losing all tracer metadata headers
like datadog-meta-lang, datadog-meta-tracer-version, etc.). Now the real
header
tags are preserved through the aggregation pipeline and used for
additional endpoints
- Avoid unnecessary full TracerPayloadCollection clone in
trace_processor by only cloning inner V07 payloads for stats generation

## Changes

  - Bump all libdd-* crates to rev c8121f4 in Cargo.toml / Cargo.lock
- Adapt to hyper_migration → http_common rename across trace_agent,
stats_processor, stats_flusher, and http_client
- Add use_system_resolver: false to all Endpoint constructions (new
required field)

  hyper_client.rs → http_client.rs

  - Rename module and type alias (HyperClient → HttpClient)
  - Update all consumers (trace_flusher, stats_flusher, mod.rs)

  Trace flusher refactor

- Adapt to SendData no longer being Clone: construct per-endpoint
SendData objects by cloning inner V07 payloads instead of cloning the
whole SendData
- Remove override_endpoint parameter from send_traces — each SendData
now carries its own target endpoint
- Simplify retry logic comments (endpoint tracking is no longer
relevant)

  Preserve TracerHeaderTags for additional endpoints

- Introduce OwnedTracerHeaderTags — an owned version of
TracerHeaderTags<'a> that can be stored across async boundaries
- Add header_tags field to SendDataBuilderInfo and thread it through the
aggregation pipeline
- Use real header tags (via to_tracer_header_tags()) when constructing
SendData for additional endpoints instead of TracerHeaderTags::default()

  Trace processor optimization

- Clone only inner V07 payloads for stats generation instead of cloning
the entire TracerPayloadCollection before building SendData

##  Tests
  - cargo check passes
  - cargo test --lib passes (481 tests)
- Verify dual-shipped traces to additional endpoints include correct
datadog-meta-* headers with DD_APM_ADDITIONAL_ENDPOINTS configured

Author: duncanista

bottlecap/Cargo.lock

@@ -67,12 +67,12 @@ indexmap = {version = "2.11.0", default-features = false}
 # be found in the clippy.toml file adjacent to this Cargo.toml.
 datadog-protos = { version = "0.1.0", default-features = false, git = "https://github.com/DataDog/saluki/", rev = "f863626dbfe3c59bb390985fa6530b0621c2a0a2"}
 ddsketch-agent = { version = "0.1.0", default-features = false, git = "https://github.com/DataDog/saluki/", rev = "f863626dbfe3c59bb390985fa6530b0621c2a0a2"}
-libdd-common = { git = "https://github.com/DataDog/libdatadog", rev = "158b59471f1132e3cb36023fa3c46ccb2dd0eda1" }
-libdd-trace-protobuf = { git = "https://github.com/DataDog/libdatadog", rev = "158b59471f1132e3cb36023fa3c46ccb2dd0eda1"  }
-libdd-trace-utils = { git = "https://github.com/DataDog/libdatadog", rev = "158b59471f1132e3cb36023fa3c46ccb2dd0eda1" , features = ["mini_agent"] }
-libdd-trace-normalization = { git = "https://github.com/DataDog/libdatadog",  rev = "158b59471f1132e3cb36023fa3c46ccb2dd0eda1" }
-libdd-trace-obfuscation = { git = "https://github.com/DataDog/libdatadog", rev = "158b59471f1132e3cb36023fa3c46ccb2dd0eda1"  }
-libdd-trace-stats = { git = "https://github.com/DataDog/libdatadog", rev = "158b59471f1132e3cb36023fa3c46ccb2dd0eda1"  }
+libdd-common = { git = "https://github.com/DataDog/libdatadog", rev = "c8121f422d2c8d219f8d421ff3cdb1fcbe9e8b09" }
+libdd-trace-protobuf = { git = "https://github.com/DataDog/libdatadog", rev = "c8121f422d2c8d219f8d421ff3cdb1fcbe9e8b09"  }
+libdd-trace-utils = { git = "https://github.com/DataDog/libdatadog", rev = "c8121f422d2c8d219f8d421ff3cdb1fcbe9e8b09" , features = ["mini_agent"] }
+libdd-trace-normalization = { git = "https://github.com/DataDog/libdatadog",  rev = "c8121f422d2c8d219f8d421ff3cdb1fcbe9e8b09" }
+libdd-trace-obfuscation = { git = "https://github.com/DataDog/libdatadog", rev = "c8121f422d2c8d219f8d421ff3cdb1fcbe9e8b09"  }
+libdd-trace-stats = { git = "https://github.com/DataDog/libdatadog", rev = "c8121f422d2c8d219f8d421ff3cdb1fcbe9e8b09"  }
 dogstatsd = { git = "https://github.com/DataDog/serverless-components", rev = "2eb009a59ed07ffcaf174db1c31af413365e9bc6", default-features = false }
 datadog-fips = { git = "https://github.com/DataDog/serverless-components", rev = "2eb009a59ed07ffcaf174db1c31af413365e9bc6", default-features = false }
 libddwaf = { version = "1.28.1", git = "https://github.com/DataDog/libddwaf-rust", rev = "d1534a158d976bd4f747bf9fcc58e0712d2d17fc", default-features = false, features = ["serde"] }

bottlecap/Cargo.toml

@@ -1,14 +1,14 @@
 // Copyright 2023-Present Datadog, Inc. https://www.datadoghq.com/
 // SPDX-License-Identifier: Apache-2.0
 
-//! Hyper-based HTTP client for trace and stats flushers.
+//! HTTP client for trace and stats flushers.
 //!
 //! This module provides the HTTP client type required by `libdd_trace_utils`
 //! for sending traces and stats to Datadog intake endpoints.
 
 use hyper_http_proxy;
 use hyper_rustls::HttpsConnectorBuilder;
-use libdd_common::{GenericHttpClient, hyper_migration};
+use libdd_common::{GenericHttpClient, http_common};
 use rustls::RootCertStore;
 use rustls_pki_types::CertificateDer;
 use std::error::Error;
@@ -20,7 +20,7 @@ use tracing::debug;
 /// Type alias for the HTTP client used by trace and stats flushers.
 ///
 /// This is the client type expected by `libdd_trace_utils::SendData::send()`.
-pub type HyperClient =
+pub type HttpClient =
     GenericHttpClient<hyper_http_proxy::ProxyConnector<libdd_common::connector::Connector>>;
 
 /// Initialize the crypto provider needed for setting custom root certificates.
@@ -35,7 +35,7 @@ fn ensure_crypto_provider_initialized() {
     let () = &*INIT_CRYPTO_PROVIDER;
 }
 
-/// Creates a new hyper-based HTTP client with the given configuration.
+/// Creates a new HTTP client with the given configuration.
 ///
 /// This client is compatible with `libdd_trace_utils` and supports:
 /// - HTTPS proxy configuration
@@ -54,7 +54,7 @@ fn ensure_crypto_provider_initialized() {
 pub fn create_client(
     proxy_https: Option<&String>,
     tls_cert_file: Option<&String>,
-) -> Result<HyperClient, Box<dyn Error>> {
+) -> Result<HttpClient, Box<dyn Error>> {
     // Create the base connector with optional custom TLS config
     let connector = if let Some(ca_cert_path) = tls_cert_file {
         // Ensure crypto provider is initialized before creating TLS config
@@ -84,10 +84,7 @@ pub fn create_client(
             .enable_http1()
             .build();
 
-        debug!(
-            "HYPER_CLIENT | Added root certificate from {}",
-            ca_cert_path
-        );
+        debug!("HTTP_CLIENT | Added root certificate from {}", ca_cert_path);
 
         // Construct the Connector::Https variant directly
         libdd_common::connector::Connector::Https(https_connector)
@@ -100,14 +97,14 @@ pub fn create_client(
         let proxy =
             hyper_http_proxy::Proxy::new(hyper_http_proxy::Intercept::Https, proxy.parse()?);
         let proxy_connector = hyper_http_proxy::ProxyConnector::from_proxy(connector, proxy)?;
-        let client = hyper_migration::client_builder().build(proxy_connector);
+        let client = http_common::client_builder().build(proxy_connector);
         debug!(
-            "HYPER_CLIENT | Proxy connector created with proxy: {:?}",
+            "HTTP_CLIENT | Proxy connector created with proxy: {:?}",
             proxy_https
         );
         Ok(client)
     } else {
         let proxy_connector = hyper_http_proxy::ProxyConnector::new(connector)?;
-        Ok(hyper_migration::client_builder().build(proxy_connector))
+        Ok(http_common::client_builder().build(proxy_connector))
     }
 }

bottlecap/src/traces/hyper_client.rs bottlecap/src/traces/http_client.rsbottlecap/src/traces/hyper_client.rs renamed to bottlecap/src/traces/http_client.rs

@@ -2,7 +2,7 @@
 // SPDX-License-Identifier: Apache-2.0
 
 pub mod context;
-pub mod hyper_client;
+pub mod http_client;
 pub mod propagation;
 pub mod proxy_aggregator;
 pub mod proxy_flusher;

bottlecap/src/traces/mod.rs

@@ -8,7 +8,7 @@ use tokio::sync::OnceCell;
 
 use crate::config;
 use crate::lifecycle::invocation::processor::S_TO_MS;
-use crate::traces::hyper_client::{self, HyperClient};
+use crate::traces::http_client::{self, HttpClient};
 use crate::traces::stats_aggregator::StatsAggregator;
 use dogstatsd::api_key::ApiKeyFactory;
 use libdd_common::Endpoint;
@@ -24,7 +24,7 @@ pub struct StatsFlusher {
     /// Cached HTTP client, lazily initialized on first use.
     /// TODO: `StatsFlusher` and `TraceFlusher` both hit trace.agent.datadoghq.{site} and could
     /// share a single HTTP client for better connection pooling.
-    http_client: OnceCell<HyperClient>,
+    http_client: OnceCell<HttpClient>,
 }
 
 impl StatsFlusher {
@@ -72,6 +72,7 @@ impl StatsFlusher {
                         api_key: Some(api_key_clone.into()),
                         timeout_ms: self.config.flush_timeout * S_TO_MS,
                         test_token: None,
+                        use_system_resolver: false,
                     }
                 }
             })
@@ -176,11 +177,11 @@ impl StatsFlusher {
     ///
     /// Returns `None` if client creation fails. The error is logged but not cached,
     /// allowing retry on subsequent calls.
-    async fn get_or_init_http_client(&self) -> Option<&HyperClient> {
+    async fn get_or_init_http_client(&self) -> Option<&HttpClient> {
         match self
             .http_client
             .get_or_try_init(|| async {
-                hyper_client::create_client(
+                http_client::create_client(
                     self.config.proxy_https.as_ref(),
                     self.config.tls_cert_file.as_ref(),
                 )

bottlecap/src/traces/stats_flusher.rs

@@ -12,12 +12,12 @@ use axum::{
 use tokio::sync::mpsc::Sender;
 use tracing::{debug, error};
 
-use libdd_common::hyper_migration;
+use libdd_common::http_common;
 use libdd_trace_protobuf::pb;
 use libdd_trace_utils::stats_utils;
 
-use super::trace_agent::MAX_CONTENT_LENGTH;
 use crate::http::extract_request_body;
+use crate::traces::trace_agent::MAX_CONTENT_LENGTH;
 
 #[async_trait]
 pub trait StatsProcessor {
@@ -66,7 +66,7 @@ impl StatsProcessor for ServerlessStatsProcessor {
         // deserialize trace stats from the request body, convert to protobuf structs (see
         // trace-protobuf crate)
         let mut stats: pb::ClientStatsPayload =
-            match stats_utils::get_stats_from_request_body(hyper_migration::Body::from_bytes(body))
+            match stats_utils::get_stats_from_request_body(http_common::Body::from_bytes(body))
                 .await
             {
                 Ok(result) => result,

bottlecap/src/traces/stats_processor.rs

@@ -43,7 +43,7 @@ use crate::{
         trace_processor,
     },
 };
-use libdd_common::hyper_migration;
+use libdd_common::http_common;
 use libdd_trace_protobuf::pb;
 use libdd_trace_utils::trace_utils::{self};
 
@@ -503,22 +503,22 @@ impl TraceAgent {
 
         let tracer_header_tags = (&parts.headers).into();
 
-        let (body_size, mut traces) = match version {
-            ApiVersion::V04 => match trace_utils::get_traces_from_request_body(
-                hyper_migration::Body::from_bytes(body),
-            )
-            .await
-            {
-                Ok(result) => result,
-                Err(err) => {
-                    return error_response(
-                        StatusCode::INTERNAL_SERVER_ERROR,
-                        format!("Error deserializing trace from request body: {err}"),
-                    );
+        let (body_size, mut traces): (usize, Vec<Vec<pb::Span>>) = match version {
+            ApiVersion::V04 => {
+                match trace_utils::get_traces_from_request_body(http_common::Body::from_bytes(body))
+                    .await
+                {
+                    Ok(result) => result,
+                    Err(err) => {
+                        return error_response(
+                            StatusCode::INTERNAL_SERVER_ERROR,
+                            format!("Error deserializing trace from request body: {err}"),
+                        );
+                    }
                 }
-            },
+            }
             ApiVersion::V05 => match trace_utils::get_v05_traces_from_request_body(
-                hyper_migration::Body::from_bytes(body),
+                http_common::Body::from_bytes(body),
             )
             .await
             {