Skip to content

Commit 6e75acf

Browse files
authored
fix: pin rustls-native-certs to <0.8.3 (#1047)
## Overview Regression on performance because `openssl-probe@0.2` checks for multiple folders as opposed to only one ## Testing Manual testing in AWS Lambda and Self Monitoring Data
1 parent 663d891 commit 6e75acf

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

bottlecap/Cargo.lock

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

bottlecap/Cargo.toml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,10 @@ serde-aux = { version = "4.7", default-features = false }
5252
serde_html_form = { version = "0.2", default-features = false }
5353
opentelemetry-proto = { version = "0.30.0", features = ["trace", "with-serde", "gen-tonic"] }
5454
opentelemetry-semantic-conventions = { version = "0.30", features = ["semconv_experimental"] }
55-
rustls-native-certs = { version = "0.8.1", optional = true }
55+
# Pinned to <0.8.3: version 0.8.3 upgraded to openssl-probe 0.2.x which scans all cert
56+
# directories and parses ~200 individual cert files on Lambda instead of loading a single
57+
# bundle file, adding ~45ms to each reqwest::Client::build() call.
58+
rustls-native-certs = { version = ">=0.8.1, <0.8.3", optional = true }
5659
axum = { version = "0.8.4", default-features = false, features = ["default"] }
5760
ustr = { version = "1.0.0", default-features = false }
5861
tower-http = { version = "0.6.6", default-features = false, features = ["limit"] }

bottlecap/LICENSE-3rdparty.csv

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ nix,https://github.com/nix-rust/nix,MIT,The nix-rust Project Developers
123123
num-conv,https://github.com/jhpratt/num-conv,MIT OR Apache-2.0,Jacob Pratt <jacob@jhpratt.dev>
124124
num-traits,https://github.com/rust-num/num-traits,MIT OR Apache-2.0,The Rust Project Developers
125125
once_cell,https://github.com/matklad/once_cell,MIT OR Apache-2.0,Aleksey Kladov <aleksey.kladov@gmail.com>
126-
openssl-probe,https://github.com/rustls/openssl-probe,MIT OR Apache-2.0,Alex Crichton <alex@alexcrichton.com>
126+
openssl-probe,https://github.com/alexcrichton/openssl-probe,MIT OR Apache-2.0,Alex Crichton <alex@alexcrichton.com>
127127
opentelemetry,https://github.com/open-telemetry/opentelemetry-rust/tree/main/opentelemetry,Apache-2.0,The opentelemetry Authors
128128
opentelemetry-proto,https://github.com/open-telemetry/opentelemetry-rust/tree/main/opentelemetry-proto,Apache-2.0,The opentelemetry-proto Authors
129129
opentelemetry-semantic-conventions,https://github.com/open-telemetry/opentelemetry-rust/tree/main/opentelemetry-semantic-conventions,Apache-2.0,The opentelemetry-semantic-conventions Authors

0 commit comments

Comments
 (0)