Refactor OTLP response-validation test to match other OTLP tests

- Invoke response-validation Lambda in beforeAll alongside other OTLP lambdas
- Use shared results object instead of separate Lambda invocation
- Split assertions into individual it() blocks for better test reporting
- Remove unused imports (LambdaClient, InvokeCommand, getTraces)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: jchrostek-dd

integration-tests/tests/otlp.test.ts

@@ -1,7 +1,5 @@
 import { invokeLambdaAndGetDatadogData, LambdaInvocationDatadogData, DATADOG_INDEXING_WAIT_5_MIN_MS } from './utils/util';
-import { getTraces } from './utils/datadog';
 import { getIdentifier } from '../config';
-import { LambdaClient, InvokeCommand } from '@aws-sdk/client-lambda';
 
 describe('OTLP Integration Tests', () => {
   const results: Record<string, LambdaInvocationDatadogData> = {};
@@ -13,6 +11,7 @@ describe('OTLP Integration Tests', () => {
       python: `integ-${identifier}-otlp-python-lambda`,
       java: `integ-${identifier}-otlp-java-lambda`,
       dotnet: `integ-${identifier}-otlp-dotnet-lambda`,
+      responseValidation: `integ-${identifier}-otlp-response-validation-lambda`,
     };
 
     console.log('Invoking all OTLP Lambda functions in parallel...');
@@ -23,13 +22,15 @@ describe('OTLP Integration Tests', () => {
       invokeLambdaAndGetDatadogData(functions.python, {}, true, true, DATADOG_INDEXING_WAIT_5_MIN_MS),
       invokeLambdaAndGetDatadogData(functions.java, {}, true, true, DATADOG_INDEXING_WAIT_5_MIN_MS),
       invokeLambdaAndGetDatadogData(functions.dotnet, {}, true, true, DATADOG_INDEXING_WAIT_5_MIN_MS),
+      invokeLambdaAndGetDatadogData(functions.responseValidation, {}, true, true, DATADOG_INDEXING_WAIT_5_MIN_MS),
     ]);
 
     // Store results
     results.node = invocationResults[0];
     results.python = invocationResults[1];
     results.java = invocationResults[2];
     results.dotnet = invocationResults[3];
+    results.responseValidation = invocationResults[4];
 
     console.log('All OTLP Lambda invocations and data fetching completed');
   }, 700000); // 11.6 minute timeout
@@ -94,66 +95,54 @@ describe('OTLP Integration Tests', () => {
     });
   });
 
-  describe('OTLP Response Validation', () => {
-    const lambdaClient = new LambdaClient({ region: 'us-east-1' });
-    const identifier = getIdentifier();
-    const functionName = `integ-${identifier}-otlp-response-validation-lambda`;
-
-    // This test validates SVLS-8626: JSON encoding support for OTLP traces
-    // The Lambda uses the OpenTelemetry SDK to send spans via both JSON and Protobuf
-    // encodings, then we verify both were accepted and reached Datadog
-    it('should handle both protobuf and JSON encodings and send spans to Datadog', async () => {
-      console.log(`Invoking ${functionName}...`);
-
-      const command = new InvokeCommand({
-        FunctionName: functionName,
-        Payload: Buffer.from(JSON.stringify({})),
-      });
-
-      const response = await lambdaClient.send(command);
-
-      expect(response.StatusCode).toBe(200);
-      expect(response.FunctionError).toBeUndefined();
-
-      const payload = JSON.parse(Buffer.from(response.Payload!).toString());
-      const validationResult = JSON.parse(payload.body);
+  // This test validates SVLS-8626: JSON encoding support for OTLP traces
+  // The Lambda uses the OpenTelemetry SDK to send spans via both JSON and Protobuf
+  // encodings, then we verify both were accepted and reached Datadog
+  describe('OTLP Response Validation (SVLS-8626)', () => {
+    it('should invoke response-validation Lambda successfully', () => {
+      expect(results.responseValidation.statusCode).toBe(200);
+    });
 
-      console.log('Validation result:', JSON.stringify(validationResult, null, 2));
+    it('should accept JSON encoded OTLP traces', () => {
+      const body = JSON.parse(results.responseValidation.payload?.body || '{}');
+      expect(body.json?.success).toBe(true);
+    });
 
-      // Both encodings should be accepted by the extension
-      expect(validationResult.success).toBe(true);
-      expect(validationResult.json.success).toBe(true);
-      expect(validationResult.protobuf.success).toBe(true);
+    it('should accept Protobuf encoded OTLP traces', () => {
+      const body = JSON.parse(results.responseValidation.payload?.body || '{}');
+      expect(body.protobuf?.success).toBe(true);
+    });
 
-      // Wait for spans to be indexed in Datadog (60s is typically enough)
-      const requestId = validationResult.requestId;
-      console.log(`Request ID: ${requestId}`);
-      console.log('Waiting 60s for spans to be indexed in Datadog...');
-      await new Promise(resolve => setTimeout(resolve, 60000));
+    it('should send at least one trace to Datadog', () => {
+      expect(results.responseValidation.traces?.length).toBeGreaterThan(0);
+    });
 
-      // Query Datadog for the spans by service name (no request_id filter - nested attribute)
-      const traces = await getTraces(functionName);
-      const allSpans = traces.flatMap(t => t.spans);
-      console.log(`Total spans in Datadog: ${allSpans.length}`);
+    it('should have JSON encoded span in Datadog', () => {
+      const body = JSON.parse(results.responseValidation.payload?.body || '{}');
+      const requestId = body.requestId;
+      const allSpans = results.responseValidation.traces?.flatMap(t => t.spans) || [];
 
       // Filter by request_id from this invocation (at custom.request_id path)
       const currentRunSpans = allSpans.filter(s => s.attributes?.custom?.request_id === requestId);
-      console.log(`Spans from this invocation (request_id=${requestId}): ${currentRunSpans.length}`);
 
-      // Verify we have spans from this invocation
-      expect(currentRunSpans.length).toBeGreaterThanOrEqual(2);
-
-      // Verify we have both JSON and Protobuf encoded spans
       const hasJsonSpan = currentRunSpans.some(s =>
         s.attributes?.resource_name === 'test-span-json' && s.attributes?.custom?.encoding === 'json'
       );
+      expect(hasJsonSpan).toBe(true);
+    });
+
+    it('should have Protobuf encoded span in Datadog', () => {
+      const body = JSON.parse(results.responseValidation.payload?.body || '{}');
+      const requestId = body.requestId;
+      const allSpans = results.responseValidation.traces?.flatMap(t => t.spans) || [];
+
+      // Filter by request_id from this invocation (at custom.request_id path)
+      const currentRunSpans = allSpans.filter(s => s.attributes?.custom?.request_id === requestId);
+
       const hasProtobufSpan = currentRunSpans.some(s =>
         s.attributes?.resource_name === 'test-span-protobuf' && s.attributes?.custom?.encoding === 'protobuf'
       );
-
-      console.log(`Has JSON span: ${hasJsonSpan}, Has Protobuf span: ${hasProtobufSpan}`);
-      expect(hasJsonSpan).toBe(true);
       expect(hasProtobufSpan).toBe(true);
-    }, 120000); // 2 minute timeout
+    });
   });
 });