chore: environments make more sense as objects instead of a list

Author: apiarian-datadog

.gitlab/datasources/environments.yaml

@@ -1,11 +1,11 @@
 environments:
-  - name: sandbox
+  sandbox:
     external_id: sandbox-publish-externalid
     role_to_assume: sandbox-layer-deployer
     account: 425362996713
     add_layer_version_permissions: 0
     automatically_bump_version: 1
-  - name: prod
+  prod:
     external_id: prod-publish-externalid
     role_to_assume: dd-serverless-layer-deployer-role
     account: 464622532012

.gitlab/templates/pipeline.yaml.tpl

@@ -126,9 +126,9 @@ check layer size ({{ $flavor.name }}):
   script:
     - .gitlab/scripts/check_layer_size.sh
 
-{{ range $environment := (ds "environments").environments }}
+{{ range $environment_name, $environment := (ds "environments").environments }}
 
-{{ if eq $environment.name "prod" }}
+{{ if eq $environment_name "prod" }}
 
 sign layer ({{ $flavor.name }}):
   stage: sign
@@ -151,30 +151,30 @@ sign layer ({{ $flavor.name }}):
   before_script:
     - EXTERNAL_ID_NAME={{ $environment.external_id }} ROLE_TO_ASSUME={{ $environment.role_to_assume }} AWS_ACCOUNT={{ $environment.account }} source .gitlab/scripts/get_secrets.sh
   script:
-    - .gitlab/scripts/sign_layers.sh {{ $environment.name }}
+    - .gitlab/scripts/sign_layers.sh {{ $environment_name }}
 
 {{ end }} # if prod
 
-publish layer {{ $environment.name }} ({{ $flavor.name }}):
+publish layer {{ $environment_name }} ({{ $flavor.name }}):
   stage: publish
   tags: ["arch:amd64"]
   image: ${CI_DOCKER_TARGET_IMAGE}:${CI_DOCKER_TARGET_VERSION}
   rules:
-    - if: '"{{ $environment.name }}" == "sandbox"'
+    - if: '"{{ $environment_name }}" == "sandbox"'
       when: manual
       allow_failure: true
     - if: '$CI_COMMIT_TAG =~ /^v.*/'
 
   needs:
-{{ if eq $environment.name "prod" }}
+{{ if eq $environment_name "prod" }}
     - check layer size ({{ $flavor.name }})
     - sign layer ({{ $flavor.name }})
 {{ else }}
     - layer ({{ $flavor.name }})
 {{ end }} #end if prod
 
   dependencies:
-{{ if or (eq $environment.name "prod") }}
+{{ if or (eq $environment_name "prod") }}
       - sign layer ({{ $flavor.name }})
 {{ else }}
       - layer ({{ $flavor.name }})
@@ -196,7 +196,7 @@ publish layer {{ $environment.name }} ({{ $flavor.name }}):
   script:
     - .gitlab/scripts/publish_layer.sh
 
-{{ if eq $environment.name "sandbox" }}
+{{ if eq $environment_name "sandbox" }}
 
 publish layer sandbox [us-east-1] ({{ $flavor.name }}):
   stage: self-monitoring
@@ -234,9 +234,9 @@ publish layer sandbox [us-east-1] ({{ $flavor.name }}):
 
 {{ range $multi_arch_image_flavor := (ds "flavors").multi_arch_image_flavors }}
 
-{{ range $environment := (ds "environments").environments }}
+{{ range $environment_name, $environment := (ds "environments").environments }}
 
-{{ if eq $environment.name "sandbox" }}
+{{ if eq $environment_name "sandbox" }}
 
 publish private images ({{ $multi_arch_image_flavor.name }}):
   stage: self-monitoring
@@ -304,35 +304,35 @@ publish image ({{ $multi_arch_image_flavor.name }}):
 
 {{ end }} # end multi_arch_image_flavors
 
-{{ range $environment := (ds "environments").environments }}
+{{ range $environment_name, $environment := (ds "environments").environments }}
 
-{{ if eq $environment.name "prod" }}signed {{ end }}layer bundle:
-  stage: {{ if eq $environment.name "prod" }}sign{{ else }}build{{ end }}
+{{ if eq $environment_name "prod" }}signed {{ end }}layer bundle:
+  stage: {{ if eq $environment_name "prod" }}sign{{ else }}build{{ end }}
   image: registry.ddbuild.io/images/docker:20.10
   tags: ["arch:amd64"]
   rules:
-    - if: '"{{ $environment.name }}" == "sandbox"'
+    - if: '"{{ $environment_name }}" == "sandbox"'
     - if: '$CI_COMMIT_TAG =~ /^v.*/'
   needs:
     {{ range (ds "flavors").flavors }}
     {{ if .needs_layer_publish }}
-    - {{ if eq $environment.name "prod" }}sign {{ end }}layer ({{ .name }})
+    - {{ if eq $environment_name "prod" }}sign {{ end }}layer ({{ .name }})
     {{ end }} # end needs_layer_publish
     {{ end }} # end flavors
   dependencies:
     {{ range (ds "flavors").flavors }}
     {{ if .needs_layer_publish }}
-    - {{ if eq $environment.name "prod" }}sign {{ end }}layer ({{ .name }})
+    - {{ if eq $environment_name "prod" }}sign {{ end }}layer ({{ .name }})
     {{ end }} # end needs_layer_publish
     {{ end }} # end flavors
   artifacts:
-    expire_in: {{ if eq $environment.name "prod" }}1 day{{ else }}1 hr{{ end }}
+    expire_in: {{ if eq $environment_name "prod" }}1 day{{ else }}1 hr{{ end }}
     paths:
-      - datadog_extension-{{ if eq $environment.name "prod"}}signed-{{ end }}bundle-${CI_JOB_ID}/
-    name: datadog_extension-{{ if eq $environment.name "prod"}}signed-{{ end }}bundle-${CI_JOB_ID}
+      - datadog_extension-{{ if eq $environment_name "prod"}}signed-{{ end }}bundle-${CI_JOB_ID}/
+    name: datadog_extension-{{ if eq $environment_name "prod"}}signed-{{ end }}bundle-${CI_JOB_ID}
   script:
-    - rm -rf datadog_extension-{{ if eq $environment.name "prod"}}signed-{{ end }}bundle-${CI_JOB_ID}
-    - mkdir -p datadog_extension-{{ if eq $environment.name "prod"}}signed-{{ end }}bundle-${CI_JOB_ID}
-    - cp .layers/datadog_extension-*.zip datadog_extension-{{ if eq $environment.name "prod"}}signed-{{ end }}bundle-${CI_JOB_ID}
+    - rm -rf datadog_extension-{{ if eq $environment_name "prod"}}signed-{{ end }}bundle-${CI_JOB_ID}
+    - mkdir -p datadog_extension-{{ if eq $environment_name "prod"}}signed-{{ end }}bundle-${CI_JOB_ID}
+    - cp .layers/datadog_extension-*.zip datadog_extension-{{ if eq $environment_name "prod"}}signed-{{ end }}bundle-${CI_JOB_ID}
 
 {{ end }} # end environments