Remove low-value comments

Author: jchrostek-dd

integration-tests/tests/on-demand.test.ts

@@ -18,12 +18,8 @@ describe('On-Demand Integration Tests', () => {
       runtime,
     }));
 
-    // Force cold starts
     await Promise.all(functions.map(fn => forceColdStart(fn.functionName)));
 
-    // Add 5s delay between invocations to ensure warm container is reused
-    // Required because there is post-runtime processing with 'end' flush strategy
-    // invokeAndCollectTelemetry now returns DatadogTelemetry with metrics included
     telemetry = await invokeAndCollectTelemetry(functions, 2, 1, 5000);
 
     console.log('All invocations and data fetching completed');
@@ -76,7 +72,6 @@ describe('On-Demand Integration Tests', () => {
         });
       });
 
-      // Python has known issues with cold_start spans - mark as failing
       if (runtime === 'python') {
         it.failing('[failing] should have aws.lambda.cold_start span', () => {
           const result = getFirstInvocation();
@@ -154,8 +149,6 @@ describe('On-Demand Integration Tests', () => {
       });
     });
 
-    // All duration metrics tests are skipped - metrics indexing is unreliable
-    // TODO: Investigate why Datadog metrics API returns inconsistent results
     describe.skip('duration metrics', () => {
       it('should emit aws.lambda.enhanced.runtime_duration', () => {
         const points = getTelemetry().metrics.duration['runtime_duration'];
@@ -181,7 +174,6 @@ describe('On-Demand Integration Tests', () => {
         expect(points[points.length - 1].value).toBeGreaterThanOrEqual(0);
       });
 
-      // First invocation is a forced cold start, so init_duration should be emitted
       it('should emit aws.lambda.enhanced.init_duration for cold start', () => {
         const points = getTelemetry().metrics.duration['init_duration'];
         expect(points.length).toBeGreaterThan(0);

integration-tests/tests/utils/datadog.ts

@@ -133,16 +133,14 @@ export async function getTraces(
   requestId: string,
 ): Promise<DatadogTrace[]> {
   const now = Date.now();
-  const fromTime = now - (1 * 60 * 60 * 1000); // 1 hour ago
+  const fromTime = now - (1 * 60 * 60 * 1000);
   const toTime = now;
-  // Convert service name to lowercase as Datadog stores it that way
   const serviceNameLower = serviceName.toLowerCase();
   const query = `service:${serviceNameLower} @request_id:${requestId}`;
 
   try {
     console.log(`Searching for traces: ${query}`);
 
-    // First, find spans matching the request_id to get trace IDs
     const initialResponse = await datadogClient.post('/api/v2/spans/events/search', {
       data: {
         type: 'search_request',
@@ -163,7 +161,6 @@ export async function getTraces(
     const initialSpans = initialResponse.data.data || [];
     console.log(`Found ${initialSpans.length} initial span(s)`);
 
-    // Extract unique trace IDs
     const traceIds = new Set<string>();
     for (const spanData of initialSpans) {
       const traceId = spanData.attributes?.trace_id;
@@ -174,7 +171,6 @@ export async function getTraces(
 
     console.log(`Found ${traceIds.size} unique trace(s)`);
 
-    // Now fetch all spans for each trace ID
     const allSpans: any[] = [];
     for (const traceId of traceIds) {
       const traceResponse = await datadogClient.post('/api/v2/spans/events/search', {
@@ -197,7 +193,6 @@ export async function getTraces(
       allSpans.push(...traceSpans);
     }
 
-    // Group spans by trace_id to reconstruct traces
     const traceMap = new Map<string, DatadogSpan[]>();
 
     for (const spanData of allSpans) {
@@ -216,7 +211,6 @@ export async function getTraces(
       }
     }
 
-    // Convert map to array of traces
     const traces: DatadogTrace[] = [];
     for (const [traceId, spans] of traceMap.entries()) {
       traces.push({
@@ -242,7 +236,7 @@ export async function getLogs(
   requestId: string,
 ): Promise<DatadogLog[]> {
   const now = Date.now();
-  const fromTime = now - (2 * 60 * 60 * 1000); // 2 hours ago
+  const fromTime = now - (2 * 60 * 60 * 1000);
   const toTime = now;
   const query = `service:${serviceName} @lambda.request_id:${requestId}`;
 
@@ -263,7 +257,6 @@ export async function getLogs(
     const rawLogs = response.data.data || [];
     console.log(`Found ${rawLogs.length} log(s)`);
 
-    // Transform raw logs to DatadogLog format
     const logs: DatadogLog[] = rawLogs.map((logData: any) => {
       const attrs = logData.attributes || {};
       return {
@@ -292,7 +285,6 @@ export async function getEnhancedMetrics(
 ): Promise<EnhancedMetrics> {
   const result: Partial<EnhancedMetrics> = {};
 
-  // Fetch all categories in parallel
   const categoryPromises = Object.entries(ENHANCED_METRICS_CONFIG).map(
     async ([category, metricNames]) => {
       const categoryMetrics = await fetchMetricCategory(
@@ -325,7 +317,6 @@ async function fetchMetricCategory(
 ): Promise<Record<string, MetricPoint[]>> {
   const promises = metricNames.map(async (metricName) => {
     const points = await getMetrics(metricName, functionName, fromTime, toTime);
-    // Use short name (last part after the last dot)
     const shortName = metricName.split('.').pop()!;
     return { shortName, points };
   });
@@ -350,7 +341,6 @@ async function getMetrics(
   fromTime: number,
   toTime: number
 ): Promise<MetricPoint[]> {
-  // Strip alias/version from function name - metrics are tagged with base name only
   const baseFunctionName = getServiceName(functionName).toLowerCase();
   const query = `avg:${metricName}{functionname:${baseFunctionName}}`;
 
@@ -371,7 +361,6 @@ async function getMetrics(
     return [];
   }
 
-  // Return points from first series
   return (series[0].pointlist || []).map((p: [number, number]) => ({
     timestamp: p[0],
     value: p[1],

integration-tests/tests/utils/default.ts

@@ -31,7 +31,6 @@ async function invokeThread(
     const result = await invokeLambda(functionName, payload);
     results.push(result);
 
-    // Delay between requests (but not after the last one)
     if (delayBetweenRequestsMs > 0 && i < numInvocations - 1) {
       await sleep(delayBetweenRequestsMs);
     }
@@ -58,10 +57,8 @@ export async function invokeAndCollectTelemetry(
   payload: any = {},
   datadogIndexingWaitMs: number = DEFAULT_DATADOG_INDEXING_WAIT_MS,
 ): Promise<Record<string, DatadogTelemetry>> {
-  // Capture start time for metrics query
   const invocationStartTime = Date.now();
 
-  // Start all threads for all functions in parallel
   const allPromises: { runtime: string; functionName: string; promise: Promise<InvocationResult[]> }[] = [];
 
   for (const fn of functions) {
@@ -74,7 +71,6 @@ export async function invokeAndCollectTelemetry(
     }
   }
 
-  // Wait for all invocations to complete
   const resolvedResults = await Promise.all(
     allPromises.map(async (p) => ({
       runtime: p.runtime,
@@ -83,12 +79,10 @@ export async function invokeAndCollectTelemetry(
     }))
   );
 
-  // Wait for Datadog indexing
   await sleep(datadogIndexingWaitMs);
 
   const metricsEndTime = Date.now();
 
-  // Fetch telemetry (traces/logs) and organize by runtime
   const telemetryByRuntime: Record<string, InvocationTracesLogs[][]> = {};
 
   for (const { runtime, functionName, results } of resolvedResults) {
@@ -117,7 +111,6 @@ export async function invokeAndCollectTelemetry(
     telemetryByRuntime[runtime].push(threadTelemetry);
   }
 
-  // Fetch metrics for each runtime (errors propagate - test will fail)
   const runtimesWithFunctions = functions.map(fn => ({
     runtime: fn.runtime,
     functionName: fn.functionName,
@@ -130,7 +123,6 @@ export async function invokeAndCollectTelemetry(
 
   const metricsResults = await Promise.all(metricsPromises);
 
-  // Combine into DatadogTelemetry
   const result: Record<string, DatadogTelemetry> = {};
 
   for (const fn of functions) {