refactor(otlp): remove redundant should_enable_otlp_agent function

Simplify enablement logic by using only should_enable_http and
should_enable_grpc functions directly. The combined check is now
inlined in start_otlp_agent.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: jchrostek-dd

bottlecap/src/bin/bottlecap/main.rs

@@ -54,7 +54,7 @@ use bottlecap::{
     },
     otlp::{
         agent::Agent as OtlpAgent, grpc_agent::GrpcAgent as OtlpGrpcAgent, should_enable_grpc,
-        should_enable_http, should_enable_otlp_agent,
+        should_enable_http,
     },
     proxy::{interceptor, should_start_proxy},
     secrets::decrypt,
@@ -1357,13 +1357,17 @@ fn start_otlp_agent(
     trace_tx: Sender<SendDataBuilderInfo>,
     stats_concentrator: StatsConcentratorHandle,
 ) -> Option<CancellationToken> {
-    if !should_enable_otlp_agent(config) {
+    let http_enabled = should_enable_http(config);
+    let grpc_enabled = should_enable_grpc(config);
+
+    if !http_enabled && !grpc_enabled {
         return None;
     }
+
     let stats_generator = Arc::new(StatsGenerator::new(stats_concentrator));
 
     // Start HTTP agent if configured
-    if should_enable_http(config) {
+    if http_enabled {
         let agent = OtlpAgent::new(
             config.clone(),
             tags_provider.clone(),
@@ -1380,7 +1384,7 @@ fn start_otlp_agent(
     }
 
     // Start gRPC agent if configured
-    let grpc_cancel_token = if should_enable_grpc(config) {
+    let grpc_cancel_token = if grpc_enabled {
         let grpc_agent = OtlpGrpcAgent::new(
             config.clone(),
             tags_provider,

bottlecap/src/otlp/mod.rs

@@ -7,18 +7,6 @@ pub mod grpc_agent;
 pub mod processor;
 pub mod transform;
 
-/// Check if any OTLP agent (HTTP or gRPC) should be enabled.
-#[must_use]
-pub fn should_enable_otlp_agent(config: &Arc<Config>) -> bool {
-    config.otlp_config_traces_enabled
-        && (config
-            .otlp_config_receiver_protocols_http_endpoint
-            .is_some()
-            || config
-                .otlp_config_receiver_protocols_grpc_endpoint
-                .is_some())
-}
-
 /// Check if the HTTP OTLP agent should be enabled.
 #[must_use]
 pub fn should_enable_http(config: &Arc<Config>) -> bool {
@@ -46,7 +34,7 @@ mod tests {
     use crate::config::get_config;
 
     #[test]
-    fn test_should_enable_otlp_agent_from_yaml() {
+    fn test_should_enable_http_from_yaml() {
         figment::Jail::expect_with(|jail| {
             jail.clear_env();
             jail.create_file(
@@ -60,35 +48,35 @@ mod tests {
             ",
             )?;
 
-            let config = get_config(Path::new(""));
+            let config = Arc::new(get_config(Path::new("")));
 
-            // Since the default for traces is `true`, we don't need to set it.
-            assert!(should_enable_otlp_agent(&Arc::new(config)));
+            assert!(should_enable_http(&config));
+            assert!(!should_enable_grpc(&config));
 
             Ok(())
         });
     }
 
     #[test]
-    fn test_should_enable_otlp_agent_from_env_vars() {
+    fn test_should_enable_http_from_env_vars() {
         figment::Jail::expect_with(|jail| {
             jail.clear_env();
             jail.set_env(
                 "DD_OTLP_CONFIG_RECEIVER_PROTOCOLS_HTTP_ENDPOINT",
                 "0.0.0.0:4318",
             );
 
-            let config = get_config(Path::new(""));
+            let config = Arc::new(get_config(Path::new("")));
 
-            // Since the default for traces is `true`, we don't need to set it.
-            assert!(should_enable_otlp_agent(&Arc::new(config)));
+            assert!(should_enable_http(&config));
+            assert!(!should_enable_grpc(&config));
 
             Ok(())
         });
     }
 
     #[test]
-    fn test_should_not_enable_otlp_agent_if_traces_are_disabled() {
+    fn test_should_not_enable_http_if_traces_disabled() {
         figment::Jail::expect_with(|jail| {
             jail.clear_env();
             jail.set_env("DD_OTLP_CONFIG_TRACES_ENABLED", "false");
@@ -97,16 +85,16 @@ mod tests {
                 "0.0.0.0:4318",
             );
 
-            let config = get_config(Path::new(""));
+            let config = Arc::new(get_config(Path::new("")));
 
-            assert!(!should_enable_otlp_agent(&Arc::new(config)));
+            assert!(!should_enable_http(&config));
 
             Ok(())
         });
     }
 
     #[test]
-    fn test_should_enable_otlp_agent_with_grpc_endpoint() {
+    fn test_should_enable_grpc_from_env_vars() {
         figment::Jail::expect_with(|jail| {
             jail.clear_env();
             jail.set_env(
@@ -116,7 +104,6 @@ mod tests {
 
             let config = Arc::new(get_config(Path::new("")));
 
-            assert!(should_enable_otlp_agent(&config));
             assert!(should_enable_grpc(&config));
             assert!(!should_enable_http(&config));
 
@@ -139,7 +126,6 @@ mod tests {
 
             let config = Arc::new(get_config(Path::new("")));
 
-            assert!(should_enable_otlp_agent(&config));
             assert!(should_enable_http(&config));
             assert!(should_enable_grpc(&config));
 
@@ -159,7 +145,6 @@ mod tests {
 
             let config = Arc::new(get_config(Path::new("")));
 
-            assert!(!should_enable_otlp_agent(&config));
             assert!(!should_enable_grpc(&config));
 
             Ok(())