chore: better VERSION handling for publishing layers

Author: apiarian-datadog

.gitlab/scripts/publish_layers.sh

@@ -104,6 +104,8 @@ if [ "$AUTOMATICALLY_BUMP_VERSION" = "1" ]; then
 else
     if [ -z "$CI_COMMIT_TAG" ]; then
         if [ -n "$VERSION" ]; then
+            # This is used in our publish_govcloud_layers.sh script. We set the
+            # VERSION manually there since we don't have a CI_COMMIT_TAG.
             printf "VERSION exists so we should be okay to continue\n"
         else
             printf "[ERROR]: No CI_COMMIT_TAG found and VERSION is not nuymeric.\n"

scripts/publish_govcloud_layers.sh

@@ -47,6 +47,11 @@ elif [ $ENVIRONMENT = "us1-fed" ]; then
     export ADD_LAYER_VERSION_PERMISSIONS=1
     export AUTOMATICALLY_BUMP_VERSION=0
 
+    if [[ -z "$VERSION" ]]; then
+        printf "[ERROR]: VERSION not specified\n"
+        exit 1
+    fi
+
     if [[ ! "$PACKAGE_NAME" =~ ^datadog_extension-signed-bundle-[0-9]+$ ]]; then
         echo "[ERROR]: Unexpected package name: $PACKAGE_NAME"
         exit 1