Skip to content

Commit be16a13

Browse files
committed
fix: Lower log level for some span deduper logs
1 parent 06798fe commit be16a13

2 files changed

Lines changed: 8 additions & 4 deletions

File tree

bottlecap/src/traces/span_dedup_service.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
use tokio::sync::{mpsc, oneshot};
55
use tokio::time::Duration;
6-
use tracing::warn;
6+
use tracing::info;
77

88
use crate::traces::span_dedup::{DedupKey, Deduper};
99

@@ -95,7 +95,9 @@ impl DedupService {
9595
DedupCommand::CheckAndAdd(key, response_tx) => {
9696
let was_added = self.deduper.check_and_add(key);
9797
if let Err(e) = response_tx.send(was_added) {
98-
warn!("Failed to send check_and_add response: {e:?}");
98+
// Not using warn or error level to avoid confusion for customers.
99+
// No action is needed on customer side.
100+
info!("Failed to send check_and_add response: {e:?}");
99101
}
100102
}
101103
}

bottlecap/src/traces/trace_agent.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ use tokio::sync::{
1919
};
2020
use tokio_util::sync::CancellationToken;
2121
use tower_http::limit::RequestBodyLimitLayer;
22-
use tracing::{debug, error, warn};
22+
use tracing::{debug, error, info, warn};
2323

2424
use crate::traces::trace_processor::SendingTraceProcessor;
2525
use crate::{
@@ -557,7 +557,9 @@ impl TraceAgent {
557557
should_keep
558558
}
559559
Err(e) => {
560-
warn!("Failed to check span in deduper, keeping span: {e}");
560+
// Not using warn or error level to avoid confusion for customers.
561+
// No action is needed on customer side.
562+
info!("Failed to check span in deduper, keeping span: {e}");
561563
true
562564
}
563565
};

0 commit comments

Comments
 (0)