Commit bfade6e
authored
perf(logger): replace serde_json::json! with zero-allocation write! in logger (#1042)
## Summary
Root cause: commit 3b533a0 introduced `serde_json::json!()` for JSON
formatting, adding per-call heap pressure and a new crate dependency
that contributes to Lambda init duration regression
JIRA: https://datadoghq.atlassian.net/browse/SVLS-8619
- Replaces `serde_json::json!()` in `logger.rs` with direct
`write!`/`writeln!` calls to the tracing `Writer`, eliminating two heap
allocations (a `Map` + `Value`) per log call
- Adds a `write_json_escaped` helper that handles all 6 mandatory JSON
escape sequences inline (`"`, `\`, `\n`, `\r`, `\t`, U+0000–U+001F)
- Removes the `"json"` feature from `tracing-subscriber`, dropping
`tracing-serde` as a transitive dependency and reducing binary size
- The JSON output format is **identical** — no observable behavior
change
## Test plan
- unit tests
- self-monitoring tests1 parent 6c7ed88 commit bfade6e
File tree
4 files changed
+70
-22
lines changed- bottlecap
- src
4 files changed
+70
-22
lines changedSome generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
37 | | - | |
| 37 | + | |
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
235 | 235 | | |
236 | 236 | | |
237 | 237 | | |
238 | | - | |
239 | 238 | | |
240 | 239 | | |
241 | 240 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
9 | 26 | | |
10 | 27 | | |
11 | 28 | | |
| |||
62 | 79 | | |
63 | 80 | | |
64 | 81 | | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
72 | 85 | | |
73 | 86 | | |
74 | 87 | | |
| |||
116 | 129 | | |
117 | 130 | | |
118 | 131 | | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
119 | 181 | | |
120 | 182 | | |
121 | 183 | | |
| |||
0 commit comments