Skip to content

Commit ec33d19

Browse files
committed
Rename: ssl_ca_cert -> tls_ca_cert
1 parent fcf63ac commit ec33d19

5 files changed

Lines changed: 23 additions & 23 deletions

File tree

bottlecap/src/config/env.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -75,11 +75,11 @@ pub struct EnvConfig {
7575
/// The transport type to use for sending logs. Possible values are "auto" or "http1".
7676
#[serde(deserialize_with = "deserialize_optional_string")]
7777
pub http_protocol: Option<String>,
78-
/// @env `DD_SSL_CA_CERT`
79-
/// The SSL CA certificate path to use for the Datadog Agent.
78+
/// @env `DD_CLS_CA_CERT`
79+
/// The path to a file of concatenated CA certificates in PEM format.
8080
/// Example: `/opt/ca-cert.pem`
8181
#[serde(deserialize_with = "deserialize_optional_string")]
82-
pub ssl_ca_cert: Option<String>,
82+
pub cls_ca_cert: Option<String>,
8383

8484
// Metrics
8585
/// @env `DD_DD_URL`
@@ -471,7 +471,7 @@ fn merge_config(config: &mut Config, env_config: &EnvConfig) {
471471
merge_option!(config, env_config, proxy_https);
472472
merge_vec!(config, env_config, proxy_no_proxy);
473473
merge_option!(config, env_config, http_protocol);
474-
merge_option!(config, env_config, ssl_ca_cert);
474+
merge_option!(config, env_config, cls_ca_cert);
475475

476476
// Endpoints
477477
merge_string!(config, env_config, dd_url);
@@ -701,7 +701,7 @@ mod tests {
701701
jail.set_env("DD_PROXY_HTTPS", "https://proxy.example.com");
702702
jail.set_env("DD_PROXY_NO_PROXY", "localhost,127.0.0.1");
703703
jail.set_env("DD_HTTP_PROTOCOL", "http1");
704-
jail.set_env("DD_SSL_CA_CERT", "/opt/ca-cert.pem");
704+
jail.set_env("DD_CLS_CA_CERT", "/opt/ca-cert.pem");
705705

706706
// Metrics
707707
jail.set_env("DD_DD_URL", "https://metrics.datadoghq.com");
@@ -857,7 +857,7 @@ mod tests {
857857
proxy_https: Some("https://proxy.example.com".to_string()),
858858
proxy_no_proxy: vec!["localhost".to_string(), "127.0.0.1".to_string()],
859859
http_protocol: Some("http1".to_string()),
860-
ssl_ca_cert: Some("/opt/ca-cert.pem".to_string()),
860+
cls_ca_cert: Some("/opt/ca-cert.pem".to_string()),
861861
dd_url: "https://metrics.datadoghq.com".to_string(),
862862
url: "https://app.datadoghq.com".to_string(),
863863
additional_endpoints: HashMap::from([

bottlecap/src/config/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ pub struct Config {
252252
pub proxy_https: Option<String>,
253253
pub proxy_no_proxy: Vec<String>,
254254
pub http_protocol: Option<String>,
255-
pub ssl_ca_cert: Option<String>,
255+
pub cls_ca_cert: Option<String>,
256256

257257
// Endpoints
258258
pub dd_url: String,
@@ -367,7 +367,7 @@ impl Default for Config {
367367
proxy_https: None,
368368
proxy_no_proxy: vec![],
369369
http_protocol: None,
370-
ssl_ca_cert: None,
370+
cls_ca_cert: None,
371371

372372
// Endpoints
373373
dd_url: String::default(),

bottlecap/src/config/yaml.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ pub struct YamlConfig {
5454
#[serde(deserialize_with = "deserialize_optional_string")]
5555
pub http_protocol: Option<String>,
5656
#[serde(deserialize_with = "deserialize_optional_string")]
57-
pub ssl_ca_cert: Option<String>,
57+
pub cls_ca_cert: Option<String>,
5858

5959
// Endpoints
6060
#[serde(deserialize_with = "deserialize_additional_endpoints")]
@@ -419,7 +419,7 @@ fn merge_config(config: &mut Config, yaml_config: &YamlConfig) {
419419
merge_option!(config, proxy_https, yaml_config.proxy, https);
420420
merge_option_to_value!(config, proxy_no_proxy, yaml_config.proxy, no_proxy);
421421
merge_option!(config, yaml_config, http_protocol);
422-
merge_option!(config, yaml_config, ssl_ca_cert);
422+
merge_option!(config, yaml_config, cls_ca_cert);
423423

424424
// Endpoints
425425
merge_hashmap!(config, yaml_config, additional_endpoints);
@@ -750,7 +750,7 @@ proxy:
750750
no_proxy: ["localhost", "127.0.0.1"]
751751
dd_url: "https://metrics.datadoghq.com"
752752
http_protocol: "http1"
753-
ssl_ca_cert: "/opt/ca-cert.pem"
753+
cls_ca_cert: "/opt/ca-cert.pem"
754754
755755
# Endpoints
756756
additional_endpoints:
@@ -886,7 +886,7 @@ api_security_sample_delay: 60 # Seconds
886886
proxy_https: Some("https://proxy.example.com".to_string()),
887887
proxy_no_proxy: vec!["localhost".to_string(), "127.0.0.1".to_string()],
888888
http_protocol: Some("http1".to_string()),
889-
ssl_ca_cert: Some("/opt/ca-cert.pem".to_string()),
889+
cls_ca_cert: Some("/opt/ca-cert.pem".to_string()),
890890
dd_url: "https://metrics.datadoghq.com".to_string(),
891891
url: String::new(), // doesnt exist in yaml
892892
additional_endpoints: HashMap::from([

bottlecap/src/traces/stats_flusher.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ impl StatsFlusher for ServerlessStatsFlusher {
104104

105105
let Ok(http_client) = ServerlessTraceFlusher::get_http_client(
106106
self.config.proxy_https.as_ref(),
107-
self.config.ssl_ca_cert.as_ref(),
107+
self.config.cls_ca_cert.as_ref(),
108108
) else {
109109
error!("STATS_FLUSHER | Failed to create HTTP client");
110110
return;

bottlecap/src/traces/trace_flusher.rs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ pub trait TraceFlusher {
4141
traces: Vec<SendData>,
4242
endpoint: Option<&Endpoint>,
4343
proxy_https: &Option<String>,
44-
ssl_ca_cert: &Option<String>,
44+
cls_ca_cert: &Option<String>,
4545
) -> Option<Vec<SendData>>;
4646

4747
/// Flushes traces by getting every available batch on the aggregator.
@@ -115,7 +115,7 @@ impl TraceFlusher for ServerlessTraceFlusher {
115115
traces,
116116
None,
117117
&self.config.proxy_https,
118-
&self.config.ssl_ca_cert,
118+
&self.config.cls_ca_cert,
119119
)
120120
.await;
121121
if retry_result.is_some() {
@@ -144,17 +144,17 @@ impl TraceFlusher for ServerlessTraceFlusher {
144144

145145
let traces_clone = traces.clone();
146146
let proxy_https = self.config.proxy_https.clone();
147-
let ssl_ca_cert = self.config.ssl_ca_cert.clone();
147+
let cls_ca_cert = self.config.cls_ca_cert.clone();
148148
batch_tasks.spawn(async move {
149-
Self::send(traces_clone, None, &proxy_https, &ssl_ca_cert).await
149+
Self::send(traces_clone, None, &proxy_https, &cls_ca_cert).await
150150
});
151151

152152
for endpoint in self.additional_endpoints.clone() {
153153
let traces_clone = traces.clone();
154154
let proxy_https = self.config.proxy_https.clone();
155-
let ssl_ca_cert = self.config.ssl_ca_cert.clone();
155+
let cls_ca_cert = self.config.cls_ca_cert.clone();
156156
batch_tasks.spawn(async move {
157-
Self::send(traces_clone, Some(&endpoint), &proxy_https, &ssl_ca_cert).await
157+
Self::send(traces_clone, Some(&endpoint), &proxy_https, &cls_ca_cert).await
158158
});
159159
}
160160
}
@@ -175,7 +175,7 @@ impl TraceFlusher for ServerlessTraceFlusher {
175175
traces: Vec<SendData>,
176176
endpoint: Option<&Endpoint>,
177177
proxy_https: &Option<String>,
178-
ssl_ca_cert: &Option<String>,
178+
cls_ca_cert: &Option<String>,
179179
) -> Option<Vec<SendData>> {
180180
if traces.is_empty() {
181181
return None;
@@ -186,7 +186,7 @@ impl TraceFlusher for ServerlessTraceFlusher {
186186
debug!("TRACES | Flushing {} traces", coalesced_traces.len());
187187

188188
let Ok(http_client) =
189-
ServerlessTraceFlusher::get_http_client(proxy_https.as_ref(), ssl_ca_cert.as_ref())
189+
ServerlessTraceFlusher::get_http_client(proxy_https.as_ref(), cls_ca_cert.as_ref())
190190
else {
191191
error!("TRACES | Failed to create HTTP client");
192192
return None;
@@ -227,13 +227,13 @@ fn ensure_crypto_provider_initialized() {
227227
impl ServerlessTraceFlusher {
228228
pub fn get_http_client(
229229
proxy_https: Option<&String>,
230-
ssl_ca_cert: Option<&String>,
230+
cls_ca_cert: Option<&String>,
231231
) -> Result<
232232
GenericHttpClient<hyper_http_proxy::ProxyConnector<libdd_common::connector::Connector>>,
233233
Box<dyn Error>,
234234
> {
235235
// Create the base connector with optional custom TLS config
236-
let connector = if let Some(ca_cert_path) = ssl_ca_cert {
236+
let connector = if let Some(ca_cert_path) = cls_ca_cert {
237237
// Ensure crypto provider is initialized before creating TLS config
238238
ensure_crypto_provider_initialized();
239239

0 commit comments

Comments
 (0)