Skip to content

[SVLS-8150] fix(config): ensure logs intake URL is correctly prefixed#1021

Merged
shreyamalpani merged 3 commits intomainfrom
shreya.malpani/fix-logs-dd-url
Feb 9, 2026
Merged

[SVLS-8150] fix(config): ensure logs intake URL is correctly prefixed#1021
shreyamalpani merged 3 commits intomainfrom
shreya.malpani/fix-logs-dd-url

Conversation

@shreyamalpani
Copy link
Copy Markdown
Contributor

Overview

Ensures DD_LOGS_CONFIG_LOGS_DD_URL is correctly prefixed with https://

Testing

Manually tested that logs get sent to alternate logs intake

@shreyamalpani shreyamalpani marked this pull request as ready for review February 6, 2026 22:46
@shreyamalpani shreyamalpani requested a review from a team as a code owner February 6, 2026 22:46
@duncanista duncanista requested a review from Copilot February 7, 2026 01:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Ensures DD_LOGS_CONFIG_LOGS_DD_URL is normalized so custom logs intake URLs are properly scheme-prefixed (intended https://) before being used.

Changes:

  • Normalize non-default logs_config_logs_dd_url via a new logs_intake_url() helper.
  • Update/extend config tests to assert https:// prefixing behavior for env-provided logs intake URLs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread bottlecap/src/config/mod.rs Outdated
Comment thread bottlecap/src/config/mod.rs
Comment thread bottlecap/src/config/mod.rs
Comment thread bottlecap/src/config/mod.rs
Comment thread bottlecap/src/config/mod.rs
@duncanista
Copy link
Copy Markdown
Contributor

Feel free to ignore some of Copilots suggestions as they might be wrong

Copy link
Copy Markdown
Contributor

@duncanista duncanista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock, ensure to get latest main rebased so audit doesn't complain

@shreyamalpani shreyamalpani merged commit 2c61aca into main Feb 9, 2026
48 of 50 checks passed
@shreyamalpani shreyamalpani deleted the shreya.malpani/fix-logs-dd-url branch February 9, 2026 21:11
duncanpharvey pushed a commit that referenced this pull request Mar 10, 2026
…#1021)

## Overview

Ensures `DD_LOGS_CONFIG_LOGS_DD_URL` is correctly prefixed with
`https://`

## Testing 

Manually tested that logs get sent to alternate logs intake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants