[SVLS-8150] fix(config): ensure logs intake URL is correctly prefixed#1021
Merged
shreyamalpani merged 3 commits intomainfrom Feb 9, 2026
Merged
[SVLS-8150] fix(config): ensure logs intake URL is correctly prefixed#1021shreyamalpani merged 3 commits intomainfrom
shreyamalpani merged 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Ensures DD_LOGS_CONFIG_LOGS_DD_URL is normalized so custom logs intake URLs are properly scheme-prefixed (intended https://) before being used.
Changes:
- Normalize non-default
logs_config_logs_dd_urlvia a newlogs_intake_url()helper. - Update/extend config tests to assert
https://prefixing behavior for env-provided logs intake URLs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Feel free to ignore some of Copilots suggestions as they might be wrong |
duncanista
approved these changes
Feb 7, 2026
Contributor
duncanista
left a comment
There was a problem hiding this comment.
Approving to unblock, ensure to get latest main rebased so audit doesn't complain
duncanpharvey
pushed a commit
that referenced
this pull request
Mar 10, 2026
…#1021) ## Overview Ensures `DD_LOGS_CONFIG_LOGS_DD_URL` is correctly prefixed with `https://` ## Testing Manually tested that logs get sent to alternate logs intake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Ensures
DD_LOGS_CONFIG_LOGS_DD_URLis correctly prefixed withhttps://Testing
Manually tested that logs get sent to alternate logs intake