[SVLS-8581] feat: Add durable_function:true tag to enhanced metrics#1048
Merged
[SVLS-8581] feat: Add durable_function:true tag to enhanced metrics#1048
Conversation
lym953
changed the title
lym953
force-pushed
the
yiming.luo/metrics-durable-tag
branch
from
fe9e018 to
7784a8d
Compare
duncanista
reviewed
Feb 26, 2026
| pub fn on_platform_init_start(&mut self, time: DateTime<Utc>) { | ||
| pub fn on_platform_init_start(&mut self, time: DateTime<Utc>, runtime_version: Option<String>) { | ||
| if let Some(ref rv) = runtime_version { | ||
| debug!("Runtime version: {}", rv); |
Contributor
There was a problem hiding this comment.
Is this debug log required? It always appear at the top of the platform init start
Contributor
Author
There was a problem hiding this comment.
I don't have a strong opinion. I added this in case AWS changes the format one day. But that should be able to be captured by e2e tests when they are ready. Let me remove it then.
duncanista
approved these changes
Feb 26, 2026
helen278
approved these changes
Feb 26, 2026
helen278
left a comment
helen278
left a comment
There was a problem hiding this comment.
LGTM but are there links for me to test this in the UI? (or is this just your local)? I noticed screenshots.
Contributor
Author
|
However, sometimes it somehow stops working and recovers later. I'll investigate further. |
…n runtimes When the PlatformInitStart payload contains a runtime_version field with "DurableFunction" (e.g. "python:3.14.DurableFunction.v6"), set the tag durable_function:true on all enhanced metrics generated by the extension. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
lym953
force-pushed
the
yiming.luo/metrics-durable-tag
branch
from
d44d995 to
3c50d85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
When the Lambda function's runtime version contains "RuntimeVersion", add the tag
durable_function:trueto enhanced metrics generated by the extension, so the facetdurable_functionappears on Serverless View.Sample value of runtime version:
python:3.14.DurableFunction.v9nodejs:24.DurableFunction.v10Testing
Steps
Result
durable_function:true, the function appears in the result.durable_functionappears on the sidebar.-durable_function:true, other functions appear in the result.