Skip to content

Add /symdb/v1/input proxy endpoint to bottlecap #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jchrostek-dd wants to merge 1 commit into from
Closed

Add /symdb/v1/input proxy endpoint to bottlecap #1159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions bottlecap/src/traces/trace_agent.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ const INFO_ENDPOINT_PATH: &str = "/info";
const V1_DEBUGGER_ENDPOINT_PATH: &str = "/debugger/v1/input";
const V2_DEBUGGER_ENDPOINT_PATH: &str = "/debugger/v2/input";
const DEBUGGER_DIAGNOSTICS_ENDPOINT_PATH: &str = "/debugger/v1/diagnostics";
const SYMDB_ENDPOINT_PATH: &str = "/symdb/v1/input";
const INSTRUMENTATION_ENDPOINT_PATH: &str = "/telemetry/proxy/api/v2/apmtelemetry";

// Intake endpoints
Expand Down Expand Up @@ -272,6 +273,7 @@ impl TraceAgent {
DEBUGGER_DIAGNOSTICS_ENDPOINT_PATH,
post(Self::debugger_intake_proxy),
)
.route(SYMDB_ENDPOINT_PATH, post(Self::symdb_proxy))
.route(
INSTRUMENTATION_ENDPOINT_PATH,
post(Self::instrumentation_proxy),
Expand Down Expand Up @@ -428,6 +430,19 @@ impl TraceAgent {
.await
}

// Used for `/symdb/v1/input` in Symbol Database uploads
async fn symdb_proxy(State(state): State<ProxyState>, request: Request) -> Response {
Self::handle_proxy(
state.config,
state.proxy_aggregator,
request,
"debugger-intake",
V2_DEBUGGER_INTAKE_PATH,
"symdb",
)
.await
}

async fn instrumentation_proxy(State(state): State<ProxyState>, request: Request) -> Response {
Self::handle_proxy(
state.config,
Expand Down Expand Up @@ -457,6 +472,7 @@ impl TraceAgent {
V1_DEBUGGER_ENDPOINT_PATH,
V2_DEBUGGER_ENDPOINT_PATH,
DEBUGGER_DIAGNOSTICS_ENDPOINT_PATH,
SYMDB_ENDPOINT_PATH,
],
"client_drop_p0s": true,
}
Expand Down Expand Up @@ -667,6 +683,30 @@ impl TraceAgent {
};

let target_url = format!("https://{}.{}{}", backend_domain, config.site, backend_path);

// Log detailed info for debugger endpoints
if context == "debugger" || context == "debugger_logs" {
let body_len = body.len();
debug!(
"TRACE_AGENT | Debugger proxy request: context={}, target_url={}, payload_size={} bytes",
context, target_url, body_len
);
// Log payload preview (first 1000 chars) for debugging
if let Ok(body_str) = std::str::from_utf8(&body) {
let preview = if body_str.len() > 1000 {
format!("{}... (truncated)", &body_str[..1000])
} else {
body_str.to_string()
};
debug!("TRACE_AGENT | Debugger payload preview: {}", preview);
Comment on lines +695 to +701
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logging code on lines 695-701 logs up to 1000 characters of the payload body for debugger endpoints. This could expose sensitive information such as source code, variable names, and other context from debugger snapshots. Consider logging only non-sensitive metadata (e.g., payload size, timestamp) instead of actual payload content.

Copilot generated this review using guidance from repository custom instructions.
} else {
debug!(
"TRACE_AGENT | Debugger payload is binary data, {} bytes",
body_len
);
}
}

let proxy_request = ProxyRequest {
headers: parts.headers,
body,
Expand Down
Loading