[SVLS-8704] Set durable_function.execution_status on END platform logs#1188
Open
[SVLS-8704] Set durable_function.execution_status on END platform logs#1188
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ca78ba9 to
53a9b6b
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR propagates Durable Function execution status from tracer span tags into Lambda END platform logs so the log stream can be correlated with final durable execution outcomes.
Changes:
- Extract
aws_lambda.durable_function.execution_statusfrom theaws.lambdaspan and forward it through the invocation/logs pipeline. - Add a new log attribute
durable_function.execution_status(serialized undermessage.lambda) and set it on END logs. - Add a unit test covering status-present and status-absent cases for END logs.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| bottlecap/src/traces/trace_agent.rs | Extracts execution status from span metadata and forwards it with the durable context. |
| bottlecap/src/tags/lambda/tags.rs | Adds the durable execution status span tag constant. |
| bottlecap/src/logs/processor.rs | Threads execution status through the durable context update handling. |
| bottlecap/src/logs/lambda/processor.rs | Stores execution status in durable context and applies it to END logs; adds a test. |
| bottlecap/src/logs/lambda/mod.rs | Adds durable_function.execution_status to the serialized Lambda log schema. |
| bottlecap/src/lifecycle/invocation/processor_service.rs | Extends the durable context forwarding command to include execution status. |
| bottlecap/src/lifecycle/invocation/processor.rs | Forwards execution status to the logs agent via DurableContextUpdate. |
…a clone Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
durable_function.execution_statusas a log attribute on END platform logs (END RequestId:) for durable function invocationsaws_lambda.durable_function.execution_statustag of theaws.lambdaspan, added by the tracerAutomated testing
test_execution_status_on_end_logcovering both the status-present (SUCCEEDED) and status-absent (None) casesManual testing
For durable functions, execution status is added to END log:
