Merged
Conversation
duncanista
reviewed
Mar 7, 2025
Contributor
duncanista
left a comment
duncanista
left a comment
There was a problem hiding this comment.
Great, thanks for modifying this – glad we caught it before it went out!
duncanista
approved these changes
Mar 7, 2025
… case to reduce code duplication. Move periodic case into conditional at top of no-flush
duncanista
reviewed
Mar 7, 2025
…etry event and break where it makes sense
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case of a function running once every few hours, we may not block for the platform.report event.
this PR modifies the loop to wait for this event so we set some enhanced metrics after a single function execution.