Skip to content

fix: max duration 15 minutes #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
astuyve merged 2 commits into from
Mar 10, 2025
Merged

fix: max duration 15 minutes #599

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9abb7c2
fix: max duration 15 minutes
astuyve Mar 10, 2025
2ab2f9c
fix: fmt
astuyve Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions bottlecap/src/lifecycle/flush_control.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ use crate::lifecycle::invocation_times::InvocationTimes;

const DEFAULT_FLUSH_INTERVAL: u64 = 60 * 1000; // 60s
const TWENTY_SECONDS: u64 = 20 * 1000;
const FIFTEEN_MINUTES: u64 = 15 * 60 * 1000;

#[derive(Clone, Copy, Debug, PartialEq)]
pub struct FlushControl {
Expand Down Expand Up @@ -63,7 +64,9 @@ impl FlushControl {
FlushStrategy::Periodically(p) | FlushStrategy::EndPeriodically(p) => {
tokio::time::interval(tokio::time::Duration::from_millis(p.interval))
}
FlushStrategy::End => tokio::time::interval(tokio::time::Duration::MAX),
FlushStrategy::End => {
tokio::time::interval(tokio::time::Duration::from_millis(FIFTEEN_MINUTES))
}
}
}

Expand Down Expand Up @@ -165,7 +168,7 @@ mod tests {
let flush_control = FlushControl::new(FlushStrategy::End);
assert_eq!(
flush_control.get_flush_interval().period().as_millis(),
tokio::time::Duration::MAX.as_millis()
tokio::time::Duration::from_millis(FIFTEEN_MINUTES).as_millis()
);
}
}
Loading